fanquake fdfaeb67de
Merge #16956: validation: Make GetWitnessCommitmentIndex public
fa607c229295e0f0b89d5177b94d3381ab5e37d8 validation: Make GetWitnessCommitmentIndex public (MarcoFalke)

Pull request description:

  `GenerateCoinbaseCommitment` is public and can be used in unit tests to update the witness commitment after the list of txs in a block has been changed. However, for it to work, the existing commitment (added by default in `CreateNewBlock`) must be removed (and thus its index must be known).

  Make that possible by exposing the `GetWitnessCommitmentIndex` helper function in the header.

ACKs for top commit:
  jb55:
    ACK fa607c229295e0f0b89d5177b94d3381ab5e37d8
  jamesob:
    ACK fa607c2292
  promag:
    ACK fa607c229295e0f0b89d5177b94d3381ab5e37d8.
  fanquake:
    ACK fa607c229295e0f0b89d5177b94d3381ab5e37d8 - This unblocks work in #15845.

Tree-SHA512: d563aa2c201d5fb4874e506a28f468c37e457cc8a20229c377178af08c22d3be44e19ee6e8e524b6de99236cd5f2c9e39b8009d88c26854aa774737912bd5889
2019-09-26 17:07:20 +08:00
..
2019-01-26 12:45:48 -05:00
2018-09-07 08:21:14 -04:00
2018-12-29 10:15:01 +01:00
2018-08-13 13:57:15 +02:00
2018-07-27 07:15:02 -04:00
2018-07-27 07:15:02 -04:00
2019-02-22 17:38:45 -08:00
2019-02-22 17:38:45 -08:00
2019-04-10 12:16:52 +01:00
2018-08-11 09:34:47 +03:00
2019-04-09 17:53:08 -04:00
2018-07-27 07:15:02 -04:00
2019-03-27 13:59:50 +01:00
2018-07-27 07:15:02 -04:00
2019-06-20 12:12:24 -04:00
2018-07-27 07:15:02 -04:00
2018-07-27 07:15:02 -04:00
2018-07-27 07:15:02 -04:00
2018-07-27 07:15:02 -04:00
2018-07-27 07:15:02 -04:00
2018-07-27 07:15:02 -04:00
2018-07-27 11:52:18 -07:00
2018-07-27 07:15:02 -04:00
2018-07-27 07:15:02 -04:00
2018-07-27 07:15:02 -04:00