Describes a pull request process that prevents maintainers from
merging code too quickly, giving contributors a chance to react to
changes and voice concerns before a pull request is merged and
closed. This makes development more transparent and inclusive.
The process prescribes a lag time between maintainer approval and
merge of minimally 24 hours because that creates a workable
balance between maintaining development momentum and transparency.
Maintenance tasks are exempt from the lag time requirement, as are
time-critical fixes.
Removes discord because this is a chat channel and not suitable to
make decisions that are auditable.
Adds a link to "help wanted" in the github repository as those are
the most pressing items that help Dogecoin
* Remove references to lead maintainer.
* Put branch strategy near the top so people raise PRs against the right branch.
* Emphasise the need to test, and the types of tests involved.
* Add links to community.
Adding in response to a Slack discussion where someone was unclear on the fact
that a NACK may be justified if code can't be accepted due to copyright/patent
issues. For example, it would be reasonable and prudent to NACK a contribution
of AGPL-licensed consensus code on the basis that the license terms are
incompatible with the MIT license used by the rest of the codebase.
This commit contains two changes to CONTRIBUTING.md that:
Fix line line lengths. There were several instances where line lengths
were well over 80 characters. This commit adjusts them to make them
conform to formatting best practices, to stay under 80 characters when
possible.
Adhere to consist use of quotes. There are a few instances where smart
quotes are used (perhaps because it was pasted from a word processor).
This commit replaces them with dumb quotes to keep it consistent with
the quotation formatting found in the rest of the document.