cryptogera/dogecoin
1
0
Fork 0
mirror of https://github.com/dogecoin/dogecoin.git synced 2026-01-31 10:30:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

bugfix: change asserts into handled failures for cmpctblk

Browse Source 
Replaces assert() calls with if() statements returning functional
failure that can be handled for situations that can be triggered
from outside of compiled code - i.e. peers.

Cherry-picked from: 149be06d
Github Pull Request: #3661
This commit is contained in:
Patrick Lodder 2024-10-09 15:34:16 -04:00
parent cebc99a4ec
commit b5dec96370
No known key found for this signature in database
GPG Key ID: 7C523F5FBABE80E7
1 changed files with 12 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/blockencodings.cpp
View File

@ -53,7 +53,10 @@ ReadStatus PartiallyDownloadedBlock::InitData(const CBlockHeaderAndShortTxIDs& c
if (cmpctblock.shorttxids.size() + cmpctblock.prefilledtxn.size() > MAX_BLOCK_BASE_SIZE / MIN_TRANSACTION_BASE_SIZE)
return READ_STATUS_INVALID;
assert(header.IsNull() && txn_available.empty());
if (!header.IsNull() || !txn_available.empty()) {
return READ_STATUS_FAILED;
}
header = cmpctblock.header;
txn_available.resize(cmpctblock.BlockTxCount());
@ -170,13 +173,19 @@ ReadStatus PartiallyDownloadedBlock::InitData(const CBlockHeaderAndShortTxIDs& c
}
bool PartiallyDownloadedBlock::IsTxAvailable(size_t index) const {
assert(!header.IsNull());
if (header.IsNull()) {
return false;
}
assert(index < txn_available.size());
return txn_available[index] ? true : false;
}
ReadStatus PartiallyDownloadedBlock::FillBlock(CBlock& block, const std::vector<CTransactionRef>& vtx_missing) {
assert(!header.IsNull());
if (header.IsNull()) {
return READ_STATUS_INVALID;
}
uint256 hash = header.GetHash();
block = header;
block.vtx.resize(txn_available.size());