bitcoin

mirror of https://github.com/bitcoin/bitcoin.git synced 2026-01-31 10:41:08 +00:00

History

Merge bitcoin/bitcoin#31242 : wallet, desc spkm: Return SigningProvider only if we have the privkey

f6a6d912059c66792f48689632d2a7f14f8bdad9 test: add check for getting SigningProvider for a CPubKey (Sebastian Falbesoner)
62a95f5af9b998e241eb72c16ba581e77c480126 test: refactor: move `CreateDescriptor` helper to wallet test util module (Sebastian Falbesoner)
493656763f73e5ef1cfb979a513c12983dca99dd desc spkm: Return SigningProvider only if we have the privkey (Ava Chow)

Pull request description:

  If we know about a pubkey that's in our descriptor, but we don't have the private key, don't return a SigningProvider for that pubkey.

  This is specifically an issue for Taproot outputs that use the H point as the resulting PSBTs may end up containing irrelevant information because the H point was detected as a pubkey each unrelated descriptor knew about.

  Split from #29675

ACKs for top commit:
  fjahr:
    ACK f6a6d912059c66792f48689632d2a7f14f8bdad9
  theStack:
    re-ACK f6a6d912059c66792f48689632d2a7f14f8bdad9
  furszy:
    utACK f6a6d912059. Only reviewed the actual change in detail, not the test commit.

Tree-SHA512: 30a196e611a0c5d9ebe5baf6d896caaa6af66f1615463dbb0c31e52604d53cf342922bb9967b3c697b47083d76b0485c77a5f545bd6381247c8bc44321c70f97

2025-01-16 17:30:36 +00:00

fuzz

fuzz: Add SetMockTime() to necessary targets

2025-01-06 15:43:04 +00:00

CMakeLists.txt

build, test: Build db_tests.cpp regardless of USE_BDB

2025-01-07 15:50:39 +00:00

coinselector_tests.cpp

[refactor]: update coin selection algorithms input parameter max_weight name

2024-06-27 12:37:33 +01:00

db_tests.cpp

build, test: Build db_tests.cpp regardless of USE_BDB