fanquake ade38b6ee8

Merge #20588: Remove unused and confusing CTransaction constructor ...

fac39c198324715565897f4240709340477af0bf wallet: document that tx in CreateTransaction is purely an out-param (MarcoFalke)
faac31521bb7ecbf999541cf918d3750ff589de4 Remove unused and confusing CTransaction constructor (MarcoFalke)

Pull request description:

  The constructor is confusing and dangerous (as explained in the TODO), fix that by removing it.

ACKs for top commit:
  laanwj:
    Code review ACK fac39c198324715565897f4240709340477af0bf
  promag:
    Code review ACK fac39c198324715565897f4240709340477af0bf.
  theStack:
    Code review ACK fac39c198324715565897f4240709340477af0bf

Tree-SHA512: e0c8cffce8d8ee0166b8e1cbfe85ed0657611e26e2af0d69fde70eceaa5d75cbde3eb489af0428fe4fc431360b4c791fb1cc21b8dee7d4c7a4f17df00836229d

2020-12-13 10:36:22 +08:00

..

test

Merge #20275: wallet: List all wallets in non-SQLite and non-BDB builds

2020-12-12 09:20:11 +01:00

bdb.cpp

refactor: Consolidate redundant wallet database path and exists functions

2020-12-04 11:03:28 -04:00

bdb.h

refactor: Consolidate redundant wallet database path and exists functions

2020-12-04 11:03:28 -04:00

coincontrol.cpp

[rpc] walletcreatefundedpsbt: don't automatically append inputs

2020-03-12 13:07:17 +01:00

coincontrol.h

[rpc] walletcreatefundedpsbt: don't automatically append inputs

2020-03-12 13:07:17 +01:00

coinselection.cpp

Refactor OutputGroups to handle effective values, fees, and filtering

2020-08-11 14:25:02 -04:00

coinselection.h

Refactor OutputGroups to handle effective values, fees, and filtering

2020-08-11 14:25:02 -04:00

context.cpp

Remove g_rpc_chain global

2020-05-28 02:13:19 -04:00

context.h

wallet: Pass unused args to StartWallets

2020-07-09 13:07:37 +02:00

crypter.cpp

…

crypter.h

Convert wallet to new serialization

2020-05-24 10:34:52 -07:00

db.cpp

wallet: List all wallets in non-SQLite or non-BDB builds

2020-12-04 11:03:28 -04:00

db.h

refactor: Consolidate redundant wallet database path and exists functions

2020-12-04 11:03:28 -04:00

feebumper.cpp

Remove unused and confusing CTransaction constructor

2020-12-07 14:59:33 +01:00

feebumper.h

wallet: Avoid translating RPC errors when creating txs

2020-05-01 07:39:06 -04:00

fees.cpp

…

fees.h

…

init.cpp

Do not compile BDB things when USE_BDB is defined

2020-11-18 11:56:08 -05:00

interfaces.cpp

Merge #20275: wallet: List all wallets in non-SQLite and non-BDB builds

2020-12-12 09:20:11 +01:00

ismine.h

…

load.cpp

Ignoring (but warn) on duplicate -wallet parameters

2020-11-03 12:06:32 +01:00

load.h

Do not create default wallet

2020-09-08 21:02:53 -04:00

rpcdump.cpp

Merge #20153: wallet: do not import a descriptor with hardened derivations into a watch-only wallet

2020-11-09 20:19:00 +01:00

rpcwallet.cpp

Merge #20275: wallet: List all wallets in non-SQLite and non-BDB builds

2020-12-12 09:20:11 +01:00

rpcwallet.h

Assert that RPCArg names are equal to CRPCCommand ones (net, rpcwallet)

2020-09-22 20:49:30 +02:00

salvage.cpp

refactor: Drop call to GetWalletEnv in wallet salvage code

2020-12-04 11:03:28 -04:00

salvage.h

wallettool: Have RecoverDatabaseFile return errors and warnings

2020-07-26 20:22:45 -04:00

scriptpubkeyman.cpp

Merge #20403: wallet: upgradewallet fixes, improvements, test coverage

2020-11-25 12:46:27 +01:00

scriptpubkeyman.h

refactor: Improve use of explicit keyword

2020-12-01 18:36:39 +01:00

sqlite.cpp

refactor: Consolidate redundant wallet database path and exists functions

2020-12-04 11:03:28 -04:00

sqlite.h

refactor: Consolidate redundant wallet database path and exists functions

2020-12-04 11:03:28 -04:00

wallet.cpp

Merge #20588: Remove unused and confusing CTransaction constructor

2020-12-13 10:36:22 +08:00

wallet.h

Merge #19980: refactor: Some wallet cleanups

2020-12-02 08:23:00 +08:00

walletdb.cpp

refactor: Consolidate redundant wallet database path and exists functions

2020-12-04 11:03:28 -04:00

walletdb.h

Include wallet/bdb.h where it is actually being used

2020-11-18 11:55:43 -05:00

wallettool.cpp

Do not compile BDB things when USE_BDB is defined

2020-11-18 11:56:08 -05:00

wallettool.h

wallet: Remove path checking code from bitcoin-wallet tool

2020-09-03 12:24:32 -04:00

walletutil.cpp

MOVEONLY: Move IsBDBFile, IsSQLiteFile, and ListWalletDir

2020-12-04 11:03:28 -04:00

walletutil.h

refactor: Replace ListWalletDir() function with ListDatabases()

2020-12-04 11:03:28 -04:00