Ava Chow a7129f827c

Merge bitcoin/bitcoin#24313: Improve display address handling for external signer ...

4357158c4712d479522d5cd441ad4dd1693fdd05 wallet: return and display signer error (Sjors Provoost)
dc55531087478d01fbde4f5fbb75375b672960c3 wallet: compare address returned by displayaddress (Sjors Provoost)
6c1a2cc09a00baa6ff3ff34455c2243b43067fb5 test: use h marker for external signer mock (Sjors Provoost)

Pull request description:

  * HWI returns the requested address: as a sanity check, we now compare that to what we expected
     * external signer documentation now reflects that HWI alternatives must implement this check
  * both RPC and GUI will now return an error text, rather than just fail (the GUI even failed silently in some cases)

ACKs for top commit:
  brunoerg:
    ACK 4357158c4712d479522d5cd441ad4dd1693fdd05
  achow101:
    ACK 4357158c4712d479522d5cd441ad4dd1693fdd05

Tree-SHA512: 4f56edf3846745c8e7d08ef55cf29e8bb468256457149377c5f02da097931f9ca0c06bdbd856dc2385cde4fd11e4dc3b634c5a48814ff27f5562c8a25d43da93

2024-04-23 17:20:54 -04:00

..

rpc

wallet: return and display signer error

2024-04-16 17:47:43 +02:00

test

Merge bitcoin/bitcoin#29130: wallet: Add createwalletdescriptor and gethdkeys RPCs for adding new automatically generated descriptors

2024-03-29 06:39:57 -04:00

bdb.cpp

wallet: bdb batch 'ErasePrefix', do not create txn internally

2024-02-12 16:05:15 -03:00

bdb.h

…

coincontrol.cpp

…

coincontrol.h

…

coinselection.cpp

opt: Skip over barren combinations of tiny UTXOs

2024-02-09 11:03:18 +01:00

coinselection.h

coinselection: Track whether CG completed

2024-02-09 10:50:10 +01:00

context.cpp

…

context.h

…

crypter.cpp

…

crypter.h

…

db.cpp

…

db.h

wallet: remove unused 'accept_no_keys' arg from decryption process

2024-02-03 12:56:43 -03:00

dump.cpp

…

dump.h

…

external_signer_scriptpubkeyman.cpp

wallet: return and display signer error

2024-04-16 17:47:43 +02:00

external_signer_scriptpubkeyman.h

wallet: return and display signer error

2024-04-16 17:47:43 +02:00

feebumper.cpp

…

feebumper.h

…

fees.cpp

…

fees.h

…

init.cpp

scripted-diff: Fix bitcoin_config_h includes

2024-02-13 20:10:44 +00:00

interfaces.cpp

Merge bitcoin/bitcoin#24313: Improve display address handling for external signer

2024-04-23 17:20:54 -04:00

load.cpp

…

load.h

…

receive.cpp

[clang-tidy] Enable the misc-no-recursion check

2024-04-07 14:04:45 +01:00

receive.h

…

salvage.cpp

…

salvage.h

…

scriptpubkeyman.cpp

[clang-tidy] Enable the misc-no-recursion check

2024-04-07 14:04:45 +01:00

scriptpubkeyman.h

wallet: return and display signer error

2024-04-16 17:47:43 +02:00

spend.cpp

Merge bitcoin/bitcoin#27877: wallet: Add CoinGrinder coin selection algorithm

2024-02-09 16:38:13 -05:00

spend.h

…

sqlite.cpp

Merge bitcoin/bitcoin#29404: refactor: bitcoin-config.h includes cleanup

2024-02-20 13:07:48 +00:00

sqlite.h

sqlite: Ensure that only one SQLiteBatch is writing to db at a time

2024-02-06 12:24:36 -05:00

transaction.cpp

scripted-diff: wallet: s/TxStateConflicted/TxStateBlockConflicted

2024-03-14 17:38:39 -04:00

transaction.h

wallet: track mempool conflicts

2024-03-20 15:05:34 -04:00

types.h

…

wallet.cpp

wallet: return and display signer error

2024-04-16 17:47:43 +02:00

wallet.h

wallet: return and display signer error

2024-04-16 17:47:43 +02:00

walletdb.cpp

Merge bitcoin/bitcoin#29404: refactor: bitcoin-config.h includes cleanup

2024-02-20 13:07:48 +00:00

walletdb.h

wallet: db, introduce 'RunWithinTxn()' helper function

2024-02-12 16:05:14 -03:00

wallettool.cpp

…

wallettool.h

…

walletutil.cpp

wallet, descspkm: Refactor wallet descriptor generation to standalone func

2024-03-20 16:15:43 -04:00

walletutil.h

wallet, descspkm: Refactor wallet descriptor generation to standalone func

2024-03-20 16:15:43 -04:00