MarcoFalke
dce6f3b29b
Merge #18383 : refactor: Check for overflow when calculating sum of tx outputs ...
f65c9ad40f2f5cdc581bdaf72e7dc68e9d7f7a80 Check for overflow when calculating sum of outputs (Elichai Turkel)
Pull request description:
This was reported by practicalswift here #18046
The exact order of the if, is important, we first do `!MoneyRange(tx_out.nValue)` to make sure the amount is non-negative. and then `std::numeric_limits<CAmount>::max() - tx_out.nValue < nValueOut` checks that the addition cannot overflow (if we won't check that the amount is positive this check can also overflow! (by doing something like `max - -max`))
and only then we make sure that the some is also valid `!MoneyRange(nValueOut + tx_out.nValue)`
if any of these conditions fail we throw.
the overflowing logic:
```
a + b > max // we want to fail if a+b is more than the maximum -> will overflow
b > max - a
max - a < b
```
Closes : #18046
ACKs for top commit:
MarcoFalke:
ACK f65c9ad40f2f5cdc581bdaf72e7dc68e9d7f7a80, checked that clang with O2 produces identical binaries 💕
practicalswift:
ACK f65c9ad40f2f5cdc581bdaf72e7dc68e9d7f7a80
instagibbs:
utACK f65c9ad40f
2020-04-03 06:50:29 +08:00
2020-03-27 15:17:35 +00:00
2019-12-30 10:42:20 +13:00
2020-03-18 10:34:53 -07:00
2020-01-28 17:00:01 +01:00
2020-01-16 15:58:35 -05:00
2020-03-19 17:26:51 +01:00
2020-03-31 15:07:06 +02:00
2020-01-28 16:59:07 +01:00
2020-03-02 23:07:21 -08:00
2020-03-02 23:07:21 -08:00
2020-01-15 02:18:00 +07:00
2020-03-23 16:36:24 +02:00
2020-04-02 15:07:55 +02:00
2020-03-28 15:13:13 -04:00
2020-03-27 14:49:50 +08:00
2019-03-31 11:41:05 -07:00
2020-03-26 16:56:03 +01:00
2020-03-31 17:11:47 -04:00
2020-02-09 07:44:29 -08:00
2020-04-02 12:31:54 +08:00
2020-03-31 14:23:43 +01:00
2020-03-19 17:26:51 +01:00
2019-10-14 13:24:54 +03:00
2019-12-30 10:42:20 +13:00
2020-01-02 11:05:36 -08:00
2020-03-04 14:24:19 +01:00
2020-03-04 14:24:19 +01:00
2019-12-30 10:42:20 +13:00
2019-12-30 10:42:20 +13:00
2019-12-30 10:42:20 +13:00
2020-03-10 09:52:53 -04:00
2019-12-30 10:42:20 +13:00
2019-12-30 10:42:20 +13:00
2019-10-16 08:56:57 -07:00
2019-09-05 13:25:11 +12:00
2020-02-21 10:06:21 -08:00
2020-03-14 12:23:01 -07:00
2020-01-14 18:19:00 +00:00
2020-02-21 10:06:21 -08:00
2019-12-30 10:42:20 +13:00
2020-02-25 14:10:44 -08:00
2019-12-30 10:42:20 +13:00
2019-12-30 10:42:20 +13:00
2019-12-30 10:42:20 +13:00
2019-12-30 10:42:20 +13:00
2019-12-30 10:42:20 +13:00
2020-02-10 12:00:10 -08:00
2020-04-02 05:34:47 +08:00
2020-02-13 08:59:51 -08:00
2019-12-30 10:42:20 +13:00
2019-12-30 10:42:20 +13:00
2019-10-02 08:51:12 +02:00
2020-01-21 14:07:42 +00:00
2019-12-30 10:42:20 +13:00
2020-03-28 08:38:07 +09:00
2019-12-30 10:42:20 +13:00
2020-03-05 15:25:36 -05:00
2019-12-30 10:42:20 +13:00
2020-03-27 15:51:05 +09:00
2019-12-30 10:42:20 +13:00
2019-11-29 21:23:25 +02:00
2019-12-30 10:42:20 +13:00
2019-12-30 10:42:20 +13:00
2020-01-15 02:18:00 +07:00
2020-02-10 12:00:10 -08:00
2020-01-04 20:18:28 +02:00
2019-12-30 10:42:20 +13:00
2019-03-31 11:41:05 -07:00
2020-02-21 10:06:21 -08:00
2019-12-30 10:42:20 +13:00
2020-02-18 08:29:35 +01:00
2019-12-30 10:42:20 +13:00
2020-01-31 12:36:13 +00:00
2020-03-29 08:15:55 -04:00
2019-12-30 10:42:20 +13:00
2019-12-30 10:42:20 +13:00
2019-12-30 10:42:20 +13:00
2019-12-30 10:42:20 +13:00
2020-01-15 02:18:00 +07:00
2020-01-15 02:18:00 +07:00
2020-03-22 10:47:38 +08:00
2020-03-26 17:20:28 +08:00
2020-01-28 17:01:48 +01:00
2020-01-28 17:01:48 +01:00
2020-04-01 12:49:15 +02:00
2019-11-21 19:38:39 +01:00
2019-11-21 21:13:08 +01:00
2019-11-25 16:40:09 +01:00
2020-03-30 15:18:42 -04:00
2020-01-31 12:36:13 +00:00
2019-12-30 10:42:20 +13:00
2020-02-27 17:59:07 -08:00
2019-12-23 06:12:10 +07:00
2020-01-08 12:35:59 +00:00
2020-02-11 07:44:12 -08:00
2020-03-19 17:26:51 +01:00
2020-03-19 17:26:51 +01:00
2019-10-29 11:30:12 +02:00
2020-03-10 09:47:32 -04:00
2020-03-04 13:45:29 -05:00
2020-03-04 14:31:31 +01:00
2020-03-04 14:31:31 +01:00
2020-01-22 20:20:45 +01:00
2020-01-08 12:35:59 +00:00
2019-12-30 10:42:20 +13:00
2019-12-30 10:42:20 +13:00
2019-12-30 10:42:20 +13:00
2020-02-12 11:48:30 -05:00
2020-01-23 16:35:06 -05:00
2020-02-15 19:49:24 -08:00
2020-02-06 13:24:40 +01:00
2020-02-06 13:24:40 +01:00
2020-01-29 19:39:50 +08:00
2020-01-16 18:25:11 -08:00
2019-12-30 10:42:20 +13:00
2019-12-30 10:42:20 +13:00
2020-03-19 11:36:38 +08:00
2020-03-29 13:17:04 +00:00
2020-02-28 14:56:49 -08:00
2019-11-12 14:50:44 -08:00
2019-12-30 10:42:20 +13:00
2020-03-10 09:47:32 -04:00
2020-03-10 09:47:32 -04:00
2020-03-05 19:56:26 +01:00
2020-03-23 14:44:58 -07:00
2019-12-30 10:42:20 +13:00
2020-03-27 08:59:06 -04:00
2020-03-15 22:43:39 +00:00
2019-12-30 10:42:20 +13:00
2019-12-30 10:42:20 +13:00
2020-01-15 02:18:00 +07:00
2019-12-06 10:02:08 +01:00
2020-01-08 12:35:59 +00:00
2019-12-30 10:42:20 +13:00
2020-02-10 12:00:10 -08:00
2020-01-15 02:18:00 +07:00
2020-03-11 18:38:33 -04:00
2020-03-19 17:26:51 +01:00
2020-01-15 02:18:00 +07:00
2020-01-15 02:18:00 +07:00
2020-01-23 16:35:08 -05:00
2020-01-23 16:35:08 -05:00
2020-03-28 08:38:07 +09:00
2020-03-19 17:26:51 +01:00
2020-01-15 02:18:00 +07:00
2020-03-27 15:17:35 +00:00
2020-03-27 15:17:35 +00:00
2019-12-30 10:42:20 +13:00
2019-12-30 10:42:20 +13:00
2019-12-30 10:42:20 +13:00
2019-12-30 10:42:20 +13:00
2019-12-30 10:42:20 +13:00
2019-12-30 10:42:20 +13:00
dce6f3b29b