cryptogera/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-02-01 19:21:10 +00:00
Code Issues Packages Projects Releases Wiki Activity
bitcoin/src/interfaces
History
Wladimir J. van der Laan 7173a3c73b
Merge #19396: refactor: Remove confusing OutputType::CHANGE_AUTO 
fa927ff884ae373c676deed63180a8d238872cdc Enable Wswitch for OutputType (MarcoFalke)
faddad71f648ed99734f4f8811bd4bc7232ca670 Remove confusing OutputType::CHANGE_AUTO (MarcoFalke)
fa2eb383522249a5f4d48726c520cec5de496614 interfaces: Remove unused getDefaultChangeType (MarcoFalke)

Pull request description:

  `OutputType::CHANGE_AUTO` is problematic for several reasons:

  * An output that is not change must never be described by `CHANGE_AUTO`. Simply allowing that option makes the code confusing and review harder than it needs to be.
  * To make review even harder, `CHANGE_AUTO` requires `-Wswitch` to be disabled for `OutputType`

  Fix both issues by removing `CHANGE_AUTO` and then enabling `-Wswitch` for `OutputType`

ACKs for top commit:
  promag:
    Code review ACK fa927ff884ae373c676deed63180a8d238872cdc.
  laanwj:
    Code review ACK fa927ff884ae373c676deed63180a8d238872cdc

Tree-SHA512: 24fd809757aa343866c94dafe9a7130b50cda4f77c97666d407f99b813f75b115a7d8e688a6bc2a737e87cba64ddd4e43f2b3c5538fd35fabb5845807bb39134
2020-07-02 16:10:49 +02:00
..
chain.cpp
scripted-diff: Move ui_interface to the node lib
2020-06-27 11:49:28 -04:00
chain.h
Add missing includes to fix compile errors
2020-06-16 15:15:46 -04:00
handler.cpp
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
handler.h
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
node.cpp
scripted-diff: Move ui_interface to the node lib
2020-06-27 11:49:28 -04:00
node.h
Make GetWarnings() return bilingual_str
2020-06-10 15:01:20 +03:00
README.md
Suggested interfaces::Chain cleanups from #15288
2019-03-04 15:57:58 -05:00
wallet.cpp
Merge #19396: refactor: Remove confusing OutputType::CHANGE_AUTO
2020-07-02 16:10:49 +02:00
wallet.h
Merge #19396: refactor: Remove confusing OutputType::CHANGE_AUTO
2020-07-02 16:10:49 +02:00

README.md

Internal c++ interfaces

The following interfaces are defined here:

  • Chain — used by wallet to access blockchain and mempool state. Added in #14437, #14711, #15288, and #10973.

  • ChainClient — used by node to start & stop Chain clients. Added in #14437.

  • Node — used by GUI to start & stop bitcoin node. Added in #10244.

  • Wallet — used by GUI to access wallets. Added in #10244.

  • Handler — returned by handleEvent methods on interfaces above and used to manage lifetimes of event handlers.

  • Init — used by multiprocess code to access interfaces above on startup. Added in #10102.

The interfaces above define boundaries between major components of bitcoin code (node, wallet, and gui), making it possible for them to run in different processes, and be tested, developed, and understood independently. These interfaces are not currently designed to be stable or to be used externally.