cryptogera/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-02-02 03:31:09 +00:00
Code Issues Packages Projects Releases Wiki Activity
bitcoin/src/test/util
History
Andrew Chow 5690848dfb
Merge bitcoin/bitcoin#26532: wallet: bugfix, invalid crypted key "checksum_valid" set 
13d97608297bd56ed033d0e754d2e50447b02af0 test: load wallet, coverage for crypted keys (furszy)
373c99633ec7f20557db2734c49116ee4ad15423 refactor: move DuplicateMockDatabase to wallet/test/util.h (furszy)
ee7a984f85015b610be4929b7c35cb501c1fbf7c refactor: unify test/util/wallet.h with wallet/test/util.h (furszy)
cc5a5e81217506ec6f9fff34056290f8f40a7396 wallet: bugfix, invalid crypted key "checksum_valid" set (furszy)

Pull request description:

  At wallet load time, the crypted key "checksum_valid" variable is always set to false. Which, on every wallet decryption call, forces the process to re-write all the ckeys to db when it's not needed.

  Note:
  The first commit fixes the issue, the two commits in the middle are cleanups so `DuplicateMockDatabase`
  can be used without duplicating code. And, the last one is pure test coverage for the crypted keys loading
  process.

  Includes test coverage for the following scenarios:

  1) "All ckeys checksums valid" test:
  Loads an encrypted wallet with all the crypted keys with a valid checksum and
  verifies that 'CWallet::Unlock' doesn't force an entire crypted keys re-write.

      (we force a complete ckeys re-write if we find any missing crypted key checksum
  during the wallet loading process)

  2) "Missing checksum in one ckey" test:
  Verifies that loading up a wallet with, at least one, 'ckey' with no checksum
  triggers a complete re-write of the crypted keys.

  3) "Invalid ckey checksum error" test:
  Verifies that loading up a ckey with an invalid checksum stops the wallet loading
  process with a corruption error.

  4) "Invalid ckey pubkey error" test:
  Verifies that loading up a ckey with an invalid pubkey stops the wallet loading
  process with a corruption error.

ACKs for top commit:
  achow101:
    ACK 13d97608297bd56ed033d0e754d2e50447b02af0
  aureleoules:
    ACK 13d97608297bd56ed033d0e754d2e50447b02af0

Tree-SHA512: 9ea630ee4a355282fbeee61ca04737294382577bb4b2631f50e732568fdab8f72491930807fbda58206446c4f26200cdc34d8afa14dbe1241aec713887d06a0b
2022-11-29 18:54:57 -05:00
..
blockfilter.cpp
Require CBlockIndex::GetBlockPos() to hold mutex cs_main
2022-01-25 20:43:12 +01:00
blockfilter.h
…
chainstate.h
test: allow on-disk coins and block tree dbs in tests
2022-09-13 13:31:23 -04:00
logging.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
logging.h
util, refactor: Add UNIQUE_NAME helper macro
2022-02-16 14:59:20 +02:00
mining.cpp
Require callers of AcceptBlockHeader() to perform anti-dos checks
2022-08-29 08:10:35 -04:00
mining.h
Add src/node/* code to node:: namespace
2022-01-06 22:14:16 -05:00
net.cpp
net: drop cs_sendProcessing
2022-09-15 14:44:42 +10:00
net.h
Merge bitcoin/bitcoin#25421: net: convert standalone IsSelectableSocket() and SetSocketNonBlocking() to Sock methods
2022-10-12 15:49:02 -04:00
README.md
…
script.cpp
fuzz: [refactor] Use IsValidFlagCombination in signature_checker fuzz target
2021-03-30 10:42:45 +02:00
script.h
fuzz: [refactor] Use IsValidFlagCombination in signature_checker fuzz target
2021-03-30 10:42:45 +02:00
setup_common.cpp
Merge bitcoin/bitcoin#17786: refactor: Nuke policy/fees->mempool circular dependencies
2022-11-18 17:04:49 -08:00
setup_common.h
test: Remove unused txmempool include from tests
2022-10-18 14:02:09 +02:00
str.cpp
…
str.h
…
transaction_utils.cpp
…
transaction_utils.h
…
txmempool.cpp
test: Use type-safe NodeSeconds for TestMemPoolEntryHelper
2022-10-24 11:33:33 +02:00
txmempool.h
test: Use type-safe NodeSeconds for TestMemPoolEntryHelper
2022-10-24 11:33:33 +02:00
validation.cpp
Add coinstatsindex_unclean_shutdown test
2022-02-25 16:06:27 -05:00
validation.h
scripted-diff: rename CChainState -> Chainstate
2022-09-09 11:47:27 -04:00

README.md

Test library

This contains files for the test library, which is used by the test binaries (unit tests, benchmarks, fuzzers, gui tests).

Generally, the files in this folder should be well-separated modules. New code should be added to existing modules or (when in doubt) a new module should be created.

The utilities in here are compiled into a library, which does not hold any state. However, the main file setup_common defines the common test setup for all test binaries. The test binaries will handle the global state when they instantiate the BasicTestingSetup (or one of its derived classes).