Samuel Dobson 200d97faf2

Merge bitcoin/bitcoin#22868: wallet: Call load handlers without cs_wallet locked ...

f13a22a631efe01e1fbae4ae78a4901d14ebda3c wallet: Call load handlers without cs_wallet locked (João Barbosa)

Pull request description:

  Don't have `cs_wallet` locked while calling each `context.wallet_load_fns`. A load handler can always lock `cs_wallet` if needed.

  The lock was added in 1c7e25db0c to satisfy TSAN. With 44c430ffac most of the code requiring the lock is in `CWallet::AttachChain`. A comment is added to warn about wallets_mutex and cs_wallet lock ordering.

ACKs for top commit:
  meshcollider:
    re-utACK f13a22a631efe01e1fbae4ae78a4901d14ebda3c
  ryanofsky:
    Code review ACK f13a22a631efe01e1fbae4ae78a4901d14ebda3c. Only change since last review is adding a lock order comment
  jonatack:
    ACK f13a22a631efe01e1fbae4ae78a4901d14ebda3c

Tree-SHA512: d51976c3aae4bebc2d1997c88edff712d21fc5523801f5614062a10f826e164579973aeb1981bb1cbc243ecff6af3250362f544c02a79e5d135cbbca1704be62

2021-11-27 22:30:46 +13:00

..

test

Merge bitcoin/bitcoin#22868: wallet: Call load handlers without cs_wallet locked

2021-11-27 22:30:46 +13:00

bdb.cpp

wallet: Use PACKAGE_NAME to mention our software

2021-10-20 21:09:14 +03:00

bdb.h

wallet: Fixed Grammatical error in bdb.h

2021-11-09 12:41:37 +01:00

coincontrol.cpp

…

coincontrol.h

External input fund support cleanups

2021-10-06 06:55:34 +08:00

coinselection.cpp

Merge bitcoin/bitcoin#22951: consensus: move amount.h into consensus

2021-10-05 09:43:23 +02:00

coinselection.h

Merge bitcoin/bitcoin#22951: consensus: move amount.h into consensus

2021-10-05 09:43:23 +02:00

context.cpp

…

context.h

wallet: Call load handlers without cs_wallet locked

2021-11-22 09:42:36 +00:00

crypter.cpp

…

crypter.h

…

db.cpp

refactor: get wallet path relative to wallet_dir

2021-10-29 09:36:32 -05:00

db.h

…

dump.cpp

Remove gArgs from wallet.h and wallet.cpp

2021-11-09 11:27:06 +01:00

dump.h

…

external_signer_scriptpubkeyman.cpp

Merge bitcoin/bitcoin#21365: Basic Taproot signing support for descriptor wallets

2021-06-18 09:12:44 +12:00

external_signer_scriptpubkeyman.h

refactor: remove m_internal from DescriptorSPKman

2021-06-30 08:37:50 +02:00

feebumper.cpp

refactor: Detach wallet transaction methods (followup for move-only)

2021-09-01 02:22:58 -05:00

feebumper.h

…

fees.cpp

…

fees.h

[MOVEONLY] consensus: move amount.h into consensus

2021-09-30 07:41:57 +08:00

init.cpp

Mention bech32m in -addresstype and -changetype help

2021-11-16 12:20:13 -05:00

interfaces.cpp

refactor: Make CWalletTx sync state type-safe

2021-11-15 09:11:44 -05:00

ismine.h

…

load.cpp

refactor: Block unsafe fs::path std::string conversion calls

2021-10-05 11:10:47 -04:00

load.h

refactor: remove ::vpwallets and related global variables

2021-08-17 04:05:15 -04:00

receive.cpp

[MOVEONLY] consensus: move amount.h into consensus

2021-09-30 07:41:57 +08:00

receive.h

[MOVEONLY] consensus: move amount.h into consensus

2021-09-30 07:41:57 +08:00

rpcdump.cpp

Merge bitcoin/bitcoin#21206: refactor: Make CWalletTx sync state type-safe

2021-11-25 19:41:53 +01:00

rpcwallet.cpp

Merge bitcoin/bitcoin#21206: refactor: Make CWalletTx sync state type-safe

2021-11-25 19:41:53 +01:00

rpcwallet.h

doc: Fix typos in endif header comments

2021-11-16 09:56:45 +01:00

salvage.cpp

Remove gArgs from wallet.h and wallet.cpp

2021-11-09 11:27:06 +01:00

salvage.h

…

scriptpubkeyman.cpp

Merge bitcoin/bitcoin#22364: wallet: Make a tr() descriptor by default

2021-11-22 10:01:17 +01:00

scriptpubkeyman.h

wallet, refactor: Make GetOldestKeyPoolTime return type std::optional

2021-11-03 10:35:47 +02:00

spend.cpp

External input fund support cleanups

2021-10-06 06:55:34 +08:00

spend.h

Merge bitcoin/bitcoin#22951: consensus: move amount.h into consensus

2021-10-05 09:43:23 +02:00

sqlite.cpp

wallet: Use PACKAGE_NAME to mention our software

2021-10-20 21:09:14 +03:00

sqlite.h

…

transaction.cpp

refactor: Make CWalletTx sync state type-safe

2021-11-15 09:11:44 -05:00

transaction.h

refactor: Make CWalletTx sync state type-safe

2021-11-15 09:11:44 -05:00

wallet.cpp

Merge bitcoin/bitcoin#22868: wallet: Call load handlers without cs_wallet locked

2021-11-27 22:30:46 +13:00

wallet.h

Merge bitcoin/bitcoin#21206: refactor: Make CWalletTx sync state type-safe

2021-11-25 19:41:53 +01:00

walletdb.cpp

refactor: Make CWalletTx sync state type-safe

2021-11-15 09:11:44 -05:00

walletdb.h

Merge bitcoin/bitcoin#22951: consensus: move amount.h into consensus

2021-10-05 09:43:23 +02:00

wallettool.cpp

Merge bitcoin/bitcoin#23349: util: Use FEATURE_LATEST for wallets created with bitcoin-wallet

2021-11-16 15:32:18 +13:00

wallettool.h

…

walletutil.cpp

refactor: Block unsafe fs::path std::string conversion calls

2021-10-05 11:10:47 -04:00

walletutil.h

wallet: Upgrade existing descriptor caches

2021-06-24 13:49:22 -04:00