cryptogera/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-02-01 19:21:10 +00:00
Code Issues Packages Projects Releases Wiki Activity
bitcoin/src/interfaces
History
Andrew Chow 8d4a058ac4
Merge bitcoin/bitcoin#23997: wallet: avoid rescans under assumed-valid blocks 
817326a828d6148dc63d9ef08f641b9c0c522411 wallet: avoid rescans if under the snapshot (James O'Beirne)

Pull request description:

  This is part of the [assumeutxo project](https://github.com/bitcoin/bitcoin/projects/11) (parent PR: #15606)

  ---

  Refuse to load a wallet if it requires a rescan lower than the height of assumed-valid blocks.

  Of course in live code right now, `BLOCK_ASSUMED_VALID` block index entries don't exist since they're a unique flag introduced by the use of UTXO snapshots, so this is prophylactic code exercised only by unittests.

ACKs for top commit:
  achow101:
    ACK 817326a828d6148dc63d9ef08f641b9c0c522411
  ryanofsky:
    Code review ACK 817326a828d6148dc63d9ef08f641b9c0c522411. This seems like the simplest change we can make to avoid wallet problems when an assumeutxo snapshot is loaded.

Tree-SHA512: cfa44b2eb33d1818d30df45210d0dde1e9b78cc9b7c88cb985054dc28427bba9e0905debe4196065d1d3a5ce7bca7e605e629d5ce5f0225b25395746e6d3d596
2022-07-18 14:39:55 -04:00
..
chain.h
Merge bitcoin/bitcoin#23997: wallet: avoid rescans under assumed-valid blocks
2022-07-18 14:39:55 -04:00
echo.cpp
multiprocess: Add echoipc RPC method and test
2021-04-23 03:02:50 -05:00
echo.h
multiprocess: Add echoipc RPC method and test
2021-04-23 03:02:50 -05:00
handler.cpp
scripted-diff: Bump copyright headers
2021-12-30 19:36:57 +02:00
handler.h
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
init.cpp
scripted-diff: Rename interfaces::WalletClient to interfaces::WalletLoader
2021-12-22 13:44:55 -05:00
init.h
Add src/node/* code to node:: namespace
2022-01-06 22:14:16 -05:00
ipc.h
Add ipc::Context and ipc::capnp::Context structs
2021-06-10 09:58:45 -05:00
node.h
settings: Add resetSettings() method
2022-05-19 11:32:56 -04:00
README.md
multiprocess: Add comments and documentation
2021-04-23 03:02:50 -05:00
wallet.h
refactor: Return BResult from restoreWallet
2022-07-12 19:20:01 +02:00

README.md

Internal c++ interfaces

The following interfaces are defined here:

  • Chain — used by wallet to access blockchain and mempool state. Added in #14437, #14711, #15288, and #10973.

  • ChainClient — used by node to start & stop Chain clients. Added in #14437.

  • Node — used by GUI to start & stop bitcoin node. Added in #10244.

  • Wallet — used by GUI to access wallets. Added in #10244.

  • Handler — returned by handleEvent methods on interfaces above and used to manage lifetimes of event handlers.

  • Init — used by multiprocess code to access interfaces above on startup. Added in #19160.

  • Ipc — used by multiprocess code to access Init interface across processes. Added in #19160.

The interfaces above define boundaries between major components of bitcoin code (node, wallet, and gui), making it possible for them to run in different processes, and be tested, developed, and understood independently. These interfaces are not currently designed to be stable or to be used externally.