cryptogera/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-02-01 19:21:10 +00:00
Code Issues Packages Projects Releases Wiki Activity
bitcoin/src
History
Hennadii Stepanov 1172bc4157
Merge bitcoin-core/gui#850: psbt: Use SIGHASH_DEFAULT when signing PSBTs 
3e97ff9c5eaa3160426ba112930b047404c54c9e gui, psbt: Use SIGHASH_DEFAULT when signing PSBTs (Ava Chow)

Pull request description:

  SIGHASH_DEFAULT should be used to indicate SIGHASH_DEFAULT for taproot inputs, and SIGHASH_ALL for all other input types. This avoids adding an unnecessary byte to the end of all Taproot signatures added to PSBTs signed in the GUI.

  See also bitcoin/bitcoin#22514

ACKs for top commit:
  Sjors:
    utACK 3e97ff9c5eaa3160426ba112930b047404c54c9e
  pablomartin4btc:
    utACK 3e97ff9c5eaa3160426ba112930b047404c54c9e
  hebasto:
    ACK 3e97ff9c5eaa3160426ba112930b047404c54c9e, I have reviewed the code and it looks OK.

Tree-SHA512: f96f26b3a6959865cf23039afb5ffb7e454fb52ee39c510583851caf00a8a383cde69bc7e90db536addbdd498a02f4b001cbaf509d6d53c5f8601b3933786f6c
2025-02-02 09:49:19 +00:00
..
bench
Merge bitcoin/bitcoin#21590: Safegcd-based modular inverses in MuHash3072
2025-01-27 16:50:16 -05:00
common
args: Catch directories in place of config files
2024-12-03 11:04:10 +01:00
compat
netbase: refactor CreateSock() to accept sa_family_t
2024-03-01 13:13:07 -05:00
consensus
Check leaves size maximum in MerkleComputation
2024-12-17 10:12:31 +07:00
crc32c
Update crc32c subtree to latest upstream master
2024-02-27 18:28:19 +00:00
crypto
Merge bitcoin/bitcoin#21590: Safegcd-based modular inverses in MuHash3072
2025-01-27 16:50:16 -05:00
index
scripted-diff: rename block and undo functions for consistency
2025-01-09 15:17:02 +01:00
init
scripted-diff: Replace strprintf(Untranslated) with Untranslated(strprintf)
2024-12-04 15:09:05 -04:00
interfaces
interfaces: Add helper function for wallet on pruning
2025-01-05 17:28:19 +01:00
ipc
depends: Update libmultiprocess library before converting to subtree
2025-01-26 14:13:47 -05:00
kernel
kernel: Move block tree db open to block manager
2025-01-20 21:19:39 +01:00
leveldb
Update leveldb subtree to latest upstream
2025-01-16 11:09:56 +00:00
logging
scripted-diff: LogPrint -> LogDebug
2024-08-29 13:49:57 +02:00
minisketch
Update minisketch subtree to latest master
2024-06-12 14:38:39 +01:00
node
Merge bitcoin/bitcoin#30909: wallet, assumeutxo: Don't Assume m_chain_tx_count, Improve wallet RPC errors
2025-01-31 15:45:14 -05:00
policy
Merge bitcoin/bitcoin#31596: doc: Clarify comments about endianness after #30526
2025-01-06 18:52:59 -05:00
primitives
tidy: modernize-use-equals-default
2024-07-08 11:12:01 +02:00
qt
Merge bitcoin-core/gui#850: psbt: Use SIGHASH_DEFAULT when signing PSBTs
2025-02-02 09:49:19 +00:00
rpc
rpc: have mintime account for timewarp rule
2025-01-29 09:39:32 +01:00
script
miniscript: Make NodeRef a unique_ptr
2025-01-21 13:17:20 -05:00
secp256k1
Update secp256k1 subtree to v0.6.0
2024-11-04 14:59:46 -05:00
support
util: Add missing types in make_secure_unique
2024-12-10 21:51:48 +01:00
test
Merge bitcoin/bitcoin#30965: kernel: Move block tree db open to block manager
2025-01-31 15:28:06 -05:00
univalue
test: clang-format -i src/univalue/test/unitester.cpp
2024-12-20 15:01:44 +01:00
util
util: fix compiler warning about deprecated space before _MiB
2025-01-20 14:32:20 +01:00
wallet
Merge bitcoin/bitcoin#30909: wallet, assumeutxo: Don't Assume m_chain_tx_count, Improve wallet RPC errors
2025-01-31 15:45:14 -05:00
zmq
cmake: Add FindZeroMQ module
2024-10-25 18:09:36 +01:00
.clang-format
…
.clang-tidy
tidy: add clang-tidy modernize-use-starts-ends-with check
2024-09-14 20:33:32 +03:00
addrdb.cpp
scripted-diff: Rename PACKAGE_* variables to CLIENT_*
2024-10-28 12:36:19 +00:00
addrdb.h
Use serialization parameters for CAddress serialization
2023-09-05 10:13:25 +02:00
addresstype.cpp
policy: Add OP_1 <0x4e73> as a standard output type
2024-07-30 14:06:58 -04:00
addresstype.h
policy: Add OP_1 <0x4e73> as a standard output type
2024-07-30 14:06:58 -04:00
addrman_impl.h
Merge bitcoin/bitcoin#30568: addrman: change internal id counting to int64_t
2024-09-20 12:55:22 -04:00
addrman.cpp
addrman: cap the max_pct to not exceed the maximum number of addresses
2024-11-11 12:47:53 -03:00
addrman.h
addrman: cap the max_pct to not exceed the maximum number of addresses
2024-11-11 12:47:53 -03:00
arith_uint256.cpp
Add a fuzz test for Num3072 multiplication and inversion
2025-01-09 10:11:46 -05:00
arith_uint256.h
doc: Clarify comments about endianness after #30526
2025-01-03 09:19:53 -05:00
attributes.h
…
banman.cpp
refactor: Delay translation of _() literals
2025-01-14 19:21:37 +01:00
banman.h
net_processing: remove Misbehavior score and increments
2024-05-30 08:35:18 -04:00
base58.cpp
refactor: Avoid needless, unsafe c-style cast
2024-12-19 13:46:31 +01:00
base58.h
…
bech32.cpp
fuzz: replace hardcoded numbers for bech32 limits
2024-08-06 11:03:31 +02:00
bech32.h
fuzz: replace hardcoded numbers for bech32 limits
2024-08-06 11:03:31 +02:00
bip324.cpp
…
bip324.h
…
bitcoin-chainstate.cpp
kernel: Move block tree db open to block manager
2025-01-20 21:19:39 +01:00
bitcoin-cli-res.rc
scripted-diff: Rename PACKAGE_* variables to CLIENT_*
2024-10-28 12:36:19 +00:00
bitcoin-cli.cpp
refactor: Use TranslateFn type consistently
2025-01-15 12:15:40 +01:00
bitcoin-tx-res.rc
scripted-diff: Rename PACKAGE_* variables to CLIENT_*
2024-10-28 12:36:19 +00:00
bitcoin-tx.cpp
refactor: Use TranslateFn type consistently
2025-01-15 12:15:40 +01:00
bitcoin-util-res.rc
scripted-diff: Rename PACKAGE_* variables to CLIENT_*
2024-10-28 12:36:19 +00:00
bitcoin-util.cpp
refactor: Use TranslateFn type consistently
2025-01-15 12:15:40 +01:00
bitcoin-wallet-res.rc
scripted-diff: Rename PACKAGE_* variables to CLIENT_*
2024-10-28 12:36:19 +00:00
bitcoin-wallet.cpp
refactor: Use TranslateFn type consistently
2025-01-15 12:15:40 +01:00
bitcoind-res.rc
scripted-diff: Rename PACKAGE_* variables to CLIENT_*
2024-10-28 12:36:19 +00:00
bitcoind.cpp
refactor: introduce a more general LockDirectories for init
2025-01-16 21:06:21 +00:00
blockencodings.cpp
scripted-diff: LogPrint -> LogDebug
2024-08-29 13:49:57 +02:00
blockencodings.h
tidy: modernize-use-equals-default
2024-07-08 11:12:01 +02:00
blockfilter.cpp
util: Move util/string.h functions to util namespace
2024-05-16 10:16:08 -05:00
blockfilter.h
…
chain.cpp
…
chain.h
doc: update NeedsRedownload() comment
2024-09-17 09:54:18 +02:00
chainparams.cpp
test: Don't enforce BIP94 on regtest unless specified by arg
2024-10-28 11:38:38 -04:00
chainparams.h
…
chainparamsbase.cpp
net, init: derive default onion port if a user specified a -port
2024-11-14 13:41:02 -05:00
chainparamsbase.h
net, init: derive default onion port if a user specified a -port
2024-11-14 13:41:02 -05:00
chainparamsseeds.h
seeds: Regenerate mainnet seeds
2024-08-27 07:00:27 +02:00
checkqueue.h
Merge bitcoin/bitcoin#31313: refactor: Clamp worker threads in ChainstateManager constructor
2024-12-03 18:02:37 -05:00
clientversion.cpp
refactor: Delay translation of _() literals
2025-01-14 19:21:37 +01:00
clientversion.h
scripted-diff: Clarify "user agent" variable name
2024-10-28 12:35:49 +00:00
cluster_linearize.h
doc: correct typos
2024-11-11 14:14:39 +00:00
CMakeLists.txt
build: move pow and chain to bitcoin_common
2025-01-22 11:29:05 +01:00
coins.cpp
Merge bitcoin/bitcoin#30906: refactor: prohibit direct flags access in CCoinsCacheEntry and remove invalid tests
2024-12-04 14:09:05 -05:00
coins.h
coins, refactor: Remove direct GetFlags access
2024-12-02 13:52:34 +01:00
compressor.cpp
…
compressor.h
refactor: Rename CTransaction::nVersion to version
2024-06-07 13:55:23 -04:00
core_io.h
rpc: add getdescriptoractivity
2024-11-26 20:47:08 -05:00
core_memusage.h
…
core_read.cpp
ci: Update Clang in "tidy" job
2024-12-05 14:37:47 +00:00
core_write.cpp
refactor: Rename CTransaction::nVersion to version
2024-06-07 13:55:23 -04:00
cuckoocache.h
validation: Don't error if maxsigcachesize exceeds uint32::max
2024-07-04 22:35:29 +02:00
dbwrapper.cpp
dbwrapper: Bump max file size to 32 MiB
2024-11-30 20:19:08 +01:00
dbwrapper.h
dbwrapper: Bump max file size to 32 MiB
2024-11-30 20:19:08 +01:00
deploymentinfo.cpp
…
deploymentinfo.h
…
deploymentstatus.cpp
…
deploymentstatus.h
…
dummywallet.cpp
wallet, test: Be able to always swap BDB endianness
2024-05-16 15:03:13 -04:00
external_signer.cpp
refactor: Remove Span operator==, Use std::ranges::equal
2024-08-13 07:44:31 +02:00
external_signer.h
…
flatfile.cpp
scripted-diff: LogPrint -> LogDebug
2024-08-29 13:49:57 +02:00
flatfile.h
refactor: Add FlatFileSeq member variables in BlockManager
2024-07-24 09:39:35 +02:00
hash.cpp
…
hash.h
Squashed 'src/secp256k1/' changes from 2f2ccc46954..0cdc758a563
2024-11-04 14:59:46 -05:00
headerssync.cpp
scripted-diff: LogPrint -> LogDebug
2024-08-29 13:49:57 +02:00
headerssync.h
tidy: modernize-use-equals-default
2024-07-08 11:12:01 +02:00
httprpc.cpp
args: Support -norpccookiefile for bitcoind and bitcoin-cli
2024-12-03 10:38:21 +01:00
httprpc.h
…
httpserver.cpp
scripted-diff: Replace strprintf(Untranslated) with Untranslated(strprintf)
2024-12-04 15:09:05 -04:00
httpserver.h
rpc: increase the defaults for -rpcthreads and -rpcworkqueue
2024-11-04 17:08:21 +01:00
i2p.cpp
Merge bitcoin/bitcoin#29833: i2p: fix and improve logs
2024-06-26 15:28:26 -04:00
i2p.h
i2p: log errors properly according to their severity
2024-06-12 16:19:50 -03:00
indirectmap.h
…
init.cpp
Merge bitcoin/bitcoin#30965: kernel: Move block tree db open to block manager
2025-01-31 15:28:06 -05:00
init.h
refactor: introduce a more general LockDirectories for init
2025-01-16 21:06:21 +00:00
key_io.cpp
key: clear out secret data in DecodeExtKey
2024-10-27 15:38:54 +01:00
key_io.h
…
key.cpp
refactor: remove un-tested early returns
2024-08-04 08:52:22 +02:00
key.h
refactor: move SignSchnorr to KeyPair
2024-08-04 08:51:36 +02:00
logging.cpp
log: Enforce trailing newline, Remove redundant m_started_new_line
2024-10-01 11:31:39 +02:00
logging.h
log: Enforce trailing newline, Remove redundant m_started_new_line
2024-10-01 11:31:39 +02:00
mapport.cpp
mapport: remove dead code in DispatchMapPort
2024-10-25 15:02:07 -04:00
mapport.h
interfaces: remove now unused 'use_upnp' arg from 'mapPort'
2024-10-24 18:23:30 +02:00
memusage.h
memusage: Add DynamicUsage for std::string
2024-11-04 18:46:40 +01:00
merkleblock.cpp
[clang-tidy] Enable the misc-no-recursion check
2024-04-07 14:04:45 +01:00
merkleblock.h
tidy: modernize-use-equals-default
2024-07-08 11:12:01 +02:00
net_permissions.cpp
util: move fees.h and error.h to common/messages.h
2024-05-16 10:16:08 -05:00
net_permissions.h
Accept "in" and "out" flags to -whitelist to allow whitelisting manual connections
2024-02-28 10:05:56 -03:00
net_processing.cpp
Merge bitcoin/bitcoin#31633: net: Disconnect message follow-ups to #28521
2025-01-29 15:26:53 -05:00
net_processing.h
net: add GetOrphanTransactions() to PeerManager
2024-10-01 21:55:18 -04:00
net_types.cpp
rpc: avoid copying into UniValue
2024-05-20 16:48:19 +00:00
net_types.h
tidy: modernize-use-equals-default
2024-07-08 11:12:01 +02:00
net.cpp
Merge bitcoin/bitcoin#31633: net: Disconnect message follow-ups to #28521
2025-01-29 15:26:53 -05:00
net.h
net: add LogIP() helper, use in net_processing
2024-11-26 13:22:55 +01:00
netaddress.cpp
refactor: Remove Span operator==, Use std::ranges::equal
2024-08-13 07:44:31 +02:00
netaddress.h
random: get rid of GetRand by inlining
2024-07-01 12:39:53 -04:00
netbase.cpp
scripted-diff: drop config/ subdir for bitcoin-config.h, rename to bitcoin-build-config.h
2024-10-10 12:22:12 +02:00
netbase.h
net: add All() in ReachableNets
2024-09-10 11:20:40 -03:00
netgroup.cpp
…
netgroup.h
…
netmessagemaker.h
…
noui.cpp
node: Use log levels in noui_ThreadSafeMessageBox
2024-03-21 16:41:16 +01:00
noui.h
…
outputtype.cpp
fix incorrect multisig redeem script size limit for segwit
2024-05-03 14:20:44 -03:00
outputtype.h
fix incorrect multisig redeem script size limit for segwit
2024-05-03 14:20:44 -03:00
pow.cpp
consensus: add DeriveTarget() to pow.h
2025-01-22 11:29:05 +01:00
pow.h
consensus: add DeriveTarget() to pow.h
2025-01-22 11:29:05 +01:00
prevector.h
prevector: avoid GCC bogus warnings in insert method
2024-09-11 17:41:26 +02:00
protocol.cpp
scripted-diff: get rid of remaining "command" terminology in protocol.{h,cpp}
2024-10-26 23:44:15 +02:00
protocol.h
scripted-diff: get rid of remaining "command" terminology in protocol.{h,cpp}
2024-10-26 23:44:15 +02:00
psbt.cpp
util: add TransactionError includes and namespace declarations
2024-05-16 10:16:08 -05:00
psbt.h
Merge bitcoin/bitcoin#30406: refactor: modernize-use-equals-default
2024-07-11 19:08:46 +01:00
pubkey.cpp
refactor: Use immediate lambda to work around GCC bug 117966
2024-12-16 10:39:28 +01:00
pubkey.h
refactor: Make XOnlyPubKey tolerate constexpr std::arrays
2024-08-28 19:09:51 +02:00
random.cpp
fuzz: Abort when using global PRNG without re-seed
2024-12-16 15:23:56 +01:00
random.h
refactor: Drop unused UCharCast
2025-01-14 19:01:53 +01:00
randomenv.cpp
util: Remove RandAddSeedPerfmon
2024-10-21 23:24:17 +02:00
randomenv.h
…
rest.cpp
Merge bitcoin/bitcoin#31583: rpc: add target to getmininginfo field and show next block info
2025-01-22 15:01:23 -05:00
rest.h
…
scheduler.cpp
scripted-diff: Rename SingleThreadedSchedulerClient to SerialTaskRunner
2024-02-15 14:43:14 +01:00
scheduler.h
kernel: Remove dependency on CScheduler
2024-02-16 17:12:52 +01:00
serialize.h
Allow std::span in stream serialization
2024-12-19 14:41:21 +01:00
signet.cpp
scripted-diff: LogPrint -> LogDebug
2024-08-29 13:49:57 +02:00
signet.h
…
span.h
refactor: Simplify SpanPopBack
2024-12-19 13:46:52 +01:00
streams.cpp
streams: add DataStream::GetMemoryUsage
2024-11-04 18:46:40 +01:00
streams.h
refactor: Avoid passing span iterators when data pointers are expected
2024-12-19 14:39:55 +01:00
sync.cpp
util: avoid using thread_local variable that has a destructor
2024-05-16 18:16:46 +02:00
sync.h
tidy: modernize-use-equals-default
2024-07-08 11:12:01 +02:00
threadsafety.h
tidy: modernize-use-equals-default
2024-07-08 11:12:01 +02:00
tinyformat.h
refactor: Introduce struct to hold a runtime format string
2025-01-15 12:16:08 +01:00
torcontrol.cpp
Merge bitcoin/bitcoin#31223: net, init: derive default onion port if a user specified a -port
2024-12-13 18:56:37 -05:00
torcontrol.h
net, init: derive default onion port if a user specified a -port
2024-11-14 13:41:02 -05:00
txdb.cpp
refactor: Rely on returned value of GetCoin instead of parameter
2024-09-18 20:03:47 +02:00
txdb.h
kernel: Move default cache constants to caches
2025-01-15 15:44:55 +01:00
txmempool.cpp
txmempool: fix typos in comments
2024-12-31 00:04:20 -03:00
txmempool.h
txmempool: fix typos in comments
2024-12-31 00:04:20 -03:00
txorphanage.cpp
doc: fix typos
2025-01-16 17:36:16 +02:00
txorphanage.h
[p2p] only attempt 1p1c when both txns provided by the same peer
2025-01-06 09:02:05 -05:00
txrequest.cpp
[txrequest] GetCandidatePeers
2025-01-06 09:02:05 -05:00
txrequest.h
[txrequest] GetCandidatePeers
2025-01-06 09:02:05 -05:00
uint256.cpp
scripted-diff: Rename SetHex to SetHexDeprecated
2024-07-24 09:15:34 +02:00
uint256.h
doc: Clarify comments about endianness after #30526
2025-01-03 09:19:53 -05:00
undo.h
…
validation.cpp
Merge bitcoin/bitcoin#30909: wallet, assumeutxo: Don't Assume m_chain_tx_count, Improve wallet RPC errors
2025-01-31 15:45:14 -05:00
validation.h
Merge bitcoin/bitcoin#31483: kernel: Move kernel-related cache constants to kernel cache
2025-01-16 15:04:58 +00:00
validationinterface.cpp
refactor: include the proper header rather than forward-declaring RemovalReasonToString
2024-10-08 15:25:47 +00:00
validationinterface.h
[refactor] change ActiveTipChange to use CBlockIndex ref instead of ptr
2024-07-25 11:01:22 +01:00
versionbits.cpp
…
versionbits.h
…
walletinitinterface.h
tidy: modernize-use-equals-default
2024-07-08 11:12:01 +02:00