mirror of
https://github.com/bitcoin/bitcoin.git
synced 2026-02-05 05:01:16 +00:00
1b251f6b67
3c5d1a468199722da620f1f3d8ae3319980a46d5 Remove checkpoints (marcofleon) 632ae47372de90064f61e3e622d8da766d1d12de update comment on MinimumChainWork check (marcofleon) Pull request description: The headers presync logic (only downloading headers that lead to a chain with sufficient work, implemented in https://github.com/bitcoin/bitcoin/pull/25717) should be enough to prevent memory DoS using low-work headers. Therefore, we no longer have any use for checkpoints. All checkpoints and checkpoint logic are removed in a single commit, to make it easy to revert if necessary. Some previous discussion can be found in https://github.com/bitcoin/bitcoin/pull/25725. The conclusion at the time was that more testing of the presync logic was needed. Now that we have [unit](https://github.com/bitcoin/bitcoin/blob/master/src/test/headers_sync_chainwork_tests.cpp), [functional](https://github.com/bitcoin/bitcoin/blob/master/test/functional/p2p_headers_sync_with_minchainwork.py), and [fuzz](https://github.com/bitcoin/bitcoin/blob/master/src/test/fuzz/p2p_headers_presync.cpp) tests for this logic, it seems safe to move forward with checkpoint removal. ACKs for top commit: Sjors: Code review ACK 3c5d1a468199722da620f1f3d8ae3319980a46d5 instagibbs: reACK 3c5d1a468199722da620f1f3d8ae3319980a46d5 dergoegge: ACK 3c5d1a468199722da620f1f3d8ae3319980a46d5 Tree-SHA512: 051a6f9b82cd0262f4d3be4403906812fc6d1be022731fac16bb1c02bca471f31dfc7fc4b834ab2469e8f087265a6d99e84a1d665823cda1b112363a8e8f337d