Wladimir J. van der Laan 694f4cbd78

Merge #18312: wallet: remove deprecated fee bumping by totalFee ...

c3857c5fcb21836ddc1b79a6b19cffe562cade10 wallet: remove CreateTotalBumpTransaction() (Jon Atack)
4a0b27bb01738e6917e27b2cf47f9a8536249693 wallet: remove totalfee from createBumpTransaction() (Jon Atack)
e347cfa9a7244277f9d220a4dc3537182f18441e rpc: remove deprecated totalFee arg from RPC bumpfee (Jon Atack)
bd05f96d79df1a1561f84850d777808f8575fb8b test: delete wallet_bumpfee_totalfee_deprecation.py (Jon Atack)
a6d1ab8caa63bd343207baa60edb705209f16fb4 test: update bumpfee testing from totalFee to fee_rate (Jon Atack)

Pull request description:

  Since 0.19, fee-bumping using `totalFee` was deprecated in #15996 and replaced by `fee_rate` in #16727. This changeset removes it.

ACKs for top commit:
  laanwj:
    ACK c3857c5fcb21836ddc1b79a6b19cffe562cade10

Tree-SHA512: c1bb15d664baf4d2dea06981f36384af02057d125c51fcbc8640b9d5563532187c7b84aa952f7b575255a88ce383ed4d7495bec920a47b05b6fc0d432dce1f00

2020-03-26 18:34:49 +01:00

..

test

Move key and script filling and signing from CWallet::FillPSBT to ScriptPubKeyMan::FillPSBT

2020-03-09 11:16:20 -04:00

coincontrol.cpp

scripted-diff: Bump copyright of files changed in 2019

2019-12-30 10:42:20 +13:00

coincontrol.h

refactor: Nuke coincontrol circular dependency

2019-11-23 08:30:03 +02:00

coinselection.cpp

scripted-diff: Bump copyright of files changed in 2019

2019-12-30 10:42:20 +13:00

coinselection.h

…

crypter.cpp

Fix occurences of c_str() used with size() to data()

2019-10-28 13:41:45 +01:00

crypter.h

scripted-diff: Bump copyright of files changed in 2019

2019-12-30 10:42:20 +13:00

db.cpp

Merge #18241: wallet/refactor: refer to CWallet immutably when possible

2020-03-07 07:24:54 +08:00

db.h

wallet/db: make IsDummy() const

2020-03-02 17:26:30 +09:00

feebumper.cpp

wallet: remove CreateTotalBumpTransaction()

2020-03-26 17:54:23 +01:00

feebumper.h

wallet: remove CreateTotalBumpTransaction()

2020-03-26 17:54:23 +01:00

fees.cpp

Remove unused includes

2019-10-15 22:56:43 +00:00

fees.h

…

init.cpp

Merge #13339: wallet: Replace %w by wallet name in -walletnotify script

2020-02-17 11:59:23 +01:00

ismine.h

scripted-diff: Bump copyright of files changed in 2019

2019-12-30 10:42:20 +13:00

load.cpp

scheduler: Make schedule* methods type safe

2020-03-10 09:47:32 -04:00

load.h

wallet: Fix documentation around WalletParameterInteraction

2019-09-03 14:10:25 -04:00

rpcdump.cpp

rpc: Document an RPCResult for all calls; Enforce at compile time

2020-03-13 15:36:15 -04:00

rpcwallet.cpp

Merge #18312: wallet: remove deprecated fee bumping by totalFee

2020-03-26 18:34:49 +01:00

rpcwallet.h

Refactor: Allow LegacyScriptPubKeyMan to be null

2020-01-23 16:34:28 -05:00

scriptpubkeyman.cpp

Replace std::to_string with locale-independent alternative

2020-03-14 12:23:01 -07:00

scriptpubkeyman.h

Replace GetSigningProvider with GetSolvingProvider

2020-03-09 11:16:20 -04:00

wallet.cpp

refactor: Change Chain::broadcastTransaction param order

2020-03-19 15:26:04 -05:00

wallet.h

refactor: Rename Chain::Notifications methods to be consistent with other interfaces methods

2020-03-19 15:26:04 -05:00

walletdb.cpp

Refactor: Allow LegacyScriptPubKeyMan to be null

2020-01-23 16:34:28 -05:00

walletdb.h

Fix doxygen errors

2020-01-16 18:25:11 -08:00

wallettool.cpp

Refactor: Allow LegacyScriptPubKeyMan to be null

2020-01-23 16:34:28 -05:00

wallettool.h

scripted-diff: Bump copyright of files changed in 2019

2019-12-30 10:42:20 +13:00

walletutil.cpp

Merge #15870: wallet: Only fail rescan when blocks have actually been pruned

2019-05-16 11:18:27 -04:00

walletutil.h

scripted-diff: Bump copyright of files changed in 2019

2019-12-30 10:42:20 +13:00