mirror of
https://github.com/bitcoin/bitcoin.git
synced 2026-01-31 18:51:12 +00:00
17cf9ff7efdbab07644fc2f9017fcac1b0757c38 Use cluster size limit for -maxmempool bound, and allow -maxmempool=0 in general (Suhas Daftuar) 315e43e5d86c06b1e51b907f1942cab150205d24 Sanity check `GetFeerateDiagram()` in CTxMemPool::check() (Suhas Daftuar) de2e9a24c40e1915827506250ed0bbda4009ce83 test: extend package rbf functional test to larger clusters (Suhas Daftuar) 4ef4ddb504e53cb148e8dd713695db37df0e1e4f doc: update policy/packages.md for new package acceptance logic (Suhas Daftuar) 79f73ad713a8d62a6172fbad228cbca848f9ff57 Add check that GetSortedScoreWithTopology() agrees with CompareMiningScoreWithTopology() (Suhas Daftuar) a86ac117681727b6e72ab50ed751d0d3b0cdff34 Update comments for CTxMemPool class (Suhas Daftuar) 9567eaa66da88a79c54f7a77922d817862122af2 Invoke TxGraph::DoWork() at appropriate times (Suhas Daftuar) 6c5c44f774058bf2a0dfaaadc78347dcb5815f52 test: add functional test for new cluster mempool RPCs (Suhas Daftuar) 72f60c877e001bb8cbcd3a7fb7addfdaba149693 doc: Update mempool_replacements.md to reflect feerate diagram checks (Suhas Daftuar) 21693f031a534193cc7f066a5c6e23db3937bf39 Expose cluster information via rpc (Suhas Daftuar) 72e74e0d42284c712529bf3c619b1b740c070f1b fuzz: try to add more code coverage for mempool fuzzing (Suhas Daftuar) f107417490ab5b81d3ec139de777a19db87845b6 bench: add more mempool benchmarks (Suhas Daftuar) 7976eb1ae77af2c88e1e61e85d4a61390b34b986 Avoid violating mempool policy limits in tests (Suhas Daftuar) 84de685cf7ee3baf3ca73087e5222411a0504df8 Stop tracking parents/children outside of txgraph (Suhas Daftuar) 88672e205ba1570fc92449b557fd32d836618781 Rewrite GatherClusters to use the txgraph implementation (Suhas Daftuar) 1ca4f01090cfa968c789fafde42054da3263a0e2 Fix miniminer_tests to work with cluster limits (Suhas Daftuar) 1902111e0f20fe6b5c12be019d24691d6b0b8d3e Eliminate CheckPackageLimits, which no longer does anything (Suhas Daftuar) 3a646ec4626441c8c2946598f94199a65d9646d6 Rework RBF and TRUC validation (Suhas Daftuar) 19b8479868e5c854d9268e3647b9488f9b23af0f Make getting parents/children a function of the mempool, not a mempool entry (Suhas Daftuar) 5560913e51af036b5e6907e08cd07488617b12f7 Rework truc_policy to use descendants, not children (Suhas Daftuar) a4458d6c406215dccb31fd35e0968a65a3269670 Use txgraph to calculate descendants (Suhas Daftuar) c8b6f70d6492a153b59697d6303fc0515f316f89 Use txgraph to calculate ancestors (Suhas Daftuar) 241a3e666b59abb695c9d0a13d7458a763c2c5a0 Simplify ancestor calculation functions (Suhas Daftuar) b9cec7f0a1e089cd77bb2fa1c2b54e93442e594c Make removeConflicts private (Suhas Daftuar) 0402e6c7808017bf5c04edb4b68128ede7d1c1e7 Remove unused limits from CalculateMemPoolAncestors (Suhas Daftuar) 08be765ac26a3ae721cb3574d4348602a9982e44 Remove mempool logic designed to maintain ancestor/descendant state (Suhas Daftuar) fc4e3e6bc12284d3b328c1ad19502294accfe5ad Remove unused members from CTxMemPoolEntry (Suhas Daftuar) ff3b398d124b9efa49b612dbbb715bbe5d53e727 mempool: eliminate accessors to mempool entry ancestor/descendant cached state (Suhas Daftuar) b9a2039f51226dce2c4e38ce5f26eefee171744b Eliminate use of cached ancestor data in miniminer_tests and truc_policy (Suhas Daftuar) ba09fc9774d5a0eaa58d93a2fa20bef1efc74f1e mempool: Remove unused function CalculateDescendantMaximum (Suhas Daftuar) 8e49477e86b3089ea70d1f2659b9fd3a8a1f7db4 wallet: Replace max descendant count with cluster_count (Suhas Daftuar) e031085fd464b528c186948d3cbf1c08a5a8d624 Eliminate Single-Conflict RBF Carve Out (Suhas Daftuar) cf3ab8e1d0a2f2bdf72e61e2c2dcb35987e5b9bd Stop enforcing descendant size/count limits (Suhas Daftuar) 89ae38f48965ec0d6c0600ce4269fdc797274161 test: remove rbf carveout test from mempool_limit.py (Suhas Daftuar) c0bd04d18fdf77a2f20f3c32f8eee4f1d71afd79 Calculate descendant information for mempool RPC output on-the-fly (Suhas Daftuar) bdcefb8a8b0667539744eae63e9eb5b7dc1c51da Use mempool/txgraph to determine if a tx has descendants (Suhas Daftuar) 69e1eaa6ed22f542ab48da755fa63f7694a15533 Add test case for cluster size limits to TRUC logic (Suhas Daftuar) 9cda64b86c593f0d6ff8f17e483e6566f436b200 Stop enforcing ancestor size/count limits (Suhas Daftuar) 1f93227a84a54397699ca40d889f98913e4d5868 Remove dependency on cached ancestor data in mini-miner (Suhas Daftuar) 9fbe0a4ac26c2fddaa3201cdfd8b69bf1f5ffa01 rpc: Calculate ancestor data from scratch for mempool rpc calls (Suhas Daftuar) 7961496dda2eb24a3f09d661005f06611558a20a Reimplement GetTransactionAncestry() to not rely on cached data (Suhas Daftuar) feceaa42e8eb43344ced33d94187e93268d45187 Remove CTxMemPool::GetSortedDepthAndScore (Suhas Daftuar) 21b5cea588a7bfe758a8d14efe90046b111db428 Use cluster linearization for transaction relay sort order (Suhas Daftuar) 6445aa7d97551ec5d501d91f6829071c67169122 Remove the ancestor and descendant indices from the mempool (Suhas Daftuar) 216e6937290338950215795291dbf0a533e234cf Implement new RBF logic for cluster mempool (Suhas Daftuar) ff8f115dec6eb41f739e6e6738dd60becfa168fd policy: Remove CPFP carveout rule (Suhas Daftuar) c3f1afc934e69a9849625924f72a5886a85eb833 test: rewrite PopulateMempool to not violate mempool policy (cluster size) limits (Suhas Daftuar) 47ab32fdb158069d4422e0f92078603c6df070a6 Select transactions for blocks based on chunk feerate (Suhas Daftuar) dec138d1ddc79cc3a06e53ed255f0931ce46e684 fuzz: remove comparison between mini_miner block construction and miner (Suhas Daftuar) 6c2bceb200aa7206d44b551d42ad3e70943f1425 bench: rewrite ComplexMemPool to not create oversized clusters (Suhas Daftuar) 1ad4590f63855e856d59616d41a87873315c3a2e Limit mempool size based on chunk feerate (Suhas Daftuar) b11c89cab210c87ebaf34fbd2a73d28353e8c7bd Rework miner_tests to not require large cluster limit (Suhas Daftuar) 95a8297d481e96d65ac81e4dac72b2ebecb9c765 Check cluster limits when using -walletrejectlongchains (Suhas Daftuar) 95762e6759597d201d685ed6bf6df6eedccf9a00 Do not allow mempool clusters to exceed configured limits (Suhas Daftuar) edb3e7cdf63688058ad2b90bea0d4933d9967be8 [test] rework/delete feature_rbf tests requiring large clusters (glozow) 435fd5671116b990cf3b875b99036606f921a71d test: update feature_rbf.py replacement test (Suhas Daftuar) 34e32985e811607e7566ae7a6caeacdf8bd8384f Add new (unused) limits for cluster size/count (Suhas Daftuar) 838d7e3553661cb6ba0be32dd872bafb444822d9 Add transactions to txgraph, but without cluster dependencies (Suhas Daftuar) d5ed9cb3eb52c33c5ac36421bb2da00290be6087 Add accessor for sigops-adjusted weight (Suhas Daftuar) 1bf3b513966e34b45ea359cbe7576383437f5d93 Add sigops adjusted weight calculator (Suhas Daftuar) c18c68a950d3a17e80ad0bc11ac7ee3de1a87f6c Create a txgraph inside CTxMemPool (Suhas Daftuar) 29a94d5b2f26a4a8b7464894e4db944ea67241b7 Make CTxMemPoolEntry derive from TxGraph::Ref (Suhas Daftuar) 92b0079fe3863b20b71282aa82341d4b6ee4b337 Allow moving CTxMemPoolEntry objects, disallow copying (Suhas Daftuar) 6c73e4744837a7dc138a9177df3a48f30a1ba6c1 mempool: Store iterators into mapTx in mapNextTx (Suhas Daftuar) 51430680ecb722e1d4ee4a26dac5724050f41c9e Allow moving an Epoch::Marker (Suhas Daftuar) Pull request description: [Reopening #28676 here as a new PR, because GitHub is slow to load the page making it hard to scroll through and see comments. Also, that PR was originally opened with a prototype implementation which has changed significantly with the introduction of `TxGraph`.] This is an implementation of the [cluster mempool proposal](https://delvingbitcoin.org/t/an-overview-of-the-cluster-mempool-proposal/393). This branch implements the following observable behavior changes: - Maintains a partitioning of the mempool into connected clusters (via the `txgraph` class), which are limited in vsize to 101 kvB by default, and limited in count to 64 by default. - Each cluster is sorted ("linearized") to try to optimize for selecting highest-feerate-subsets of a cluster first - Transaction selection for mining is updated to use the cluster linearizations, selecting highest feerate "chunks" first for inclusion in a block template. - Mempool eviction is updated to use the cluster linearizations, selecting lowest feerate "chunks" first for removal. - The RBF rules are updated to: (a) drop the requirement that no new inputs are introduced; (b) change the feerate requirement to instead check that the feerate diagram of the mempool will strictly improve; (c) replace the direct conflicts limit with a directly-conflicting-clusters limit. - The CPFP carveout rule is eliminated (it doesn't make sense in a cluster-limited mempool) - The ancestor and descendant limits are no longer enforced. - New cluster count/cluster vsize limits are now enforced instead. - Transaction relay now uses chunk feerate comparisons to determine the order that newly received transactions are announced to peers. Additionally, the cached ancestor and descendant data are dropped from the mempool, along with the multi_index indices that were maintained to sort the mempool by ancestor and descendant feerates. For compatibility (eg with wallet behavior or RPCs exposing this), this information is now calculated dynamically instead. ACKs for top commit: instagibbs: reACK 17cf9ff7efdbab07644fc2f9017fcac1b0757c38 glozow: reACK 17cf9ff7efdbab07644fc2f9017fcac1b0757c38 sipa: ACK 17cf9ff7efdbab07644fc2f9017fcac1b0757c38 Tree-SHA512: bbde46d913d56f8d9c0426cb0a6c4fa80b01b0a4c2299500769921f886082fb4f51f1694e0ee1bc318c52e1976d7ebed8134a64eda0b8044f3a708c04938eee7
704 lines
38 KiB
Python
Executable File
704 lines
38 KiB
Python
Executable File
#!/usr/bin/env python3
|
|
# Copyright (c) 2014-2022 The Bitcoin Core developers
|
|
# Distributed under the MIT software license, see the accompanying
|
|
# file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
"""Test the wallet."""
|
|
from decimal import Decimal
|
|
from itertools import product
|
|
|
|
from test_framework.blocktools import COINBASE_MATURITY
|
|
from test_framework.descriptors import descsum_create
|
|
from test_framework.messages import (
|
|
COIN,
|
|
DEFAULT_ANCESTOR_LIMIT,
|
|
)
|
|
from test_framework.test_framework import BitcoinTestFramework
|
|
from test_framework.util import (
|
|
assert_array_result,
|
|
assert_equal,
|
|
assert_fee_amount,
|
|
assert_raises_rpc_error,
|
|
)
|
|
from test_framework.wallet_util import test_address
|
|
from test_framework.wallet import MiniWallet
|
|
|
|
NOT_A_NUMBER_OR_STRING = "Amount is not a number or string"
|
|
OUT_OF_RANGE = "Amount out of range"
|
|
|
|
|
|
class WalletTest(BitcoinTestFramework):
|
|
def set_test_params(self):
|
|
self.num_nodes = 4
|
|
# whitelist peers to speed up tx relay / mempool sync
|
|
self.noban_tx_relay = True
|
|
self.extra_args = [[
|
|
"-dustrelayfee=0", "-walletrejectlongchains=0", "-deprecatedrpc=settxfee"
|
|
]] * self.num_nodes
|
|
self.setup_clean_chain = True
|
|
self.supports_cli = False
|
|
|
|
def skip_test_if_missing_module(self):
|
|
self.skip_if_no_wallet()
|
|
|
|
def setup_network(self):
|
|
self.setup_nodes()
|
|
# Only need nodes 0-2 running at start of test
|
|
self.stop_node(3)
|
|
self.connect_nodes(0, 1)
|
|
self.connect_nodes(1, 2)
|
|
self.connect_nodes(0, 2)
|
|
self.sync_all(self.nodes[0:3])
|
|
|
|
def check_fee_amount(self, curr_balance, balance_with_fee, fee_per_byte, tx_size):
|
|
"""Return curr_balance after asserting the fee was in range"""
|
|
fee = balance_with_fee - curr_balance
|
|
assert_fee_amount(fee, tx_size, fee_per_byte * 1000)
|
|
return curr_balance
|
|
|
|
def get_vsize(self, txn):
|
|
return self.nodes[0].decoderawtransaction(txn)['vsize']
|
|
|
|
def run_test(self):
|
|
|
|
# Check that there's no UTXO on none of the nodes
|
|
assert_equal(len(self.nodes[0].listunspent()), 0)
|
|
assert_equal(len(self.nodes[1].listunspent()), 0)
|
|
assert_equal(len(self.nodes[2].listunspent()), 0)
|
|
|
|
self.log.info("Mining blocks...")
|
|
|
|
self.generate(self.nodes[0], 1, sync_fun=self.no_op)
|
|
|
|
balances = self.nodes[0].getbalances()
|
|
assert_equal(balances["mine"]["immature"], 50)
|
|
assert_equal(balances["mine"]["trusted"], 0)
|
|
|
|
self.sync_all(self.nodes[0:3])
|
|
self.generate(self.nodes[1], COINBASE_MATURITY + 1, sync_fun=lambda: self.sync_all(self.nodes[0:3]))
|
|
|
|
assert_equal(self.nodes[0].getbalance(), 50)
|
|
assert_equal(self.nodes[1].getbalance(), 50)
|
|
assert_equal(self.nodes[2].getbalance(), 0)
|
|
|
|
# Check that only first and second nodes have UTXOs
|
|
utxos = self.nodes[0].listunspent()
|
|
assert_equal(len(utxos), 1)
|
|
assert_equal(len(self.nodes[1].listunspent()), 1)
|
|
assert_equal(len(self.nodes[2].listunspent()), 0)
|
|
|
|
self.log.info("Test gettxout")
|
|
confirmed_txid, confirmed_index = utxos[0]["txid"], utxos[0]["vout"]
|
|
# First, outputs that are unspent both in the chain and in the
|
|
# mempool should appear with or without include_mempool
|
|
txout = self.nodes[0].gettxout(txid=confirmed_txid, n=confirmed_index, include_mempool=False)
|
|
assert_equal(txout['value'], 50)
|
|
txout = self.nodes[0].gettxout(txid=confirmed_txid, n=confirmed_index, include_mempool=True)
|
|
assert_equal(txout['value'], 50)
|
|
|
|
# Send 21 BTC from 0 to 2 using sendtoaddress call.
|
|
self.nodes[0].sendtoaddress(self.nodes[2].getnewaddress(), 11)
|
|
mempool_txid = self.nodes[0].sendtoaddress(self.nodes[2].getnewaddress(), 10)
|
|
|
|
self.log.info("Test gettxout (second part)")
|
|
# utxo spent in mempool should be visible if you exclude mempool
|
|
# but invisible if you include mempool
|
|
txout = self.nodes[0].gettxout(confirmed_txid, confirmed_index, False)
|
|
assert_equal(txout['value'], 50)
|
|
txout = self.nodes[0].gettxout(confirmed_txid, confirmed_index) # by default include_mempool=True
|
|
assert txout is None
|
|
txout = self.nodes[0].gettxout(confirmed_txid, confirmed_index, True)
|
|
assert txout is None
|
|
# new utxo from mempool should be invisible if you exclude mempool
|
|
# but visible if you include mempool
|
|
txout = self.nodes[0].gettxout(mempool_txid, 0, False)
|
|
assert txout is None
|
|
txout1 = self.nodes[0].gettxout(mempool_txid, 0, True)
|
|
txout2 = self.nodes[0].gettxout(mempool_txid, 1, True)
|
|
# note the mempool tx will have randomly assigned indices
|
|
# but 10 will go to node2 and the rest will go to node0
|
|
balance = self.nodes[0].getbalance()
|
|
assert_equal(set([txout1['value'], txout2['value']]), set([10, balance]))
|
|
assert_equal(self.nodes[0].getbalances()["mine"]["immature"], 0)
|
|
|
|
# Have node0 mine a block, thus it will collect its own fee.
|
|
self.generate(self.nodes[0], 1, sync_fun=lambda: self.sync_all(self.nodes[0:3]))
|
|
|
|
# Exercise locking of unspent outputs
|
|
unspent_0 = self.nodes[2].listunspent()[0]
|
|
unspent_0 = {"txid": unspent_0["txid"], "vout": unspent_0["vout"]}
|
|
# Trying to unlock an output which isn't locked should error
|
|
assert_raises_rpc_error(-8, "Invalid parameter, expected locked output", self.nodes[2].lockunspent, True, [unspent_0])
|
|
|
|
# Locking an already-locked output should error
|
|
self.nodes[2].lockunspent(False, [unspent_0])
|
|
assert_raises_rpc_error(-8, "Invalid parameter, output already locked", self.nodes[2].lockunspent, False, [unspent_0])
|
|
|
|
# Restarting the node should clear the lock
|
|
self.restart_node(2)
|
|
self.nodes[2].lockunspent(False, [unspent_0])
|
|
|
|
# Unloading and reloating the wallet should clear the lock
|
|
assert_equal(self.nodes[0].listwallets(), [self.default_wallet_name])
|
|
self.nodes[2].unloadwallet(self.default_wallet_name)
|
|
self.nodes[2].loadwallet(self.default_wallet_name)
|
|
assert_equal(len(self.nodes[2].listlockunspent()), 0)
|
|
|
|
# Locking non-persistently, then re-locking persistently, is allowed
|
|
self.nodes[2].lockunspent(False, [unspent_0])
|
|
self.nodes[2].lockunspent(False, [unspent_0], True)
|
|
|
|
# Restarting the node with the lock written to the wallet should keep the lock
|
|
self.restart_node(2, ["-walletrejectlongchains=0"])
|
|
assert_raises_rpc_error(-8, "Invalid parameter, output already locked", self.nodes[2].lockunspent, False, [unspent_0])
|
|
|
|
# Unloading and reloading the wallet with a persistent lock should keep the lock
|
|
self.nodes[2].unloadwallet(self.default_wallet_name)
|
|
self.nodes[2].loadwallet(self.default_wallet_name)
|
|
assert_raises_rpc_error(-8, "Invalid parameter, output already locked", self.nodes[2].lockunspent, False, [unspent_0])
|
|
|
|
# Locked outputs should not be used, even if they are the only available funds
|
|
assert_raises_rpc_error(-6, "Insufficient funds", self.nodes[2].sendtoaddress, self.nodes[2].getnewaddress(), 20)
|
|
assert_equal([unspent_0], self.nodes[2].listlockunspent())
|
|
|
|
# Unlocking should remove the persistent lock
|
|
self.nodes[2].lockunspent(True, [unspent_0])
|
|
self.restart_node(2)
|
|
assert_equal(len(self.nodes[2].listlockunspent()), 0)
|
|
|
|
# Reconnect node 2 after restarts
|
|
self.connect_nodes(1, 2)
|
|
self.connect_nodes(0, 2)
|
|
|
|
assert_raises_rpc_error(-8, "txid must be of length 64 (not 34, for '0000000000000000000000000000000000')",
|
|
self.nodes[2].lockunspent, False,
|
|
[{"txid": "0000000000000000000000000000000000", "vout": 0}])
|
|
assert_raises_rpc_error(-8, "txid must be hexadecimal string (not 'ZZZ0000000000000000000000000000000000000000000000000000000000000')",
|
|
self.nodes[2].lockunspent, False,
|
|
[{"txid": "ZZZ0000000000000000000000000000000000000000000000000000000000000", "vout": 0}])
|
|
assert_raises_rpc_error(-8, "Invalid parameter, unknown transaction",
|
|
self.nodes[2].lockunspent, False,
|
|
[{"txid": "0000000000000000000000000000000000000000000000000000000000000000", "vout": 0}])
|
|
assert_raises_rpc_error(-8, "Invalid parameter, vout index out of bounds",
|
|
self.nodes[2].lockunspent, False,
|
|
[{"txid": unspent_0["txid"], "vout": 999}])
|
|
|
|
# The lock on a manually selected output is ignored
|
|
unspent_0 = self.nodes[1].listunspent()[0]
|
|
self.nodes[1].lockunspent(False, [unspent_0])
|
|
tx = self.nodes[1].createrawtransaction([unspent_0], { self.nodes[1].getnewaddress() : 1 })
|
|
self.nodes[1].fundrawtransaction(tx,{"lockUnspents": True})
|
|
|
|
# fundrawtransaction can lock an input
|
|
self.nodes[1].lockunspent(True, [unspent_0])
|
|
assert_equal(len(self.nodes[1].listlockunspent()), 0)
|
|
tx = self.nodes[1].fundrawtransaction(tx,{"lockUnspents": True})['hex']
|
|
assert_equal(len(self.nodes[1].listlockunspent()), 1)
|
|
|
|
# Send transaction
|
|
tx = self.nodes[1].signrawtransactionwithwallet(tx)["hex"]
|
|
self.nodes[1].sendrawtransaction(tx)
|
|
assert_equal(len(self.nodes[1].listlockunspent()), 0)
|
|
|
|
# Have node1 generate 100 blocks (so node0 can recover the fee)
|
|
self.generate(self.nodes[1], COINBASE_MATURITY, sync_fun=lambda: self.sync_all(self.nodes[0:3]))
|
|
|
|
# node0 should end up with 100 btc in block rewards plus fees, but
|
|
# minus the 21 plus fees sent to node2
|
|
assert_equal(self.nodes[0].getbalance(), 100 - 21)
|
|
assert_equal(self.nodes[2].getbalance(), 21)
|
|
|
|
# Node0 should have two unspent outputs.
|
|
# Create a couple of transactions to send them to node2, submit them through
|
|
# node1, and make sure both node0 and node2 pick them up properly:
|
|
node0utxos = self.nodes[0].listunspent(1)
|
|
assert_equal(len(node0utxos), 2)
|
|
|
|
# create both transactions
|
|
txns_to_send = []
|
|
for utxo in node0utxos:
|
|
inputs = []
|
|
outputs = {}
|
|
inputs.append({"txid": utxo["txid"], "vout": utxo["vout"]})
|
|
outputs[self.nodes[2].getnewaddress()] = utxo["amount"] - 3
|
|
raw_tx = self.nodes[0].createrawtransaction(inputs, outputs)
|
|
txns_to_send.append(self.nodes[0].signrawtransactionwithwallet(raw_tx))
|
|
|
|
# Have node 1 (miner) send the transactions
|
|
self.nodes[1].sendrawtransaction(hexstring=txns_to_send[0]["hex"], maxfeerate=0)
|
|
self.nodes[1].sendrawtransaction(hexstring=txns_to_send[1]["hex"], maxfeerate=0)
|
|
|
|
# Have node1 mine a block to confirm transactions:
|
|
self.generate(self.nodes[1], 1, sync_fun=lambda: self.sync_all(self.nodes[0:3]))
|
|
|
|
assert_equal(self.nodes[0].getbalance(), 0)
|
|
assert_equal(self.nodes[2].getbalance(), 94)
|
|
|
|
# Verify that a spent output cannot be locked anymore
|
|
spent_0 = {"txid": node0utxos[0]["txid"], "vout": node0utxos[0]["vout"]}
|
|
assert_raises_rpc_error(-8, "Invalid parameter, expected unspent output", self.nodes[0].lockunspent, False, [spent_0])
|
|
|
|
# Send 10 BTC normal
|
|
address = self.nodes[0].getnewaddress("test")
|
|
fee_per_byte = Decimal('0.001') / 1000
|
|
self.nodes[2].settxfee(fee_per_byte * 1000)
|
|
txid = self.nodes[2].sendtoaddress(address, 10, "", "", False)
|
|
self.generate(self.nodes[2], 1, sync_fun=lambda: self.sync_all(self.nodes[0:3]))
|
|
node_2_bal = self.check_fee_amount(self.nodes[2].getbalance(), Decimal('84'), fee_per_byte, self.get_vsize(self.nodes[2].gettransaction(txid)['hex']))
|
|
assert_equal(self.nodes[0].getbalance(), Decimal('10'))
|
|
|
|
# Send 10 BTC with subtract fee from amount
|
|
txid = self.nodes[2].sendtoaddress(address, 10, "", "", True)
|
|
self.generate(self.nodes[2], 1, sync_fun=lambda: self.sync_all(self.nodes[0:3]))
|
|
node_2_bal -= Decimal('10')
|
|
assert_equal(self.nodes[2].getbalance(), node_2_bal)
|
|
node_0_bal = self.check_fee_amount(self.nodes[0].getbalance(), Decimal('20'), fee_per_byte, self.get_vsize(self.nodes[2].gettransaction(txid)['hex']))
|
|
|
|
self.log.info("Test sendmany")
|
|
|
|
# Sendmany 10 BTC
|
|
txid = self.nodes[2].sendmany('', {address: 10}, 0, "", [])
|
|
self.generate(self.nodes[2], 1, sync_fun=lambda: self.sync_all(self.nodes[0:3]))
|
|
node_0_bal += Decimal('10')
|
|
node_2_bal = self.check_fee_amount(self.nodes[2].getbalance(), node_2_bal - Decimal('10'), fee_per_byte, self.get_vsize(self.nodes[2].gettransaction(txid)['hex']))
|
|
assert_equal(self.nodes[0].getbalance(), node_0_bal)
|
|
|
|
# Sendmany 10 BTC with subtract fee from amount
|
|
txid = self.nodes[2].sendmany('', {address: 10}, 0, "", [address])
|
|
self.generate(self.nodes[2], 1, sync_fun=lambda: self.sync_all(self.nodes[0:3]))
|
|
node_2_bal -= Decimal('10')
|
|
assert_equal(self.nodes[2].getbalance(), node_2_bal)
|
|
node_0_bal = self.check_fee_amount(self.nodes[0].getbalance(), node_0_bal + Decimal('10'), fee_per_byte, self.get_vsize(self.nodes[2].gettransaction(txid)['hex']))
|
|
|
|
# Sendmany 5 BTC to two addresses with subtracting fee from both addresses
|
|
a0 = self.nodes[0].getnewaddress()
|
|
a1 = self.nodes[0].getnewaddress()
|
|
txid = self.nodes[2].sendmany(dummy='', amounts={a0: 5, a1: 5}, subtractfeefrom=[a0, a1])
|
|
self.generate(self.nodes[2], 1, sync_fun=lambda: self.sync_all(self.nodes[0:3]))
|
|
node_2_bal -= Decimal('10')
|
|
assert_equal(self.nodes[2].getbalance(), node_2_bal)
|
|
tx = self.nodes[2].gettransaction(txid)
|
|
node_0_bal = self.check_fee_amount(self.nodes[0].getbalance(), node_0_bal + Decimal('10'), fee_per_byte, self.get_vsize(tx['hex']))
|
|
assert_equal(self.nodes[0].getbalance(), node_0_bal)
|
|
expected_bal = Decimal('5') + (tx['fee'] / 2)
|
|
assert_equal(self.nodes[0].getreceivedbyaddress(a0), expected_bal)
|
|
assert_equal(self.nodes[0].getreceivedbyaddress(a1), expected_bal)
|
|
|
|
self.log.info("Test sendmany with fee_rate param (explicit fee rate in sat/vB)")
|
|
fee_rate_sat_vb = 2
|
|
fee_rate_btc_kvb = fee_rate_sat_vb * 1e3 / 1e8
|
|
explicit_fee_rate_btc_kvb = Decimal(fee_rate_btc_kvb) / 1000
|
|
|
|
# Test passing fee_rate as a string
|
|
txid = self.nodes[2].sendmany(amounts={address: 10}, fee_rate=str(fee_rate_sat_vb))
|
|
self.generate(self.nodes[2], 1, sync_fun=lambda: self.sync_all(self.nodes[0:3]))
|
|
balance = self.nodes[2].getbalance()
|
|
node_2_bal = self.check_fee_amount(balance, node_2_bal - Decimal('10'), explicit_fee_rate_btc_kvb, self.get_vsize(self.nodes[2].gettransaction(txid)['hex']))
|
|
assert_equal(balance, node_2_bal)
|
|
node_0_bal += Decimal('10')
|
|
assert_equal(self.nodes[0].getbalance(), node_0_bal)
|
|
|
|
# Test passing fee_rate as an integer
|
|
amount = Decimal("0.0001")
|
|
txid = self.nodes[2].sendmany(amounts={address: amount}, fee_rate=fee_rate_sat_vb)
|
|
self.generate(self.nodes[2], 1, sync_fun=lambda: self.sync_all(self.nodes[0:3]))
|
|
balance = self.nodes[2].getbalance()
|
|
node_2_bal = self.check_fee_amount(balance, node_2_bal - amount, explicit_fee_rate_btc_kvb, self.get_vsize(self.nodes[2].gettransaction(txid)['hex']))
|
|
assert_equal(balance, node_2_bal)
|
|
node_0_bal += amount
|
|
assert_equal(self.nodes[0].getbalance(), node_0_bal)
|
|
|
|
assert_raises_rpc_error(-8, "Unknown named parameter feeRate", self.nodes[2].sendtoaddress, address=address, amount=1, fee_rate=1, feeRate=1)
|
|
|
|
# Test setting explicit fee rate just below the minimum.
|
|
self.log.info("Test sendmany raises 'fee rate too low' if fee_rate of 0.99999999 is passed")
|
|
assert_raises_rpc_error(-6, "Fee rate (0.999 sat/vB) is lower than the minimum fee rate setting (1.000 sat/vB)",
|
|
self.nodes[2].sendmany, amounts={address: 10}, fee_rate=0.999)
|
|
|
|
self.log.info("Test sendmany raises if an invalid fee_rate is passed")
|
|
# Test fee_rate with zero values.
|
|
msg = "Fee rate (0.000 sat/vB) is lower than the minimum fee rate setting (1.000 sat/vB)"
|
|
for zero_value in [0, 0.000, 0.00000000, "0", "0.000", "0.00000000"]:
|
|
assert_raises_rpc_error(-6, msg, self.nodes[2].sendmany, amounts={address: 1}, fee_rate=zero_value)
|
|
msg = "Invalid amount"
|
|
# Test fee_rate values that don't pass fixed-point parsing checks.
|
|
for invalid_value in ["", 0.000000001, 1e-09, 1.111111111, 1111111111111111, "31.999999999999999999999"]:
|
|
assert_raises_rpc_error(-3, msg, self.nodes[2].sendmany, amounts={address: 1.0}, fee_rate=invalid_value)
|
|
# Test fee_rate values that cannot be represented in sat/vB.
|
|
for invalid_value in [0.0001, 0.00000001, 0.00099999, 31.99999999]:
|
|
assert_raises_rpc_error(-3, msg, self.nodes[2].sendmany, amounts={address: 10}, fee_rate=invalid_value)
|
|
# Test fee_rate out of range (negative number).
|
|
assert_raises_rpc_error(-3, OUT_OF_RANGE, self.nodes[2].sendmany, amounts={address: 10}, fee_rate=-1)
|
|
# Test type error.
|
|
for invalid_value in [True, {"foo": "bar"}]:
|
|
assert_raises_rpc_error(-3, NOT_A_NUMBER_OR_STRING, self.nodes[2].sendmany, amounts={address: 10}, fee_rate=invalid_value)
|
|
|
|
self.log.info("Test sendmany raises if an invalid conf_target or estimate_mode is passed")
|
|
for target, mode in product([-1, 0, 1009], ["economical", "conservative"]):
|
|
assert_raises_rpc_error(-8, "Invalid conf_target, must be between 1 and 1008", # max value of 1008 per src/policy/fees/block_policy_estimator.h
|
|
self.nodes[2].sendmany, amounts={address: 1}, conf_target=target, estimate_mode=mode)
|
|
for target, mode in product([-1, 0], ["btc/kb", "sat/b"]):
|
|
assert_raises_rpc_error(-8, 'Invalid estimate_mode parameter, must be one of: "unset", "economical", "conservative"',
|
|
self.nodes[2].sendmany, amounts={address: 1}, conf_target=target, estimate_mode=mode)
|
|
|
|
self.start_node(3, self.nodes[3].extra_args)
|
|
self.connect_nodes(0, 3)
|
|
self.sync_all()
|
|
|
|
# check if we can list zero value tx as available coins
|
|
# 1. create raw_tx
|
|
# 2. hex-changed one output to 0.0
|
|
# 3. sign and send
|
|
# 4. check if recipient (node0) can list the zero value tx
|
|
usp = self.nodes[1].listunspent(query_options={'minimumAmount': '49.998'})[0]
|
|
inputs = [{"txid": usp['txid'], "vout": usp['vout']}]
|
|
outputs = {self.nodes[1].getnewaddress(): 49.998, self.nodes[0].getnewaddress(): 11.11}
|
|
|
|
raw_tx = self.nodes[1].createrawtransaction(inputs, outputs).replace("c0833842", "00000000") # replace 11.11 with 0.0 (int32)
|
|
signed_raw_tx = self.nodes[1].signrawtransactionwithwallet(raw_tx)
|
|
decoded_raw_tx = self.nodes[1].decoderawtransaction(signed_raw_tx['hex'])
|
|
zero_value_txid = decoded_raw_tx['txid']
|
|
self.nodes[1].sendrawtransaction(signed_raw_tx['hex'])
|
|
|
|
self.sync_all()
|
|
self.generate(self.nodes[1], 1) # mine a block
|
|
|
|
unspent_txs = self.nodes[0].listunspent() # zero value tx must be in listunspents output
|
|
found = False
|
|
for uTx in unspent_txs:
|
|
if uTx['txid'] == zero_value_txid:
|
|
found = True
|
|
assert_equal(uTx['amount'], Decimal('0'))
|
|
assert found
|
|
|
|
self.log.info("Test -walletbroadcast")
|
|
self.stop_nodes()
|
|
self.start_node(0, ["-walletbroadcast=0"])
|
|
self.start_node(1, ["-walletbroadcast=0"])
|
|
self.start_node(2, ["-walletbroadcast=0"])
|
|
self.connect_nodes(0, 1)
|
|
self.connect_nodes(1, 2)
|
|
self.connect_nodes(0, 2)
|
|
self.sync_all(self.nodes[0:3])
|
|
|
|
txid_not_broadcast = self.nodes[0].sendtoaddress(self.nodes[2].getnewaddress(), 2)
|
|
tx_obj_not_broadcast = self.nodes[0].gettransaction(txid_not_broadcast)
|
|
self.generate(self.nodes[1], 1, sync_fun=lambda: self.sync_all(self.nodes[0:3])) # mine a block, tx should not be in there
|
|
assert_equal(self.nodes[2].getbalance(), node_2_bal) # should not be changed because tx was not broadcasted
|
|
|
|
# now broadcast from another node, mine a block, sync, and check the balance
|
|
self.nodes[1].sendrawtransaction(tx_obj_not_broadcast['hex'])
|
|
self.generate(self.nodes[1], 1, sync_fun=lambda: self.sync_all(self.nodes[0:3]))
|
|
node_2_bal += 2
|
|
tx_obj_not_broadcast = self.nodes[0].gettransaction(txid_not_broadcast)
|
|
assert_equal(self.nodes[2].getbalance(), node_2_bal)
|
|
|
|
# create another tx
|
|
self.nodes[0].sendtoaddress(self.nodes[2].getnewaddress(), 2)
|
|
|
|
# restart the nodes with -walletbroadcast=1
|
|
self.stop_nodes()
|
|
self.start_node(0)
|
|
self.start_node(1)
|
|
self.start_node(2)
|
|
self.connect_nodes(0, 1)
|
|
self.connect_nodes(1, 2)
|
|
self.connect_nodes(0, 2)
|
|
self.sync_blocks(self.nodes[0:3])
|
|
|
|
self.generate(self.nodes[0], 1, sync_fun=lambda: self.sync_blocks(self.nodes[0:3]))
|
|
node_2_bal += 2
|
|
|
|
# tx should be added to balance because after restarting the nodes tx should be broadcast
|
|
assert_equal(self.nodes[2].getbalance(), node_2_bal)
|
|
|
|
# send a tx with value in a string (PR#6380 +)
|
|
txid = self.nodes[0].sendtoaddress(self.nodes[2].getnewaddress(), "2")
|
|
tx_obj = self.nodes[0].gettransaction(txid)
|
|
assert_equal(tx_obj['amount'], Decimal('-2'))
|
|
|
|
txid = self.nodes[0].sendtoaddress(self.nodes[2].getnewaddress(), "0.0001")
|
|
tx_obj = self.nodes[0].gettransaction(txid)
|
|
assert_equal(tx_obj['amount'], Decimal('-0.0001'))
|
|
|
|
# check if JSON parser can handle scientific notation in strings
|
|
txid = self.nodes[0].sendtoaddress(self.nodes[2].getnewaddress(), "1e-4")
|
|
tx_obj = self.nodes[0].gettransaction(txid)
|
|
assert_equal(tx_obj['amount'], Decimal('-0.0001'))
|
|
|
|
# General checks for errors from incorrect inputs
|
|
# This will raise an exception because the amount is negative
|
|
assert_raises_rpc_error(-3, OUT_OF_RANGE, self.nodes[0].sendtoaddress, self.nodes[2].getnewaddress(), "-1")
|
|
|
|
# This will raise an exception because the amount type is wrong
|
|
assert_raises_rpc_error(-3, "Invalid amount", self.nodes[0].sendtoaddress, self.nodes[2].getnewaddress(), "1f-4")
|
|
|
|
# This will raise an exception since generate does not accept a string
|
|
assert_raises_rpc_error(-3, "not of expected type number", self.generate, self.nodes[0], "2")
|
|
|
|
# Mine a block from node0 to an address from node1
|
|
coinbase_addr = self.nodes[1].getnewaddress()
|
|
block_hash = self.generatetoaddress(self.nodes[0], 1, coinbase_addr, sync_fun=lambda: self.sync_all(self.nodes[0:3]))[0]
|
|
coinbase_txid = self.nodes[0].getblock(block_hash)['tx'][0]
|
|
|
|
# Check that the txid and balance is found by node1
|
|
self.nodes[1].gettransaction(coinbase_txid)
|
|
|
|
# check if wallet or blockchain maintenance changes the balance
|
|
self.sync_all(self.nodes[0:3])
|
|
blocks = self.generate(self.nodes[0], 2, sync_fun=lambda: self.sync_all(self.nodes[0:3]))
|
|
balance_nodes = [self.nodes[i].getbalance() for i in range(3)]
|
|
block_count = self.nodes[0].getblockcount()
|
|
|
|
# Check modes:
|
|
# - True: unicode escaped as \u....
|
|
# - False: unicode directly as UTF-8
|
|
for mode in [True, False]:
|
|
self.nodes[0]._rpc.ensure_ascii = mode
|
|
# unicode check: Basic Multilingual Plane, Supplementary Plane respectively
|
|
for label in [u'рыба', u'𝅘𝅥𝅯']:
|
|
addr = self.nodes[0].getnewaddress()
|
|
self.nodes[0].setlabel(addr, label)
|
|
test_address(self.nodes[0], addr, labels=[label])
|
|
assert label in self.nodes[0].listlabels()
|
|
self.nodes[0]._rpc.ensure_ascii = True # restore to default
|
|
|
|
# -reindex tests
|
|
chainlimit = 6
|
|
self.log.info("Test -reindex")
|
|
self.stop_nodes()
|
|
# set lower ancestor limit for later
|
|
self.start_node(0, ['-reindex', "-walletrejectlongchains=0", "-limitancestorcount=" + str(chainlimit), "-limitclustercount=" + str(chainlimit)])
|
|
self.start_node(1, ['-reindex', "-limitclustercount=" + str(chainlimit)])
|
|
self.start_node(2, ['-reindex', "-limitclustercount=" + str(chainlimit)])
|
|
# reindex will leave rpc warm up "early"; Wait for it to finish
|
|
self.wait_until(lambda: [block_count] * 3 == [self.nodes[i].getblockcount() for i in range(3)])
|
|
assert_equal(balance_nodes, [self.nodes[i].getbalance() for i in range(3)])
|
|
|
|
# Exercise listsinceblock with the last two blocks
|
|
coinbase_tx_1 = self.nodes[0].listsinceblock(blocks[0])
|
|
assert_equal(coinbase_tx_1["lastblock"], blocks[1])
|
|
assert_equal(len(coinbase_tx_1["transactions"]), 1)
|
|
assert_equal(coinbase_tx_1["transactions"][0]["blockhash"], blocks[1])
|
|
assert_equal(len(self.nodes[0].listsinceblock(blocks[1])["transactions"]), 0)
|
|
|
|
# ==Check that wallet prefers to use coins that don't exceed mempool limits =====
|
|
|
|
# Get all non-zero utxos together and split into two chains
|
|
chain_addrs = [self.nodes[0].getnewaddress(), self.nodes[0].getnewaddress()]
|
|
self.nodes[0].sendall(recipients=chain_addrs)
|
|
self.generate(self.nodes[0], 1, sync_fun=self.no_op)
|
|
|
|
# Make a long chain of unconfirmed payments without hitting mempool limit
|
|
# Each tx we make leaves only one output of change on a chain 1 longer
|
|
# Since the amount to send is always much less than the outputs, we only ever need one output
|
|
# So we should be able to generate exactly chainlimit txs for each original output
|
|
sending_addr = self.nodes[1].getnewaddress()
|
|
txid_list = []
|
|
for _ in range(chainlimit * 2):
|
|
txid_list.append(self.nodes[0].sendtoaddress(sending_addr, Decimal('0.0001')))
|
|
assert_equal(self.nodes[0].getmempoolinfo()['size'], chainlimit * 2)
|
|
assert_equal(len(txid_list), chainlimit * 2)
|
|
|
|
# Without walletrejectlongchains, we will still generate a txid
|
|
# The tx will be stored in the wallet but not accepted to the mempool
|
|
extra_txid = self.nodes[0].sendtoaddress(sending_addr, Decimal('0.0001'))
|
|
assert extra_txid not in self.nodes[0].getrawmempool()
|
|
assert extra_txid in [tx["txid"] for tx in self.nodes[0].listtransactions()]
|
|
self.nodes[0].abandontransaction(extra_txid)
|
|
total_txs = len(self.nodes[0].listtransactions("*", 99999))
|
|
|
|
# Try with walletrejectlongchains
|
|
# Double chain limit but require combining inputs, so we pass AttemptSelection
|
|
self.stop_node(0)
|
|
extra_args = ["-walletrejectlongchains", "-limitclustercount=" + str(2 * chainlimit), "-limitancestorcount=" + str(2*chainlimit)]
|
|
self.start_node(0, extra_args=extra_args)
|
|
|
|
# wait until the wallet has submitted all transactions to the mempool
|
|
self.wait_until(lambda: len(self.nodes[0].getrawmempool()) == chainlimit * 2)
|
|
|
|
# Prevent potential race condition when calling wallet RPCs right after restart
|
|
self.nodes[0].syncwithvalidationinterfacequeue()
|
|
|
|
node0_balance = self.nodes[0].getbalance()
|
|
# With walletrejectlongchains we will not create the tx and store it in our wallet.
|
|
assert_raises_rpc_error(-6, "too many unconfirmed transactions in cluster", self.nodes[0].sendtoaddress, sending_addr, node0_balance - Decimal('0.01'))
|
|
|
|
# Verify nothing new in wallet
|
|
assert_equal(total_txs, len(self.nodes[0].listtransactions("*", 99999)))
|
|
|
|
# Test getaddressinfo on external address. Note that these addresses are taken from disablewallet.py
|
|
assert_raises_rpc_error(-5, "Invalid or unsupported Base58-encoded address.", self.nodes[0].getaddressinfo, "3J98t1WpEZ73CNmQviecrnyiWrnqRhWNLy")
|
|
address_info = self.nodes[0].getaddressinfo("mneYUmWYsuk7kySiURxCi3AGxrAqZxLgPZ")
|
|
assert_equal(address_info['address'], "mneYUmWYsuk7kySiURxCi3AGxrAqZxLgPZ")
|
|
assert_equal(address_info["scriptPubKey"], "76a9144e3854046c7bd1594ac904e4793b6a45b36dea0988ac")
|
|
assert not address_info["ismine"]
|
|
assert not address_info["isscript"]
|
|
assert not address_info["ischange"]
|
|
|
|
# Test getaddressinfo 'ischange' field on change address.
|
|
self.generate(self.nodes[0], 1, sync_fun=self.no_op)
|
|
destination = self.nodes[1].getnewaddress()
|
|
txid = self.nodes[0].sendtoaddress(destination, 0.123)
|
|
tx = self.nodes[0].gettransaction(txid=txid, verbose=True)['decoded']
|
|
assert len(tx["vout"]) > 1
|
|
for vout in tx["vout"]:
|
|
address = vout['scriptPubKey']['address']
|
|
ischange = self.nodes[0].getaddressinfo(address)['ischange']
|
|
assert_equal(ischange, address != destination)
|
|
if ischange:
|
|
change = address
|
|
assert vout["ischange"]
|
|
else:
|
|
assert "ischange" not in vout
|
|
self.nodes[0].setlabel(change, 'foobar')
|
|
assert_equal(self.nodes[0].getaddressinfo(change)['ischange'], False)
|
|
|
|
# Test gettransaction response with different arguments.
|
|
self.log.info("Testing gettransaction response with different arguments...")
|
|
self.nodes[0].setlabel(change, 'baz')
|
|
baz = self.nodes[0].listtransactions(label="baz", count=1)[0]
|
|
expected_receive_vout = {"label": "baz",
|
|
"address": baz["address"],
|
|
"amount": baz["amount"],
|
|
"category": baz["category"],
|
|
"vout": baz["vout"]}
|
|
expected_fields = frozenset({'amount', 'bip125-replaceable', 'confirmations', 'details', 'fee',
|
|
'hex', 'lastprocessedblock', 'time', 'timereceived', 'trusted', 'txid', 'wtxid', 'walletconflicts', 'mempoolconflicts'})
|
|
verbose_field = "decoded"
|
|
expected_verbose_fields = expected_fields | {verbose_field}
|
|
|
|
self.log.debug("Testing gettransaction response without verbose")
|
|
tx = self.nodes[0].gettransaction(txid=txid)
|
|
assert_equal(set([*tx]), expected_fields)
|
|
assert_array_result(tx["details"], {"category": "receive"}, expected_receive_vout)
|
|
|
|
self.log.debug("Testing gettransaction response with verbose set to False")
|
|
tx = self.nodes[0].gettransaction(txid=txid, verbose=False)
|
|
assert_equal(set([*tx]), expected_fields)
|
|
assert_array_result(tx["details"], {"category": "receive"}, expected_receive_vout)
|
|
|
|
self.log.debug("Testing gettransaction response with verbose set to True")
|
|
tx = self.nodes[0].gettransaction(txid=txid, verbose=True)
|
|
assert_equal(set([*tx]), expected_verbose_fields)
|
|
assert_array_result(tx["details"], {"category": "receive"}, expected_receive_vout)
|
|
assert_equal(tx[verbose_field], self.nodes[0].decoderawtransaction(tx["hex"]))
|
|
|
|
self.log.info("Test send* RPCs with verbose=True")
|
|
address = self.nodes[0].getnewaddress("test")
|
|
txid_feeReason_one = self.nodes[2].sendtoaddress(address=address, amount=5, verbose=True)
|
|
assert_equal(txid_feeReason_one["fee_reason"], "Fallback fee")
|
|
txid_feeReason_two = self.nodes[2].sendmany(dummy='', amounts={address: 5}, verbose=True)
|
|
assert_equal(txid_feeReason_two["fee_reason"], "Fallback fee")
|
|
self.log.info("Test send* RPCs with verbose=False")
|
|
txid_feeReason_three = self.nodes[2].sendtoaddress(address=address, amount=5, verbose=False)
|
|
assert_equal(self.nodes[2].gettransaction(txid_feeReason_three)['txid'], txid_feeReason_three)
|
|
txid_feeReason_four = self.nodes[2].sendmany(dummy='', amounts={address: 5}, verbose=False)
|
|
assert_equal(self.nodes[2].gettransaction(txid_feeReason_four)['txid'], txid_feeReason_four)
|
|
|
|
self.log.info("Testing 'listunspent' outputs the parent descriptor(s) of coins")
|
|
# Create two multisig descriptors, and send a UTxO each.
|
|
multi_a = descsum_create("wsh(multi(1,tpubD6NzVbkrYhZ4YBNjUo96Jxd1u4XKWgnoc7LsA1jz3Yc2NiDbhtfBhaBtemB73n9V5vtJHwU6FVXwggTbeoJWQ1rzdz8ysDuQkpnaHyvnvzR/*,tpubD6NzVbkrYhZ4YHdDGMAYGaWxMSC1B6tPRTHuU5t3BcfcS3nrF523iFm5waFd1pP3ZvJt4Jr8XmCmsTBNx5suhcSgtzpGjGMASR3tau1hJz4/*))")
|
|
multi_b = descsum_create("wsh(multi(1,tpubD6NzVbkrYhZ4YHdDGMAYGaWxMSC1B6tPRTHuU5t3BcfcS3nrF523iFm5waFd1pP3ZvJt4Jr8XmCmsTBNx5suhcSgtzpGjGMASR3tau1hJz4/*,tpubD6NzVbkrYhZ4Y2RLiuEzNQkntjmsLpPYDm3LTRBYynUQtDtpzeUKAcb9sYthSFL3YR74cdFgF5mW8yKxv2W2CWuZDFR2dUpE5PF9kbrVXNZ/*))")
|
|
addr_a = self.nodes[0].deriveaddresses(multi_a, 0)[0]
|
|
addr_b = self.nodes[0].deriveaddresses(multi_b, 0)[0]
|
|
txid_a = self.nodes[0].sendtoaddress(addr_a, 0.01)
|
|
txid_b = self.nodes[0].sendtoaddress(addr_b, 0.01)
|
|
self.generate(self.nodes[0], 1, sync_fun=self.no_op)
|
|
# Prevent race of listunspent with outstanding TxAddedToMempool notifications
|
|
self.nodes[0].syncwithvalidationinterfacequeue()
|
|
# Now import the descriptors, make sure we can identify on which descriptor each coin was received.
|
|
self.nodes[0].createwallet(wallet_name="wo", disable_private_keys=True)
|
|
wo_wallet = self.nodes[0].get_wallet_rpc("wo")
|
|
wo_wallet.importdescriptors([
|
|
{
|
|
"desc": multi_a,
|
|
"active": False,
|
|
"timestamp": "now",
|
|
},
|
|
{
|
|
"desc": multi_b,
|
|
"active": False,
|
|
"timestamp": "now",
|
|
},
|
|
])
|
|
coins = wo_wallet.listunspent(minconf=0)
|
|
assert_equal(len(coins), 2)
|
|
coin_a = next(c for c in coins if c["txid"] == txid_a)
|
|
assert_equal(coin_a["parent_descs"][0], multi_a)
|
|
coin_b = next(c for c in coins if c["txid"] == txid_b)
|
|
assert_equal(coin_b["parent_descs"][0], multi_b)
|
|
self.nodes[0].unloadwallet("wo")
|
|
|
|
self.log.info("Test -spendzeroconfchange")
|
|
self.restart_node(0, ["-spendzeroconfchange=0"])
|
|
|
|
# create new wallet and fund it with a confirmed UTXO
|
|
self.nodes[0].createwallet(wallet_name="zeroconf", load_on_startup=True)
|
|
zeroconf_wallet = self.nodes[0].get_wallet_rpc("zeroconf")
|
|
default_wallet = self.nodes[0].get_wallet_rpc(self.default_wallet_name)
|
|
default_wallet.sendtoaddress(zeroconf_wallet.getnewaddress(), Decimal('1.0'))
|
|
self.generate(self.nodes[0], 1, sync_fun=self.no_op)
|
|
utxos = zeroconf_wallet.listunspent(minconf=0)
|
|
assert_equal(len(utxos), 1)
|
|
assert_equal(utxos[0]['confirmations'], 1)
|
|
|
|
# spend confirmed UTXO to ourselves
|
|
zeroconf_wallet.sendall(recipients=[zeroconf_wallet.getnewaddress()])
|
|
utxos = zeroconf_wallet.listunspent(minconf=0)
|
|
assert_equal(len(utxos), 1)
|
|
assert_equal(utxos[0]['confirmations'], 0)
|
|
# accounts for untrusted pending balance
|
|
bal = zeroconf_wallet.getbalances()
|
|
assert_equal(bal['mine']['trusted'], 0)
|
|
assert_equal(bal['mine']['untrusted_pending'], utxos[0]['amount'])
|
|
|
|
# spending an unconfirmed UTXO sent to ourselves should fail
|
|
assert_raises_rpc_error(-6, "Insufficient funds", zeroconf_wallet.sendtoaddress, zeroconf_wallet.getnewaddress(), Decimal('0.5'))
|
|
|
|
# check that it works again with -spendzeroconfchange set (=default)
|
|
self.restart_node(0, ["-spendzeroconfchange=1"])
|
|
# Make sure the wallet knows the tx in the mempool
|
|
self.nodes[0].syncwithvalidationinterfacequeue()
|
|
|
|
zeroconf_wallet = self.nodes[0].get_wallet_rpc("zeroconf")
|
|
utxos = zeroconf_wallet.listunspent(minconf=0)
|
|
assert_equal(len(utxos), 1)
|
|
assert_equal(utxos[0]['confirmations'], 0)
|
|
# accounts for trusted balance
|
|
bal = zeroconf_wallet.getbalances()
|
|
assert_equal(bal['mine']['trusted'], utxos[0]['amount'])
|
|
assert_equal(bal['mine']['untrusted_pending'], 0)
|
|
|
|
zeroconf_wallet.sendtoaddress(zeroconf_wallet.getnewaddress(), Decimal('0.5'))
|
|
|
|
self.test_chain_listunspent()
|
|
|
|
def test_chain_listunspent(self):
|
|
self.wallet = MiniWallet(self.nodes[0])
|
|
self.nodes[0].get_wallet_rpc(self.default_wallet_name).sendtoaddress(self.wallet.get_address(), "5")
|
|
self.generate(self.wallet, 1, sync_fun=self.no_op)
|
|
self.nodes[0].createwallet("watch_wallet", disable_private_keys=True)
|
|
watch_wallet = self.nodes[0].get_wallet_rpc("watch_wallet")
|
|
import_res = watch_wallet.importdescriptors([{"desc": self.wallet.get_descriptor(), "timestamp": "now"}])
|
|
assert_equal(import_res[0]["success"], True)
|
|
|
|
# DEFAULT_ANCESTOR_LIMIT transactions off a confirmed tx should be fine
|
|
chain = self.wallet.create_self_transfer_chain(chain_length=DEFAULT_ANCESTOR_LIMIT)
|
|
ancestor_vsize = 0
|
|
ancestor_fees = Decimal(0)
|
|
|
|
for i, t in enumerate(chain):
|
|
ancestor_vsize += t["tx"].get_vsize()
|
|
ancestor_fees += t["fee"]
|
|
self.wallet.sendrawtransaction(from_node=self.nodes[0], tx_hex=t["hex"])
|
|
# Check that listunspent ancestor{count, size, fees} yield the correct results
|
|
wallet_unspent = watch_wallet.listunspent(minconf=0)
|
|
this_unspent = next(utxo_info for utxo_info in wallet_unspent if utxo_info["txid"] == t["txid"])
|
|
assert_equal(this_unspent['ancestorcount'], i + 1)
|
|
assert_equal(this_unspent['ancestorsize'], ancestor_vsize)
|
|
assert_equal(this_unspent['ancestorfees'], ancestor_fees * COIN)
|
|
|
|
|
|
if __name__ == '__main__':
|
|
WalletTest(__file__).main()
|