cryptogera/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-02-08 14:41:29 +00:00
Code Issues Packages Projects Releases Wiki Activity
bitcoin/src/wallet
History
fanquake a1e0359618
Merge #19986: refactor: clean up -Wlogical-op warning in wallet/scriptpubkeyman.cp 
95fedd33a23d6cb7542378afef229965f1ebfd68 refactor: Clean up -Wlogical-op warning (maskoficarus)

Pull request description:

  This is a quick patch that fixes #19912 . This change prevents a -Wlogical-op warning that occurs because we're treating a const int value as a boolean. There's no sense checking if a non-zero constant has a value, so I've removed the check.

  #18836 also addresses the same warning, but has a larger scope and will require more review. This pull request will act as a patch to prevent this compile warning until 18836 is merged.

ACKs for top commit:
  MarcoFalke:
    review ACK 95fedd33a23d6cb7542378afef229965f1ebfd68
  hebasto:
    ACK 95fedd33a23d6cb7542378afef229965f1ebfd68, tested on Linux Mint 20 (x86_64):

Tree-SHA512: 13a9d7f7cb472f4c22a01ca2f9771a75267ff769bdae9d0dc6b2c7f3b05369f6dfa859be2b172b39c15ede6c44cddf556380b3565e42850faa65ccd3fe6e175b
2020-10-19 11:07:11 +08:00
..
test
[send] Make send RPCs return fee reason
2020-09-26 17:57:26 -07:00
bdb.cpp
Determine wallet file type based on file magic
2020-10-14 11:28:18 -04:00
bdb.h
Determine wallet file type based on file magic
2020-10-14 11:28:18 -04:00
coincontrol.cpp
[rpc] walletcreatefundedpsbt: don't automatically append inputs
2020-03-12 13:07:17 +01:00
coincontrol.h
[rpc] walletcreatefundedpsbt: don't automatically append inputs
2020-03-12 13:07:17 +01:00
coinselection.cpp
Refactor OutputGroups to handle effective values, fees, and filtering
2020-08-11 14:25:02 -04:00
coinselection.h
Refactor OutputGroups to handle effective values, fees, and filtering
2020-08-11 14:25:02 -04:00
context.cpp
Remove g_rpc_chain global
2020-05-28 02:13:19 -04:00
context.h
wallet: Pass unused args to StartWallets
2020-07-09 13:07:37 +02:00
crypter.cpp
…
crypter.h
Convert wallet to new serialization
2020-05-24 10:34:52 -07:00
db.cpp
refactor: Pass wallet database into CWallet::Create
2020-09-03 12:24:32 -04:00
db.h
Determine wallet file type based on file magic
2020-10-14 11:28:18 -04:00
feebumper.cpp
[send] Make send RPCs return fee reason
2020-09-26 17:57:26 -07:00
feebumper.h
wallet: Avoid translating RPC errors when creating txs
2020-05-01 07:39:06 -04:00
fees.cpp
…
fees.h
…
init.cpp
Do not create default wallet
2020-09-08 21:02:53 -04:00
ismine.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
load.cpp
Do not create default wallet
2020-09-08 21:02:53 -04:00
load.h
Do not create default wallet
2020-09-08 21:02:53 -04:00
rpcdump.cpp
Merge #19836: rpc: Properly deserialize txs with witness before signing
2020-10-16 12:05:26 +08:00
rpcwallet.cpp
Merge #19836: rpc: Properly deserialize txs with witness before signing
2020-10-16 12:05:26 +08:00
rpcwallet.h
Assert that RPCArg names are equal to CRPCCommand ones (net, rpcwallet)
2020-09-22 20:49:30 +02:00
salvage.cpp
wallet: Remove path checking code from bitcoin-wallet tool
2020-09-03 12:24:32 -04:00
salvage.h
wallettool: Have RecoverDatabaseFile return errors and warnings
2020-07-26 20:22:45 -04:00
scriptpubkeyman.cpp
Merge #19986: refactor: clean up -Wlogical-op warning in wallet/scriptpubkeyman.cp
2020-10-19 11:07:11 +08:00
scriptpubkeyman.h
Add missed thread safety annotations
2020-08-29 20:46:23 +03:00
sqlite.cpp
wallet: Enforce sqlite serialized threading mode
2020-10-14 11:28:18 -04:00
sqlite.h
Determine wallet file type based on file magic
2020-10-14 11:28:18 -04:00
wallet.cpp
Use SQLite for descriptor wallets
2020-10-14 11:28:18 -04:00
wallet.h
Use SQLite for descriptor wallets
2020-10-14 11:28:18 -04:00
walletdb.cpp
Determine wallet file type based on file magic
2020-10-14 11:28:18 -04:00
walletdb.h
wallet: remove db mode string
2020-10-13 18:42:59 +07:00
wallettool.cpp
wallet: Remove path checking code from bitcoin-wallet tool
2020-09-03 12:24:32 -04:00
wallettool.h
wallet: Remove path checking code from bitcoin-wallet tool
2020-09-03 12:24:32 -04:00
walletutil.cpp
walletutil: Wallets can also be sqlite
2020-10-14 11:28:18 -04:00
walletutil.h
Remove WalletLocation class
2020-09-03 12:24:32 -04:00