W. J. van der Laan 32692d2681

Merge bitcoin/bitcoin#21359: rpc: include_unsafe option for fundrawtransaction ...

11d6459b6e101f05f36e13799c400bef82d2fc21 rpc: include_unsafe option for fundrawtransaction (t-bast)

Pull request description:

  Allow RPC users to opt-in to unsafe inputs when funding a raw transaction.

  Applications that need to manage a complex RBF flow (such as lightning nodes using anchor outputs) are very limited if they can only use safe inputs.

  I also added this option to `send` and `walletcreatefundedpsbt` who internally delegate to `fundrawtransaction`.

  Fixes #21299

ACKs for top commit:
  laanwj:
    Code review ACK 11d6459b6e101f05f36e13799c400bef82d2fc21

Tree-SHA512: 5e542a4febcfd6f41cf784678ff02ec9282eae2082c274983f72c5ea87b7ebbe1bd5fdc6a020d7a9d5996157754eb4966b8aeb6c1ceebf0b1519f735579b8bac

2021-05-10 16:05:23 +02:00

..

test

move-only: Move constants to blockstorage

2021-04-27 10:32:54 +02:00

bdb.cpp

scripted-diff: remove MakeUnique<T>()

2021-03-11 13:45:14 +08:00

bdb.h

wallet: Add BerkeleyDB version sanity check at init time

2021-01-17 18:10:20 +01:00

coincontrol.cpp

refactor: Drop CCoinControl::SetNull

2021-04-18 21:10:47 +01:00

coincontrol.h

rpc: include_unsafe option for fundrawtransaction

2021-04-30 18:53:47 +02:00

coinselection.cpp

refactor: post Optional<> removal cleanups

2021-03-17 14:56:20 +08:00

coinselection.h

rpc: include_unsafe option for fundrawtransaction

2021-04-30 18:53:47 +02:00

context.cpp

…

context.h

wallet: Pass unused args to StartWallets

2020-07-09 13:07:37 +02:00

crypter.cpp

refactor: Replace &foo[0] with foo.data()

2021-05-04 06:55:31 +02:00

crypter.h

scripted-diff: Bump copyright headers

2020-12-31 09:45:41 +01:00

db.cpp

wallet: List all wallets in non-SQLite or non-BDB builds

2020-12-04 11:03:28 -04:00

db.h

refactor: post Optional<> removal cleanups

2021-03-17 14:56:20 +08:00

dump.cpp

wallettool: Add createfromdump command

2020-12-16 12:33:06 -05:00

dump.h

wallettool: Add createfromdump command

2020-12-16 12:33:06 -05:00

external_signer_scriptpubkeyman.cpp

refactor: add missing includes to external signer code

2021-04-13 20:09:33 +08:00

external_signer_scriptpubkeyman.h

refactor: add missing includes to external signer code

2021-04-13 20:09:33 +08:00

feebumper.cpp

Merge #20536: wallet: Error with "Transaction too large" if the funded tx will end up being too large after signing

2021-03-09 10:42:21 +13:00

feebumper.h

…

fees.cpp

scripted-diff: Bump copyright headers

2020-12-31 09:45:41 +01:00

fees.h

…

init.cpp

tests: Skip SQLite fsyncs while testing

2021-04-12 19:29:03 -04:00

interfaces.cpp

Move external signer out of wallet module

2021-04-08 17:56:00 +02:00

ismine.h

doc: Add developer documentation to isminetype

2021-01-19 19:04:45 +08:00

load.cpp

scripted-diff: Replace three dots with ellipsis in the UI strings

2021-05-02 22:17:16 +03:00

load.h

scripted-diff: Bump copyright headers

2020-12-31 09:45:41 +01:00

rpcdump.cpp

Merge bitcoin/bitcoin#21836: scripted-diff: Replace three dots with ellipsis in the UI strings

2021-05-10 14:02:46 +02:00

rpcwallet.cpp

Merge bitcoin/bitcoin#21359: rpc: include_unsafe option for fundrawtransaction

2021-05-10 16:05:23 +02:00

rpcwallet.h

refactor: replace util::Ref by std::any (C++17)

2021-03-29 23:29:42 +02:00

salvage.cpp

refactor: Replace &foo[0] with foo.data()

2021-05-04 06:55:31 +02:00

salvage.h

…

scriptpubkeyman.cpp

refactor: Replace &foo[0] with foo.data()

2021-05-04 06:55:31 +02:00

scriptpubkeyman.h

wallet: ExternalSigner: add GetDescriptors method

2021-02-23 14:34:31 +01:00

sqlite.cpp

tests: Skip SQLite fsyncs while testing

2021-04-12 19:29:03 -04:00

sqlite.h

doc: fix various typos

2021-01-04 12:31:31 +08:00

wallet.cpp

Merge bitcoin/bitcoin#21359: rpc: include_unsafe option for fundrawtransaction

2021-05-10 16:05:23 +02:00

wallet.h

[docs] add doxygen comments to wallet code

2021-04-26 11:00:18 -07:00

walletdb.cpp

refactor: post Optional<> removal cleanups

2021-03-17 14:56:20 +08:00

walletdb.h

Include wallet/bdb.h where it is actually being used

2020-11-18 11:55:43 -05:00

wallettool.cpp

refactor: Move all command dependend checks to ExecuteWalletToolFunc

2021-01-21 19:30:34 +01:00

wallettool.h

refactor: Move all command dependend checks to ExecuteWalletToolFunc

2021-01-21 19:30:34 +01:00

walletutil.cpp

scripted-diff: Bump copyright headers

2020-12-31 09:45:41 +01:00

walletutil.h

wallet: add external_signer flag

2021-02-23 14:34:30 +01:00