MacroFake 718304d222

Merge bitcoin/bitcoin#26084: sendall: check if the maxtxfee has been exceeded ...

6f8e3818af7585b961039bf0c768be2e4ee44e0f sendall: check if the maxtxfee has been exceeded (ishaanam)

Pull request description:

  Previously the `sendall` RPC didn't check whether the fees of the transaction it creates exceed the set `maxtxfee`. This PR adds this check to `sendall` and a test case for it.

ACKs for top commit:
  achow101:
    ACK 6f8e3818af7585b961039bf0c768be2e4ee44e0f
  Xekyo:
    ACK 6f8e3818af7585b961039bf0c768be2e4ee44e0f
  glozow:
    Concept ACK 6f8e3818af7585b961039bf0c768be2e4ee44e0f. The high feerate is unlikely but sendall should respect the existing wallet options.

Tree-SHA512: 6ef0961937091293d49be16f17e4451cff3159d901c0c7c6e508883999dfe0c20ed4d7126bf74bfea8150d4c1eef961a45f0c28ef64562e6cb817fede2319f1a

2022-09-15 08:45:08 +02:00

..

rpc

Merge bitcoin/bitcoin#26084: sendall: check if the maxtxfee has been exceeded

2022-09-15 08:45:08 +02:00

test

wallet: coverage for loading an unknown descriptor

2022-09-09 15:35:31 -03:00

bdb.cpp

refactor: Make const refs vars where applicable

2022-07-27 13:27:57 +02:00

bdb.h

…

coincontrol.cpp

…

coincontrol.h

…

coinselection.cpp

wallet: use GetChange() when computing waste

2022-08-15 09:35:20 +02:00

coinselection.h

wallet: use GetChange() when computing waste

2022-08-15 09:35:20 +02:00

context.cpp

…

context.h

…

crypter.cpp

…

crypter.h

…

db.cpp

…

db.h

…

dump.cpp

Use HashWriter where possible

2022-07-20 15:34:36 +02:00

dump.h

…

external_signer_scriptpubkeyman.cpp

…

external_signer_scriptpubkeyman.h

…

feebumper.cpp

Merge bitcoin/bitcoin#25775: docs: remove non-signaling mentions of BIP125

2022-08-22 10:35:26 +01:00

feebumper.h

bumpfee: be able to bump fee of a tx with external inputs

2022-08-19 11:27:01 -04:00

fees.cpp

Remove ::dustRelayFee

2022-08-02 15:26:49 +02:00

fees.h

…

init.cpp

…

interfaces.cpp

bumpfee: be able to bump fee of a tx with external inputs

2022-08-19 11:27:01 -04:00

ismine.h

…

load.cpp

wallet: trigger MaybeResendWalletTxs() every minute

2022-08-25 14:29:25 +01:00

load.h

…

receive.cpp

Merge bitcoin/bitcoin#25707: refactor: Make const references to avoid unnecessarily copying objects and enable two clang-tidy checks

2022-08-19 17:11:06 +02:00

receive.h

Merge bitcoin/bitcoin#25504: RPC: allow to track coins by parent descriptors

2022-08-16 13:08:05 -04:00

salvage.cpp

…

salvage.h

…

scriptpubkeyman.cpp

Implement LegacyScriptPubKeyMan::DeleteRecords

2022-08-26 13:14:51 -04:00

scriptpubkeyman.h

Implement LegacyScriptPubKeyMan::DeleteRecords

2022-08-26 13:14:51 -04:00

spend.cpp

Merge bitcoin/bitcoin#25872: Fix issues when calling std::move(const&)

2022-08-31 08:38:24 +01:00

spend.h

wallet: switch to new shuffle, erase, push_back

2022-08-10 15:19:31 +02:00

sqlite.cpp

…

sqlite.h

…

transaction.cpp

…

transaction.h

wallet: Deduplicate Resend and ReacceptWalletTransactions

2022-08-29 12:38:06 -04:00

wallet.cpp

wallet: bugfix, load wallet with an unknown descriptor cause fatal error

2022-09-09 15:35:04 -03:00

wallet.h

Merge bitcoin/bitcoin#25768: wallet: Properly rebroadcast unconfirmed transaction chains

2022-09-05 13:54:36 +01:00

walletdb.cpp

wallet: bugfix, load wallet with an unknown descriptor cause fatal error

2022-09-09 15:35:04 -03:00

walletdb.h

wallet: bugfix, load wallet with an unknown descriptor cause fatal error

2022-09-09 15:35:04 -03:00

wallettool.cpp

Merge bitcoin/bitcoin#25784: Wallet: Document expectations for AddWalletFlags (now InitWalletFlags) correctly

2022-08-19 12:12:27 -04:00

wallettool.h

…

walletutil.cpp

…

walletutil.h

Implement LegacyScriptPubKeyMan::MigrateToDescriptor

2022-08-25 16:25:53 -04:00