bitcoin

mirror of https://github.com/bitcoin/bitcoin.git synced 2026-02-07 14:11:23 +00:00

History

Merge bitcoin/bitcoin#27920 : wallet: bugfix, always use apostrophe for spkm descriptor ID

5df988b534df842ddb658ad2a7ff0f12996c8478 test: add coverage for descriptor ID (furszy)
6a9510d2dabde1c9ee6c4226e3d16ca32eb48ac5 wallet: bugfix, always use apostrophe for spkm descriptor ID (furszy)
97a965d98f1582ea1b1377bd258c9088380e1b8b refactor: extract descriptor ID calculation from spkm GetID() (furszy)
1d207e3931cf076f69d4a8335cdd6c8ebb2a963f wallet: do not allow loading descriptor with an invalid ID (furszy)

Pull request description:

  Aiming to fix #27915.

  As we re-write the descriptor's db record every time that
  the wallet is loaded (at `TopUp` time), if the spkm ID differs
  from the one in db, the wallet will enter in an unrecoverable
  corruption state (due to the storage of a descriptor with an ID
  that is not linked to any other descriptor record in DB), and
  no soft version will be able to open it anymore.

  Because we cannot change the past, to stay compatible between
  releases, we need to always use the apostrophe version for the
  spkm IDs.

ACKs for top commit:
  achow101:
    ACK 5df988b534df842ddb658ad2a7ff0f12996c8478
  Sjors:
    tACK 5df988b534df842ddb658ad2a7ff0f12996c8478

Tree-SHA512: f63fc4aac7d21a4e515657471758d28857575e751865bfa359298f8b89b2568970029ca487a873c1786a5716325f453f06cd417ed193f3366417f6e8c2987332

2023-07-03 21:42:01 -04:00

fuzz

Merge bitcoin/bitcoin#27846 : [coinselection] Increase SRD target by change_fee

2023-06-23 16:57:11 -04:00

coinselector_tests.cpp

Merge bitcoin/bitcoin#27846 : [coinselection] Increase SRD target by change_fee

2023-06-23 16:57:11 -04:00

db_tests.cpp

Use only Span{} constructor for byte-like types where possible

2023-06-27 10:13:37 +02:00

feebumper_tests.cpp

test: Remove unused txmempool include from tests