Ava Chow 9f0f83d650

Merge bitcoin/bitcoin#29065: bench: wallet, fix change position out of range error ...

37c75c58202f89b752500f76c872d7f8caf6bdb3 test: wallet, fix change position out of range error (furszy)

Pull request description:

  Fixes #29061. Only the benchmark is affected.

  Since #25273, the behavior of 'inserting change at a random position'
  is instructed by passing ´std::nullopt´ instead of -1.

  Also, added missing documentation about the meaning of
  'change_pos=std::nullopt' inside 'CWallet::CreateTransaction()'

ACKs for top commit:
  achow101:
    ACK 37c75c58202f89b752500f76c872d7f8caf6bdb3
  kevkevinpal:
    ACK [37c75c5](37c75c5820)
  BrandonOdiwuor:
    ACK 37c75c58202f89b752500f76c872d7f8caf6bdb3

Tree-SHA512: d9a8d8533540455716a5090fcf407573cad9f0d0018a05f903f89e51620302f9b256318db6f7338b85c047f7fab372d724e916b1721d7ed302dbf3d845b08734

2023-12-13 12:45:30 -05:00

..

fuzz

Merge bitcoin/bitcoin#28994: wallet: skip BnB when SFFO is enabled

2023-12-12 10:52:12 -05:00

coinselector_tests.cpp

Merge bitcoin/bitcoin#28994: wallet: skip BnB when SFFO is enabled

2023-12-12 10:52:12 -05:00

db_tests.cpp

Use only Span{} constructor for byte-like types where possible

2023-06-27 10:13:37 +02:00

feebumper_tests.cpp

Use Txid in COutpoint

2023-11-21 13:15:44 +00:00

group_outputs_tests.cpp

refactor: Add LIFETIMEBOUND to all (w)txid getters

2023-10-27 13:01:42 +02:00

init_test_fixture.cpp

refactor: Replace string chain name constants with ChainTypes

2023-05-09 15:49:14 +02:00

init_test_fixture.h

refactor: Replace string chain name constants with ChainTypes

2023-05-09 15:49:14 +02:00

init_tests.cpp

move-only: Extract common/args and common/config.cpp from util/system

2023-04-19 10:48:30 +02:00

ismine_tests.cpp

Rename script/standard.{cpp/h} to script/solver.{cpp/h}

2023-08-14 17:39:49 -04:00

psbt_wallet_tests.cpp

Remove unused CDataStream

2023-11-30 11:27:54 +01:00

rpc_util_tests.cpp

refactor: move Boost datetime usage to wallet

2022-10-01 11:41:53 +01:00

scriptpubkeyman_tests.cpp

Rename script/standard.{cpp/h} to script/solver.{cpp/h}

2023-08-14 17:39:49 -04:00

spend_tests.cpp

test: wallet, fix change position out of range error

2023-12-12 15:20:38 -03:00

util.cpp

tests, bench: Remove incorrect LoadWallet() calls

2023-12-11 17:03:25 -05:00

util.h

Move CTxDestination to its own file

2023-08-14 17:38:27 -04:00

wallet_crypto_tests.cpp

Move random test util code from setup_common to random

2023-02-06 12:26:04 -08:00

wallet_test_fixture.cpp

Merge bitcoin/bitcoin#26715: Introduce MockableDatabase for wallet unit tests

2023-05-15 11:39:43 +01:00

wallet_test_fixture.h

refactor: Replace string chain name constants with ChainTypes

2023-05-09 15:49:14 +02:00

wallet_tests.cpp

test: wallet, fix change position out of range error

2023-12-12 15:20:38 -03:00

wallet_transaction_tests.cpp

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

walletdb_tests.cpp

Remove unused CDataStream

2023-11-30 11:27:54 +01:00

walletload_tests.cpp

Remove unused CDataStream

2023-11-30 11:27:54 +01:00