cryptogera/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-02-05 05:01:16 +00:00
Code Issues Packages Projects Releases Wiki Activity
bitcoin/src/wallet
History
Wladimir J. van der Laan 88b2652fad
Merge #18853: wallet: Fix typo in assert that is compile-time true 
fa47cf9d95dc2c2822fc96df16f179176935bf96 wallet: Fix typo in assert that is compile-time true (MarcoFalke)

Pull request description:

  Commit 92bcd70808b9cac56b184903aa6d37baf9641b37 presumably added a check that a `dest` of type `CNoDestination` implies an empty `scriptChange`.

  However, it accidentally checked for `boost::variant::empty`, which always returns false: https://www.boost.org/doc/libs/1_72_0/doc/html/boost/variant.html#id-1_3_46_5_4_1_1_16_2-bb

ACKs for top commit:
  Sjors:
    utACK fa47cf9d95dc2c2822fc96df16f179176935bf96

Tree-SHA512: 9626b1e2947039853703932a362c2ee204e002d3344856eb93eef0e0f833401336f2dfa80fd43b83c8ec6eac624e6302aee771fb67aec436ba6483be02b8d615
2020-05-06 14:19:41 +02:00
..
test
Merge #9381: Remove CWalletTx merging logic from AddToWallet
2020-05-06 11:36:32 +12:00
coincontrol.cpp
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
coincontrol.h
refactor: Nuke coincontrol circular dependency
2019-11-23 08:30:03 +02:00
coinselection.cpp
bnb: exit selection when best_waste is 0
2020-03-04 16:35:15 -05:00
coinselection.h
…
crypter.cpp
Fix occurences of c_str() used with size() to data()
2019-10-28 13:41:45 +01:00
crypter.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
db.cpp
wallet: Avoid translating RPC errors when loading wallets
2020-05-01 07:39:00 -04:00
db.h
wallet: Avoid translating RPC errors when loading wallets
2020-05-01 07:39:00 -04:00
feebumper.cpp
wallet: Remove trailing whitespace from potential translation strings
2020-05-01 07:41:32 -04:00
feebumper.h
wallet: Avoid translating RPC errors when creating txs
2020-05-01 07:39:06 -04:00
fees.cpp
…
fees.h
…
init.cpp
Merge #15761: Replace -upgradewallet startup option with upgradewallet RPC
2020-04-19 07:06:42 -04:00
ismine.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
load.cpp
wallet: Avoid translating RPC errors when loading wallets
2020-05-01 07:39:00 -04:00
load.h
…
rpcdump.cpp
Remove CWalletTx merging logic from AddToWallet
2020-05-01 05:59:09 -05:00
rpcwallet.cpp
Merge #9381: Remove CWalletTx merging logic from AddToWallet
2020-05-06 11:36:32 +12:00
rpcwallet.h
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
scriptpubkeyman.cpp
wallet: Avoid translating RPC errors when loading wallets
2020-05-01 07:39:00 -04:00
scriptpubkeyman.h
Merge #18782: wallet: Make sure no DescriptorScriptPubKeyMan or WalletDescriptor members are left uninitialized after construction
2020-05-05 15:56:04 +12:00
wallet.cpp
Merge #18853: wallet: Fix typo in assert that is compile-time true
2020-05-06 14:19:41 +02:00
wallet.h
Merge #9381: Remove CWalletTx merging logic from AddToWallet
2020-05-06 11:36:32 +12:00
walletdb.cpp
Merge #9381: Remove CWalletTx merging logic from AddToWallet
2020-05-06 11:36:32 +12:00
walletdb.h
Merge #9381: Remove CWalletTx merging logic from AddToWallet
2020-05-06 11:36:32 +12:00
wallettool.cpp
wallet: Report full error message in wallettool
2020-05-01 07:39:35 -04:00
wallettool.h
scripted-diff: Bump copyright of files changed in 2019
2019-12-30 10:42:20 +13:00
walletutil.cpp
Correctly check for default wallet
2020-04-23 13:59:48 -04:00
walletutil.h
wallet: Make sure no WalletDescriptor members are uninitialized after construction
2020-04-27 14:20:26 +00:00