cryptogera/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-02-01 11:11:22 +00:00
Code Issues Packages Projects Releases Wiki Activity
bitcoin/src/wallet
History
MarcoFalke eea6196c3d
Merge #21331: rpc: replace wallet raw pointers with references (#18592 rebased) 
7c90c67b7e6f598f9ffdc136ded2b533b78ed044 rpc: refactor rpc wallet functions to take references instead of pointers (fanquake)
48669340080feaff86b8fc0403ef22c820477697 rpc: remove calls to CWallet.get() (fanquake)

Pull request description:

  This is a rebased #18592.

  > This PR replaces raw pointers in `rpcwallet.cpp` and `rpcdump.cpp` with **shared_ptr**. The motivation for this PR is described here https://github.com/bitcoin/bitcoin/issues/18590

  > It seems that this PR is indirectly related to this issue: https://github.com/bitcoin/bitcoin/pull/13063#discussion_r186740049

  > Notice: I have deliberately **not** changed the class `WalletRescanReserver ` whose constructor expects a raw pointer, because it's external and affects other areas, which I didn't touch to avoid making this PR "viral".

  > Fixes https://github.com/bitcoin/bitcoin/issues/18590

ACKs for top commit:
  MarcoFalke:
    ACK 7c90c67b7e6f598f9ffdc136ded2b533b78ed044 🐧
  ryanofsky:
    Code review ACK 7c90c67b7e6f598f9ffdc136ded2b533b78ed044. Changes easy to review with `--word-diff-regex=. -U0`

Tree-SHA512: 32d69c813026b02260e8a89de9d6a5ab9e87826ba230687246583ac7a80c8c3fd00318da4658f1450e04c23d2c77ae765862de0d2a110b1312b3b69a1161e7ba
2021-03-10 08:24:53 +01:00
..
test
Change BOOST_CHECK to BOOST_CHECK_EQUAL to see mismatched values when a check fails.
2021-02-09 15:00:02 +01:00
bdb.cpp
Merge #20464: refactor: Treat CDataStream bytes as uint8_t
2021-02-01 15:17:28 +01:00
bdb.h
wallet: Add BerkeleyDB version sanity check at init time
2021-01-17 18:10:20 +01:00
coincontrol.cpp
…
coincontrol.h
…
coinselection.cpp
Merge #20040: wallet: Refactor OutputGroups to handle fees and spending eligibility on grouping
2021-02-01 22:43:17 +13:00
coinselection.h
Merge #20040: wallet: Refactor OutputGroups to handle fees and spending eligibility on grouping
2021-02-01 22:43:17 +13:00
context.cpp
…
context.h
wallet: Pass unused args to StartWallets
2020-07-09 13:07:37 +02:00
crypter.cpp
…
crypter.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
db.cpp
wallet: List all wallets in non-SQLite or non-BDB builds
2020-12-04 11:03:28 -04:00
db.h
refactor: Consolidate redundant wallet database path and exists functions
2020-12-04 11:03:28 -04:00
dump.cpp
wallettool: Add createfromdump command
2020-12-16 12:33:06 -05:00
dump.h
wallettool: Add createfromdump command
2020-12-16 12:33:06 -05:00
external_signer_scriptpubkeyman.cpp
rpc: signerdisplayaddress
2021-02-23 14:34:31 +01:00
external_signer_scriptpubkeyman.h
rpc: send: support external signer
2021-02-23 14:34:32 +01:00
external_signer.cpp
rpc: send: support external signer
2021-02-23 14:34:32 +01:00
external_signer.h
rpc: send: support external signer
2021-02-23 14:34:32 +01:00
feebumper.cpp
Merge #20536: wallet: Error with "Transaction too large" if the funded tx will end up being too large after signing
2021-03-09 10:42:21 +13:00
feebumper.h
…
fees.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
fees.h
…
init.cpp
wallet: fix doc typo in signer option
2021-02-23 11:05:13 -08:00
interfaces.cpp
rpc: add external signer RPC files
2021-02-23 14:34:30 +01:00
ismine.h
doc: Add developer documentation to isminetype
2021-01-19 19:04:45 +08:00
load.cpp
Replace fs::absolute calls with AbsPathJoin calls
2021-01-15 22:48:15 +01:00
load.h
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
rpcdump.cpp
rpc: refactor rpc wallet functions to take references instead of pointers
2021-03-05 09:20:13 +08:00
rpcsigner.cpp
rpc: signerdisplayaddress
2021-02-23 14:34:31 +01:00
rpcsigner.h
rpc: add external signer RPC files
2021-02-23 14:34:30 +01:00
rpcwallet.cpp
rpc: refactor rpc wallet functions to take references instead of pointers
2021-03-05 09:20:13 +08:00
rpcwallet.h
rpc: refactor rpc wallet functions to take references instead of pointers
2021-03-05 09:20:13 +08:00
salvage.cpp
refactor: Drop call to GetWalletEnv in wallet salvage code
2020-12-04 11:03:28 -04:00
salvage.h
wallettool: Have RecoverDatabaseFile return errors and warnings
2020-07-26 20:22:45 -04:00
scriptpubkeyman.cpp
rpc: send: support external signer
2021-02-23 14:34:32 +01:00
scriptpubkeyman.h
wallet: ExternalSigner: add GetDescriptors method
2021-02-23 14:34:31 +01:00
sqlite.cpp
refactor: Consolidate redundant wallet database path and exists functions
2020-12-04 11:03:28 -04:00
sqlite.h
doc: fix various typos
2021-01-04 12:31:31 +08:00
wallet.cpp
Merge #18842: wallet: Mark replaced tx to not be in the mempool anymore
2021-03-09 07:54:18 +01:00
wallet.h
Merge #20536: wallet: Error with "Transaction too large" if the funded tx will end up being too large after signing
2021-03-09 10:42:21 +13:00
walletdb.cpp
wallet: load flags before everything else
2021-02-09 19:01:15 +01:00
walletdb.h
Include wallet/bdb.h where it is actually being used
2020-11-18 11:55:43 -05:00
wallettool.cpp
refactor: Move all command dependend checks to ExecuteWalletToolFunc
2021-01-21 19:30:34 +01:00
wallettool.h
refactor: Move all command dependend checks to ExecuteWalletToolFunc
2021-01-21 19:30:34 +01:00
walletutil.cpp
scripted-diff: Bump copyright headers
2020-12-31 09:45:41 +01:00
walletutil.h
wallet: add external_signer flag
2021-02-23 14:34:30 +01:00