merge-script e2f2df0ead

Merge bitcoin/bitcoin#32984: wallet: Set migrated wallet name only on success ...

060695c22ae7b2b0f2a1dd1417ed1b9d5a5ab542 test: Failed load after migrate should restore backup (MarcoFalke)
8a4cfddf23a4575a1042dfa97d3478727775e8dd wallet: Set migrated wallet name only on success (Ava Chow)

Pull request description:

  After a wallet is migrated and we are trying to load it, if it could not be loaded, don't try to set the wallet name. Otherwise we have a segfault.

  This can be tested by migrated a legacy wallet from another network (e.g. trying to migrate a testnet wallet on mainnet). The fixed behavior is return an error and restore the backup.

ACKs for top commit:
  davidgumberg:
    ACK 060695c22ae7b2b0f2a1d
  furszy:
    ACK 060695c22ae7b2b0f2a1dd1417ed1b9d5a5ab542
  rkrux:
    ACK 060695c22ae7b2b0f2a1dd1417ed1b9d5a5ab542
  w0xlt:
    reACK 060695c22a
  pablomartin4btc:
    ACK 060695c22ae7b2b0f2a1dd1417ed1b9d5a5ab542

Tree-SHA512: f4289e0b3dedef0a3d734c18604f2fd0df0dc65e9641bc342cfa45088d2540a3f6631bbea8bdd394b2631fa83b38e8ac37c83cfc4b53b19dcbd0b820a9beb6e4

2025-07-24 12:00:52 +01:00

..

rpc

Merge bitcoin/bitcoin#32862: rpc: use CScheduler for relocking wallet and remove RPCTimer

2025-07-07 17:59:21 -07:00

test

wallet: remove outdated pszSkip arg of database Rewrite func

2025-07-16 14:27:17 +05:30

CMakeLists.txt

build, wallet, doc: Remove BDB

2025-05-06 12:21:32 -07:00

coincontrol.cpp

…

coincontrol.h

wallet, spend: Remove fWatchOnly from CCoinControl

2025-07-01 11:26:42 -07:00

coinselection.cpp

Remove unused variable assignment

2024-12-13 21:00:07 -06:00

coinselection.h

Merge bitcoin/bitcoin#29523: Wallet: Add max_tx_weight to transaction funding options (take 2)

2024-07-17 18:27:59 -04:00

context.cpp

…

context.h

…

crypter.cpp

refactor: vector -> span in CCrypter

2024-08-28 19:09:51 +02:00

crypter.h

wallet: refactor: introduce CMasterKey::DEFAULT_DERIVE_ITERATIONS constant

2025-01-27 18:11:05 +01:00

db.cpp

log: Use warning level while scanning wallet dir

2025-06-13 13:55:54 +02:00

db.h

wallet: remove outdated pszSkip arg of database Rewrite func

2025-07-16 14:27:17 +05:30

dump.cpp

doc: fix typos

2025-06-03 08:09:28 +01:00

dump.h

…

external_signer_scriptpubkeyman.cpp

wallet: use PSBTError::EXTERNAL_SIGNER_NOT_FOUND

2025-06-05 11:46:08 +02:00

external_signer_scriptpubkeyman.h

refactor: use util::Result for GetExternalSigner()

2025-06-05 11:32:23 +02:00

feebumper.cpp

Merge bitcoin/bitcoin#31622: psbt: add non-default sighash types to PSBTs and unify sighash type match checking

2025-05-21 10:02:49 +01:00

feebumper.h

wallet, refactor: Convert uint256 to Txid in wallet

2025-05-07 16:17:19 +01:00

fees.cpp

…

fees.h

…

init.cpp

build, wallet, doc: Remove BDB

2025-05-06 12:21:32 -07:00

interfaces.cpp

wallet, interfaces: Use BERKELEY_RO in isEncrypted

2025-06-04 16:51:51 -07:00

load.cpp

Merge bitcoin/bitcoin#32449: wallet: init, don't error out when loading legacy wallets

2025-06-02 13:31:35 -07:00

load.h

wallet: Remove unnecessary database Close step on shutdown

2025-05-14 11:03:57 -07:00

migrate.cpp

doc: remove For ... comments

2025-05-19 16:40:33 +01:00

migrate.h

wallet: remove outdated pszSkip arg of database Rewrite func

2025-07-16 14:27:17 +05:30

receive.cpp

wallet: Remove watchonly balances

2025-07-01 11:10:25 -07:00

receive.h

wallet: Remove watchonly balances

2025-07-01 11:10:25 -07:00

scriptpubkeyman.cpp

wallet: Remove ISMINE_WATCH_ONLY

2025-07-01 11:26:42 -07:00

scriptpubkeyman.h

wallet, refactor: Remove unused SetupGeneration

2025-06-10 16:34:17 -03:00

spend.cpp

wallet, spend: Remove fWatchOnly from CCoinControl

2025-07-01 11:26:42 -07:00

spend.h

doc: remove For ... comments

2025-05-19 16:40:33 +01:00

sqlite.cpp

wallet: remove outdated pszSkip arg of database Rewrite func

2025-07-16 14:27:17 +05:30

sqlite.h

wallet: remove outdated pszSkip arg of database Rewrite func

2025-07-16 14:27:17 +05:30

transaction.cpp

wallet: IsEquivalentTo should strip witness data in addition to scriptsigs

2025-06-10 21:25:14 +00:00

transaction.h

wallet: Remove unused CachedTxGet{Available,Immature}Credit

2025-06-25 14:08:49 -07:00

types.h

wallet: Remove ISMINE_WATCH_ONLY

2025-07-01 11:26:42 -07:00

wallet.cpp

Merge bitcoin/bitcoin#32984: wallet: Set migrated wallet name only on success

2025-07-24 12:00:52 +01:00

wallet.h

wallet: remove dead code in legacy wallet migration

2025-07-03 14:27:47 +05:30

walletdb.cpp

walletdb: Load Txs last

2025-06-25 14:08:49 -07:00

walletdb.h

refactor: Sort includes of touched source files

2025-06-03 19:56:55 +02:00

wallettool.cpp

Remove create options from wallet tool

2025-05-09 15:07:04 +02:00

wallettool.h

…

walletutil.cpp

descriptors: Change Parse to return vector of descriptors

2024-08-08 12:47:22 -04:00

walletutil.h

Merge bitcoin/bitcoin#22838: descriptors: Be able to specify change and receiving in a single descriptor string

2024-08-28 15:56:15 +01:00