Andrew Chow 0e70a1b625

Merge bitcoin/bitcoin#26066: wallet: Refactor and document CoinControl ...

daba95700b0b77a2e898299f218c47a69ed2c7d0 refactor: Make ListSelected return vector (Sebastian Falbesoner)
94776621ba6a79f3197ec71250bc48e974ad5e4a wallet: Move CoinCointrol definitions to .cpp (Aurèle Oulès)
1db23da6e163e793458ec702a9601d2837aea9cb wallet: Use std::optional for GetExternalOutput and fixups (Aurèle Oulès)
becc45b589d07c4523276e4ba2dad8852d0d2632 scripted-diff: Rename setSelected->m_selected_inputs (Aurèle Oulès)

Pull request description:

  - Moves CoinControl function definitions from `coincontrol.h` to `coincontrol.cpp`
  - Adds more documentation
  - Renames class member for an improved comprehension
  - Use `std::optional` for `GetExternalOutput`

ACKs for top commit:
  achow101:
    ACK daba95700b0b77a2e898299f218c47a69ed2c7d0
  Xekyo:
    ACK daba95700b0b77a2e898299f218c47a69ed2c7d0

Tree-SHA512: 3bf2dc834a3246c2f53f8c55154258e605fcb169431d3f7b156931f33c7e3b1ae28e03e16b37f9140a827890eb7798be485b2c36bfc23ff29bb01763f289a07c

2023-05-03 11:17:28 -04:00

..

rpc

Merge bitcoin/bitcoin#26094: rpc: Return block hash & height in getbalances, gettransaction and getwalletinfo

2023-05-02 11:50:45 -04:00

test

Merge bitcoin/bitcoin#27224: refactor: Remove CAddressBookData::destdata

2023-05-01 08:16:54 -04:00

bdb.cpp

Merge bitcoin/bitcoin#27224: refactor: Remove CAddressBookData::destdata

2023-05-01 08:16:54 -04:00

bdb.h

Merge bitcoin/bitcoin#27224: refactor: Remove CAddressBookData::destdata

2023-05-01 08:16:54 -04:00

coincontrol.cpp

refactor: Make ListSelected return vector

2023-04-26 10:41:10 +02:00

coincontrol.h

refactor: Make ListSelected return vector

2023-04-26 10:41:10 +02:00

coinselection.cpp

Merge bitcoin/bitcoin#27419: move-only: Extract common/args from util/system

2023-04-21 11:19:08 +01:00

coinselection.h

Merge bitcoin/bitcoin#26720: wallet: coin selection, don't return results that exceed the max allowed weight

2023-04-20 16:33:39 -04:00

context.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

context.h

…

crypter.cpp

…

crypter.h

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

db.cpp

move-only: Extract common/args and common/config.cpp from util/system

2023-04-19 10:48:30 +02:00

db.h

wallet: Add DatabaseBatch::ErasePrefix method

2023-04-12 05:30:43 -04:00

dump.cpp

move-only: Extract common/args and common/config.cpp from util/system

2023-04-19 10:48:30 +02:00

dump.h

refactor: Move fs.* to util/fs.*

2023-03-23 12:55:18 +01:00

external_signer_scriptpubkeyman.cpp

move-only: Extract common/args and common/config.cpp from util/system

2023-04-19 10:48:30 +02:00

external_signer_scriptpubkeyman.h

wallet: set keypool_size instead of access global args manager

2023-02-15 15:49:44 -03:00

feebumper.cpp

bumpfee: enable send coins back to yourself

2023-04-15 10:44:50 -03:00

feebumper.h

wallet: add outputs arguments to bumpfee and psbtbumpfee

2023-01-17 13:28:53 +02:00

fees.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

fees.h

…

init.cpp

move-only: Extract common/args and common/config.cpp from util/system

2023-04-19 10:48:30 +02:00

interfaces.cpp

Merge bitcoin/bitcoin#27224: refactor: Remove CAddressBookData::destdata

2023-05-01 08:16:54 -04:00

load.cpp

move-only: Extract common/args and common/config.cpp from util/system

2023-04-19 10:48:30 +02:00

load.h

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

receive.cpp

scripted-diff: Bump copyright headers

2022-12-24 23:49:50 +00:00

receive.h

wallet: Add wallet/types.h for simple public enum and struct types

2023-04-11 15:52:25 -04:00

salvage.cpp

refactor: Move fs.* to util/fs.*

2023-03-23 12:55:18 +01:00

salvage.h

refactor: Move fs.* to util/fs.*

2023-03-23 12:55:18 +01:00

scriptpubkeyman.cpp

Merge bitcoin/bitcoin#27274: refactor: remove unused param from legacy pubkey interface

2023-03-31 17:03:32 +01:00

scriptpubkeyman.h

wallet: Add wallet/types.h for simple public enum and struct types

2023-04-11 15:52:25 -04:00

spend.cpp

refactor: Make ListSelected return vector

2023-04-26 10:41:10 +02:00

spend.h

gui: bugfix, getAvailableBalance skips selected coins

2023-04-03 17:23:42 -03:00

sqlite.cpp

wallet: Add DatabaseBatch::ErasePrefix method

2023-04-12 05:30:43 -04:00

sqlite.h

wallet: Add DatabaseBatch::ErasePrefix method

2023-04-12 05:30:43 -04:00

transaction.cpp

…

transaction.h

wallet: Add wallet/types.h for simple public enum and struct types

2023-04-11 15:52:25 -04:00

types.h

wallet: add AddressPurpose enum to replace string values

2023-04-11 15:52:25 -04:00

wallet.cpp

Merge bitcoin/bitcoin#27224: refactor: Remove CAddressBookData::destdata

2023-05-01 08:16:54 -04:00

wallet.h

Merge bitcoin/bitcoin#27224: refactor: Remove CAddressBookData::destdata

2023-05-01 08:16:54 -04:00

walletdb.cpp

refactor: Remove CAddressBookData::destdata

2023-04-12 05:30:43 -04:00

walletdb.h

refactor: Remove CAddressBookData::destdata

2023-04-12 05:30:43 -04:00

wallettool.cpp

move-only: Extract common/args and common/config.cpp from util/system

2023-04-19 10:48:30 +02:00

wallettool.h

…

walletutil.cpp

move-only: Extract common/args and common/config.cpp from util/system

2023-04-19 10:48:30 +02:00

walletutil.h

refactor: Move fs.* to util/fs.*

2023-03-23 12:55:18 +01:00