fanquake 8cf2137dbe
Merge bitcoin/bitcoin#28958: refactor: Use Txid in CMerkleBlock
fa02c08c93e5867b7ea07d79ca1c0917dcde88e0 refactor: Use Txid in CMerkleBlock (MarcoFalke)

Pull request description:

  This should also fix a gcc-13 compiler warning, see https://github.com/bitcoin/bitcoin/pull/28922#discussion_r1407856376

  ```
  rpc/txoutproof.cpp: In lambda function:
  rpc/txoutproof.cpp:72:33: error: possibly dangling reference to a temporary [-Werror=dangling-reference]
     72 |                     const Coin& coin = AccessByTxid(active_chainstate.CoinsTip(), Txid::FromUint256(tx));
        |                                 ^~~~
  rpc/txoutproof.cpp:72:52: note: the temporary was destroyed at the end of the full expression ‘AccessByTxid((*(const CCoinsViewCache*)(&(& active_chainstate)->Chainstate::CoinsTip())), transaction_identifier<false>::FromUint256((* & tx)))’
     72 |                     const Coin& coin = AccessByTxid(active_chainstate.CoinsTip(), Txid::FromUint256(tx));
        |                                        ~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
  cc1plus: all warnings being treated as errors

ACKs for top commit:
  TheCharlatan:
    Re-ACK fa02c08c93e5867b7ea07d79ca1c0917dcde88e0
  dergoegge:
    reACK fa02c08c93e5867b7ea07d79ca1c0917dcde88e0

Tree-SHA512: 2e6837b9d0c90bd6e9d766330e7086d68c6ec80bb27fe2cfc4702b251b00d91a79f8bfbc76d998cbcd90bee5317402cf617f61099eee96d94e7ac8f37ba7a642
2023-11-29 10:55:18 +00:00
..
2023-11-14 17:41:54 +01:00
2023-11-21 13:15:44 +00:00
2023-11-07 10:21:51 +09:00
2023-09-12 12:14:31 -04:00
2023-11-21 13:15:44 +00:00
2023-11-21 13:15:44 +00:00
2023-03-23 19:38:38 +01:00
2023-01-26 10:44:05 +01:00
2023-11-20 15:57:56 -03:00
2023-01-26 10:44:05 +01:00
2023-01-26 10:44:05 +01:00
2023-11-21 13:15:44 +00:00
2023-11-21 13:15:44 +00:00