bitcoin

mirror of https://github.com/bitcoin/bitcoin.git synced 2026-02-12 16:41:46 +00:00

History

Merge bitcoin/bitcoin#27846 : [coinselection] Increase SRD target by change_fee

1771daa815ec014276cfcb30c934b0eaff4d72bf [fuzz] Show that SRD budgets for non-dust change (Murch)
941b8c6539d72890fd4e36fc900be9c300e1d737 [bug] Increase SRD target by change_fee (Murch)

Pull request description:

  I discovered via fuzzing of another coin selection approach that at extremely high feerates SRD may find input sets that lead to transactions without change outputs. This is an unintended outcome since SRD is meant to always produce a transaction with a change output—we use other algorithms to specifically search for changeless solutions.

  The issue occurs when the flat allowance of 50,000 ṩ for change is insufficient to pay for the creation of a change output with a non-dust amount, at and above 1,613 ṩ/vB. Increasing the change budget by `change_fee` makes SRD behave as expected at any feerates.

  Note: The intermittent failures of `test/functional/interface_usdt_mempool.py` are a known issue: https://github.com/bitcoin/bitcoin/issues/27380

ACKs for top commit:
  achow101:
    ACK 1771daa815ec014276cfcb30c934b0eaff4d72bf
  S3RK:
    ACK 1771daa815ec014276cfcb30c934b0eaff4d72bf

Tree-SHA512: 3f36a3e317ef0a711d0e409069c05032bff1d45403023f3728bf73dfd55ddd9e0dc2a9969d4d69fe0a426807ebb0bed1f54abfc05581409bfe42c327acf766d4

2023-06-23 16:57:11 -04:00

fuzz

Merge bitcoin/bitcoin#27846 : [coinselection] Increase SRD target by change_fee

2023-06-23 16:57:11 -04:00

coinselector_tests.cpp

Merge bitcoin/bitcoin#27846 : [coinselection] Increase SRD target by change_fee

2023-06-23 16:57:11 -04:00

db_tests.cpp

test: Kill BOOST_ASSERT

2023-06-14 16:00:27 +01:00

feebumper_tests.cpp

test: Remove unused txmempool include from tests