Andrew Chow e191fac4f3

Merge bitcoin/bitcoin#25922: wallet: trigger MaybeResendWalletTxs() every minute ...

5ef8c2c9fc4ebce6cbfea6a55a89a0ab7ee98a1a test: fix typo for MaybeResendWalletTxs (stickies-v)
fbba4a131647c991afc53b6a3dfb9721f5c430b2 wallet: trigger MaybeResendWalletTxs() every minute (stickies-v)

Pull request description:

  ResendWalletTransactions() only executes every [12-36h (24h average)](1420547ec3/src/wallet/wallet.cpp (L1947)). Triggering it every second is excessive, once per minute should be plenty.

  The goal of this PR is to reduce the amount of (unnecessary) schedule executions by ~60x without meaningfully altering transaction rebroadcast logic/assumptions which would require more significant review.

ACKs for top commit:
  achow101:
    ACK 5ef8c2c9fc4ebce6cbfea6a55a89a0ab7ee98a1a
  1440000bytes:
    ACK 5ef8c2c9fc

Tree-SHA512: 4a077e3579b289c11c347eaa0d3601ef2dbb9fee66ab918d56b4a0c2e08222560a0e6be295297a74831836e001a997ecc143adb0c132faaba96a669dac1cd9e6

2022-08-26 17:11:17 -04:00

..

rpc

scripted-diff: rpc: fix rescan RPC name (s/rescanwallet/rescanblockchain/)

2022-08-24 23:26:33 +02:00

test

Merge bitcoin/bitcoin#25647: wallet: return change from SelectionResult

2022-08-22 12:42:36 -04:00

bdb.cpp

refactor: Make const refs vars where applicable

2022-07-27 13:27:57 +02:00

bdb.h

scripted-diff: replace non-standard fixed width integer types (u_int... -> uint`...)

2022-05-12 15:44:24 +02:00

coincontrol.cpp

…

coincontrol.h

scripted-diff: rename fAllowOtherInputs -> m_allow_other_inputs

2022-06-19 20:32:51 -03:00

coinselection.cpp

wallet: use GetChange() when computing waste

2022-08-15 09:35:20 +02:00

coinselection.h

wallet: use GetChange() when computing waste

2022-08-15 09:35:20 +02:00

context.cpp

refactor: use C++11 default initializers

2022-05-17 17:18:58 +01:00

context.h

…

crypter.cpp

…

crypter.h

…

db.cpp

Replace use of ArgsManager with DatabaseOptions

2022-03-16 08:26:28 +01:00

db.h

Replace use of ArgsManager with DatabaseOptions

2022-03-16 08:26:28 +01:00

dump.cpp

Use HashWriter where possible

2022-07-20 15:34:36 +02:00

dump.h

Replace use of ArgsManager with DatabaseOptions

2022-03-16 08:26:28 +01:00

external_signer_scriptpubkeyman.cpp

GetExternalSigner(): fail if multiple signers are found

2022-06-09 20:34:46 +02:00

external_signer_scriptpubkeyman.h

…

feebumper.cpp

Merge bitcoin/bitcoin#25775: docs: remove non-signaling mentions of BIP125

2022-08-22 10:35:26 +01:00

feebumper.h

bumpfee: be able to bump fee of a tx with external inputs

2022-08-19 11:27:01 -04:00

fees.cpp

Remove ::dustRelayFee

2022-08-02 15:26:49 +02:00

fees.h

…

init.cpp

scripted-diff: Avoid incompatibility with CMake AUTOUIC feature

2022-06-14 10:38:51 +02:00

interfaces.cpp

bumpfee: be able to bump fee of a tx with external inputs

2022-08-19 11:27:01 -04:00

ismine.h

…

load.cpp

wallet: trigger MaybeResendWalletTxs() every minute

2022-08-25 14:29:25 +01:00

load.h

…

receive.cpp

Merge bitcoin/bitcoin#25707: refactor: Make const references to avoid unnecessarily copying objects and enable two clang-tidy checks

2022-08-19 17:11:06 +02:00

receive.h

Merge bitcoin/bitcoin#25504: RPC: allow to track coins by parent descriptors

2022-08-16 13:08:05 -04:00

salvage.cpp

Replace use of ArgsManager with DatabaseOptions

2022-03-16 08:26:28 +01:00

salvage.h

Replace use of ArgsManager with DatabaseOptions

2022-03-16 08:26:28 +01:00

scriptpubkeyman.cpp

Merge bitcoin/bitcoin#25707: refactor: Make const references to avoid unnecessarily copying objects and enable two clang-tidy checks

2022-08-19 17:11:06 +02:00

scriptpubkeyman.h

Merge bitcoin/bitcoin#25656: refactor: wallet: return util::Result from GetReservedDestination methods

2022-08-10 14:19:17 +02:00

spend.cpp

Merge bitcoin/bitcoin#25647: wallet: return change from SelectionResult

2022-08-22 12:42:36 -04:00

spend.h

wallet: switch to new shuffle, erase, push_back

2022-08-10 15:19:31 +02:00

sqlite.cpp

scripted-diff: Convert global Mutexes to GlobalMutexes

2022-05-21 01:23:23 +10:00

sqlite.h

Replace use of ArgsManager with DatabaseOptions

2022-03-16 08:26:28 +01:00

transaction.cpp

…

transaction.h

…

wallet.cpp

Wallet::SetMinVersion - Log the new minversion

2022-08-25 17:58:19 +00:00

wallet.h

Merge bitcoin/bitcoin#25775: docs: remove non-signaling mentions of BIP125

2022-08-22 10:35:26 +01:00

walletdb.cpp

refactor: Make const refs vars where applicable

2022-07-27 13:27:57 +02:00

walletdb.h

walletdb: Create a mock database of specific type

2022-05-10 11:54:02 -04:00

wallettool.cpp

Merge bitcoin/bitcoin#25784: Wallet: Document expectations for AddWalletFlags (now InitWalletFlags) correctly

2022-08-19 12:12:27 -04:00

wallettool.h

…

walletutil.cpp

…

walletutil.h

…