Wladimir J. van der Laan 4dd2e5255a

Merge #18946: rpcwallet: Replace boost::optional<T>::emplace with simple assignment of T{} ...

fa1f840596554ed264d11ee3b3643bf99eb57eb5 rpcwallet: Replace pwallet-> with wallet. (MarcoFalke)
fa182a8794cbf9be1aa91d1d75e65bc7800156bc rpcwallet: Replace boost::optional<T>::emplace with simple assignment of T{} (MarcoFalke)

Pull request description:

  Closes #18943

ACKs for top commit:
  laanwj:
    ACK fa1f840596554ed264d11ee3b3643bf99eb57eb5
  ryanofsky:
    Code review ACK fa1f840596554ed264d11ee3b3643bf99eb57eb5 and thanks for using a standalone commit for the fix
  promag:
    Code review ACK fa1f840596554ed264d11ee3b3643bf99eb57eb5.
  hebasto:
    ACK fa1f840596554ed264d11ee3b3643bf99eb57eb5, tested on Linux Mint 19.3.

Tree-SHA512: 0838485d1f93f737ce5bf12740669dcafeebb78dbc3fa15dbcc511edce64bf024f60f0497a04149a1e799d893d57b0c9ffe442020c1b9cfc3c69db731f50e712

2020-05-14 19:26:17 +02:00

..

test

test: Fix outstanding -Wsign-compare errors

2020-05-08 11:18:43 -07:00

coincontrol.cpp

scripted-diff: Bump copyright of files changed in 2019

2019-12-30 10:42:20 +13:00

coincontrol.h

refactor: Nuke coincontrol circular dependency

2019-11-23 08:30:03 +02:00

coinselection.cpp

bnb: exit selection when best_waste is 0

2020-03-04 16:35:15 -05:00

coinselection.h

…

crypter.cpp

Fix occurences of c_str() used with size() to data()

2019-10-28 13:41:45 +01:00

crypter.h

scripted-diff: Bump copyright of files changed in 2019

2019-12-30 10:42:20 +13:00

db.cpp

refactor: Add BerkeleyDatabaseVersion() function

2020-05-11 20:42:55 +03:00

db.h

build: Enable -Wsuggest-override

2020-05-12 18:03:39 +03:00

feebumper.cpp

wallet: Remove trailing whitespace from potential translation strings

2020-05-01 07:41:32 -04:00

feebumper.h

wallet: Avoid translating RPC errors when creating txs

2020-05-01 07:39:06 -04:00

fees.cpp

Remove unused includes

2019-10-15 22:56:43 +00:00

fees.h

…

init.cpp

Make InitError bilingual

2020-05-05 04:46:04 +03:00

ismine.h

scripted-diff: Bump copyright of files changed in 2019

2019-12-30 10:42:20 +13:00

load.cpp

gui: Do not translate InitWarning messages in debug.log

2020-05-10 18:01:28 +03:00

load.h

…

rpcdump.cpp

Remove CWalletTx merging logic from AddToWallet

2020-05-01 05:59:09 -05:00

rpcwallet.cpp

Merge #18946: rpcwallet: Replace boost::optional<T>::emplace with simple assignment of T{}

2020-05-14 19:26:17 +02:00

rpcwallet.h

scripted-diff: Bump copyright headers

2020-04-16 13:33:09 -04:00

scriptpubkeyman.cpp

wallet: Avoid translating RPC errors when loading wallets

2020-05-01 07:39:00 -04:00

scriptpubkeyman.h

Merge #18782: wallet: Make sure no DescriptorScriptPubKeyMan or WalletDescriptor members are left uninitialized after construction

2020-05-05 15:56:04 +12:00

wallet.cpp

Merge #18853: wallet: Fix typo in assert that is compile-time true

2020-05-06 14:19:41 +02:00

wallet.h

Merge #18814: rpc: Relock wallet only if most recent callback

2020-05-13 17:36:06 +08:00

walletdb.cpp

Merge #9381: Remove CWalletTx merging logic from AddToWallet

2020-05-06 11:36:32 +12:00

walletdb.h

Merge #9381: Remove CWalletTx merging logic from AddToWallet

2020-05-06 11:36:32 +12:00

wallettool.cpp

wallet: Report full error message in wallettool

2020-05-01 07:39:35 -04:00

wallettool.h

scripted-diff: Bump copyright of files changed in 2019

2019-12-30 10:42:20 +13:00

walletutil.cpp

Correctly check for default wallet

2020-04-23 13:59:48 -04:00

walletutil.h

wallet: Make sure no WalletDescriptor members are uninitialized after construction

2020-04-27 14:20:26 +00:00