cryptogera/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-02-02 03:31:09 +00:00
Code Issues Packages Projects Releases Wiki Activity
bitcoin/src
History
fanquake 143ace65db
Merge bitcoin/bitcoin#28890: rpc: Remove deprecated -rpcserialversion 
fa46cc22bc696e6845915ae91d6b68e36bf4c242 Remove deprecated -rpcserialversion (MarcoFalke)

Pull request description:

  The flag is problematic for many reasons:

  * It is deprecated
  * It is a global flag, requiring a restart to change, as opposed to a flag that can be set on each RPC invocation
  * It may be hidden in config files by accident, hard to debug, causing LND crashes and bugs, see https://github.com/bitcoin/bitcoin/issues/28730#issuecomment-1780940868
  * It makes performance improvements harder to implement: https://github.com/bitcoin/bitcoin/pull/17529#issuecomment-556082818

  Fix all issues by removing it.

  If there is a use-case, likely a per-RPC flag can be added, if needed.

ACKs for top commit:
  ajtowns:
    crACK fa46cc22bc696e6845915ae91d6b68e36bf4c242
  TheCharlatan:
    lgtm ACK fa46cc22bc696e6845915ae91d6b68e36bf4c242

Tree-SHA512: 96ba1c60356ce93954fe5c2a59045771c6d1516ad0d9dc436ef1800a1f1b0153f0d5fb78ca99d53ad54ba25fbce36962bdf1d4325aceedfc8154a61347a6a915
2024-01-05 10:42:10 +00:00
..
bench
Merge bitcoin/bitcoin#26684: bench: add readblock benchmark
2024-01-02 11:12:32 -05:00
common
ArgsManager: return path by value from GetBlocksDirPath()
2023-12-11 17:42:17 +01:00
compat
Remove __cplusplus from compat/assumptions.h
2023-10-04 11:11:37 +02:00
config
…
consensus
Include version.h in fewer places
2023-11-16 11:36:22 +10:00
crc32c
…
crypto
Add ability to specify SHA256 implementation for benchmark purposes
2023-09-20 21:11:55 +01:00
index
refactor: Remove calls to StartShutdown from KernelNotifications
2023-12-04 15:39:15 -04:00
init
refactor: Add InitContext function to initialize NodeContext with global pointers
2023-12-04 15:39:15 -04:00
interfaces
Merge bitcoin/bitcoin#28890: rpc: Remove deprecated -rpcserialversion
2024-01-05 10:42:10 +00:00
ipc
refactor: Move system from util to common library
2023-05-20 12:08:13 +02:00
kernel
Merge bitcoin/bitcoin#29013: test: doc: follow-up #28368
2024-01-03 11:23:27 +00:00
leveldb
…
logging
…
minisketch
…
node
Merge bitcoin/bitcoin#28890: rpc: Remove deprecated -rpcserialversion
2024-01-05 10:42:10 +00:00
policy
Merge bitcoin/bitcoin#29013: test: doc: follow-up #28368
2024-01-03 11:23:27 +00:00
primitives
Merge bitcoin/bitcoin#28766: Improve peformance of CTransaction::HasWitness (28107 follow-up)
2023-11-28 08:44:41 -05:00
qt
refactor: share and use GenerateRandomKey helper
2023-12-23 13:26:00 +01:00
rpc
Merge bitcoin/bitcoin#28890: rpc: Remove deprecated -rpcserialversion
2024-01-05 10:42:10 +00:00
script
wallet: fix key parsing check for miniscript expressions in ParseScript
2023-12-08 06:54:00 -03:00
secp256k1
Update secp256k1 subtree to latest master
2024-01-04 14:40:28 +00:00
support
pool: make sure PoolAllocator uses the correct alignment
2023-11-19 18:43:29 +01:00
test
Merge bitcoin/bitcoin#28832: fuzz: rule-out too deep derivation paths in descriptor parsing targets
2024-01-04 18:10:22 -05:00
univalue
Remove unused raw-pointer read helper from univalue
2023-07-27 14:24:52 +02:00
util
Merge bitcoin/bitcoin#29040: refactor: Remove pre-C++20 code, fs::path cleanup
2023-12-14 16:46:54 -05:00
wallet
Merge bitcoin/bitcoin#28890: rpc: Remove deprecated -rpcserialversion
2024-01-05 10:42:10 +00:00
zmq
Remove deprecated -rpcserialversion
2023-12-11 18:22:13 +01:00
.bear-tidy-config
tidy: modernize-use-emplace
2023-10-12 11:27:19 +02:00
.clang-format
refactor: Print verbose serialize compiler error messages
2023-12-15 15:20:54 +01:00
.clang-tidy
refactor: Fix bugprone-string-constructor warning
2023-10-30 14:59:17 +01:00
addrdb.cpp
build: Bump minimum supported Clang to clang-13
2023-10-24 18:52:00 +02:00
addrdb.h
Use serialization parameters for CAddress serialization
2023-09-05 10:13:25 +02:00
addresstype.cpp
Add PubKeyDestination for P2PK scripts
2023-09-12 12:14:31 -04:00
addresstype.h
bugfix: Mark CNoDestination and PubKeyDestination constructor explicit
2023-10-25 22:46:55 +02:00
addrman_impl.h
net: Optionally include terrible addresses in GetAddr results
2023-10-04 18:08:49 +02:00
addrman.cpp
Merge bitcoin/bitcoin#27581: net: Continuous ASMap health check
2023-12-06 11:22:42 -05:00
addrman.h
Merge bitcoin/bitcoin#27581: net: Continuous ASMap health check
2023-12-06 11:22:42 -05:00
arith_uint256.cpp
refactor: Remove unused and fragile string interface from arith_uint256
2023-11-21 17:37:25 +01:00
arith_uint256.h
refactor: Remove unused and fragile string interface from arith_uint256
2023-11-21 17:37:25 +01:00
attributes.h
…
banman.cpp
Merge bitcoin/bitcoin#24097: Replace RecursiveMutex m_cs_banned with Mutex, and rename it
2023-11-02 14:09:27 -04:00
banman.h
Merge bitcoin/bitcoin#24097: Replace RecursiveMutex m_cs_banned with Mutex, and rename it
2023-11-02 14:09:27 -04:00
base58.cpp
…
base58.h
…
bech32.cpp
…
bech32.h
…
bip324.cpp
net: merge V2Transport constructors, move key gen
2023-09-10 16:11:52 -04:00
bip324.h
net: merge V2Transport constructors, move key gen
2023-09-10 16:11:52 -04:00
bitcoin-chainstate.cpp
refactor: Add NodeContext::shutdown member
2023-12-04 15:39:15 -04:00
bitcoin-cli-res.rc
…
bitcoin-cli.cpp
refactor: Move system from util to common library
2023-05-20 12:08:13 +02:00
bitcoin-tx-res.rc
…
bitcoin-tx.cpp
doc: Update bitcoin-tx replaceable documentation
2023-12-11 13:08:46 -05:00
bitcoin-util-res.rc
…
bitcoin-util.cpp
Include version.h in fewer places
2023-11-16 11:36:22 +10:00
bitcoin-wallet-res.rc
…
bitcoin-wallet.cpp
refactor: Move system from util to common library
2023-05-20 12:08:13 +02:00
bitcoind-res.rc
…
bitcoind.cpp
Get rid of shutdown.cpp/shutdown.h, use SignalInterrupt directly
2023-12-04 15:39:15 -04:00
blockencodings.cpp
serialize: Drop useless version param from GetSerializeSize()
2023-11-16 11:14:13 +10:00
blockencodings.h
Use ParamsWrapper for witness serialization
2023-11-14 08:45:30 +10:00
blockfilter.cpp
refactor: SpanReader without nVersion
2023-11-28 12:42:07 +01:00
blockfilter.h
Remove unused includes from blockfilter.h
2023-08-17 18:28:15 +02:00
chain.cpp
…
chain.h
refactor: Remove CBlockFileInfo::SetNull
2023-10-20 16:29:02 +02:00
chainparams.cpp
test: Throw error when -signetchallenge is non-hex
2023-05-25 19:24:05 +02:00
chainparams.h
test: Throw error when -signetchallenge is non-hex
2023-05-25 19:24:05 +02:00
chainparamsbase.cpp
refactor: Use ChainType enum exhaustively
2023-05-10 10:39:58 +02:00
chainparamsbase.h
refactor: Use ChainType enum exhaustively
2023-05-10 10:39:58 +02:00
chainparamsseeds.h
…
checkqueue.h
refactor: Make CCheckQueue non-copyable and non-movable explicitly
2023-10-03 10:52:17 +01:00
clientversion.cpp
…
clientversion.h
…
coins.cpp
Use Txid in COutpoint
2023-11-21 13:15:44 +00:00
coins.h
Merge bitcoin/bitcoin#28922: Use Txid in COutpoint
2023-11-24 14:41:58 +00:00
compressor.cpp
Clean up things that include script/standard.h
2023-08-14 17:38:27 -04:00
compressor.h
…
core_io.h
Remove deprecated -rpcserialversion
2023-12-11 18:22:13 +01:00
core_memusage.h
…
core_read.cpp
Include version.h in fewer places
2023-11-16 11:36:22 +10:00
core_write.cpp
Remove deprecated -rpcserialversion
2023-12-11 18:22:13 +01:00
cuckoocache.h
…
dbwrapper.cpp
dbwrapper: Use DataStream for batch operations
2023-09-12 12:07:39 +02:00
dbwrapper.h
dbwrapper: Use DataStream for batch operations
2023-09-12 12:07:39 +02:00
deploymentinfo.cpp
…
deploymentinfo.h
…
deploymentstatus.cpp
…
deploymentstatus.h
…
dummywallet.cpp
…
external_signer.cpp
Remove unused version.h include
2023-11-30 11:28:19 +01:00
external_signer.h
refactor: Move system from util to common library
2023-05-20 12:08:13 +02:00
flatfile.cpp
…
flatfile.h
…
hash.cpp
…
hash.h
Include version.h in fewer places
2023-11-16 11:36:22 +10:00
headerssync.cpp
tidy: modernize-use-emplace
2023-10-12 11:27:19 +02:00
headerssync.h
…
httprpc.cpp
refactor: drop protocol.h include header in rpc/util.h
2023-09-19 15:54:17 -06:00
httprpc.h
…
httpserver.cpp
refactor: Remove call to ShutdownRequested from HTTPRequest
2023-12-04 15:39:15 -04:00
httpserver.h
refactor: Remove call to ShutdownRequested from HTTPRequest
2023-12-04 15:39:15 -04:00
i2p.cpp
Merge bitcoin/bitcoin#28695: net: Sanity check private keys received from SAM proxy
2023-10-30 14:44:40 +01:00
i2p.h
i2p: destroy the session if we get an unexpected error from the I2P router
2023-10-05 14:11:13 +02:00
indirectmap.h
…
init.cpp
Merge bitcoin/bitcoin#28890: rpc: Remove deprecated -rpcserialversion
2024-01-05 10:42:10 +00:00
init.h
Get rid of shutdown.cpp/shutdown.h, use SignalInterrupt directly
2023-12-04 15:39:15 -04:00
key_io.cpp
Merge bitcoin/bitcoin#28246: wallet: Use CTxDestination in CRecipient instead of just scriptPubKey
2023-09-19 16:48:43 +00:00
key_io.h
Clean up things that include script/standard.h
2023-08-14 17:38:27 -04:00
key.cpp
refactor: share and use GenerateRandomKey helper
2023-12-23 13:26:00 +01:00
key.h
refactor: share and use GenerateRandomKey helper
2023-12-23 13:26:00 +01:00
logging.cpp
[log] add category TXPACKAGES for orphanage and package relay
2023-08-29 16:41:22 +01:00
logging.h
[log] add category TXPACKAGES for orphanage and package relay
2023-08-29 16:41:22 +01:00
Makefile.am
Merge bitcoin/bitcoin#28051: Get rid of shutdown.cpp/shutdown.h, use SignalInterrupt directly
2023-12-14 15:14:00 -05:00
Makefile.bench.include
Merge bitcoin/bitcoin#26684: bench: add readblock benchmark
2024-01-02 11:12:32 -05:00
Makefile.crc32c.include
…
Makefile.leveldb.include
…
Makefile.minisketch.include
…
Makefile.qt_locale.include
qt: Translation updates from Transifex
2023-09-01 07:39:00 +01:00
Makefile.qt.include
Merge bitcoin/bitcoin#22764: build: Include qt sources for parsing with extract_strings.py
2023-10-19 13:25:49 +01:00
Makefile.qttest.include
…
Makefile.test_fuzz.include
fuzz: move MockedDescriptorConverter to fuzz/util
2023-11-20 15:57:50 -03:00
Makefile.test_util.include
Merge bitcoin/bitcoin#27425: test: move remaining rand code from util/setup_common to util/random
2023-07-19 10:26:11 +01:00
Makefile.test.include
fuzz: add target for DescriptorScriptPubKeyMan
2023-11-20 15:57:56 -03:00
Makefile.univalue.include
…
mapport.cpp
Remove the syscall sandbox
2023-06-16 10:38:19 +01:00
mapport.h
…
memusage.h
add std::list to memusage
2023-09-13 11:37:45 +01:00
merkleblock.cpp
refactor: Use Txid in CMerkleBlock
2023-11-28 17:49:41 +01:00
merkleblock.h
refactor: Use Txid in CMerkleBlock
2023-11-28 17:49:41 +01:00
net_permissions.cpp
Merge bitcoin/bitcoin#26078: p2p: return CSubNet in LookupSubNet
2023-10-26 14:29:47 -04:00
net_permissions.h
…
net_processing.cpp
fuzz: Improve fuzzing stability for txorphan harness
2023-12-08 13:14:46 +00:00
net_processing.h
refactor: P2P transport without serialize version and type
2023-11-23 13:43:39 +01:00
net_types.cpp
p2p: return CSubNet in LookupSubNet
2023-05-30 16:27:21 -03:00
net_types.h
…
net.cpp
refactor: share and use GenerateRandomKey helper
2023-12-23 13:26:00 +01:00
net.h
Merge bitcoin/bitcoin#27581: net: Continuous ASMap health check
2023-12-06 11:22:42 -05:00
netaddress.cpp
Inline short, often-called, rarely-changed basic CNetAddr getters
2023-07-19 12:43:05 -06:00
netaddress.h
net: put CJDNS prefix byte in a constant
2023-10-05 15:10:32 +02:00
netbase.cpp
Merge bitcoin/bitcoin#28649: Do the SOCKS5 handshake reliably
2023-11-07 14:11:58 -05:00
netbase.h
Merge bitcoin/bitcoin#28649: Do the SOCKS5 handshake reliably
2023-11-07 14:11:58 -05:00
netgroup.cpp
Merge bitcoin/bitcoin#27581: net: Continuous ASMap health check
2023-12-06 11:22:42 -05:00
netgroup.h
net: Add continuous ASMap health check logging
2023-12-02 22:03:08 +01:00
netmessagemaker.h
refactor: NetMsg::Make() without nVersion
2023-11-20 14:02:27 +01:00
noui.cpp
…
noui.h
…
outputtype.cpp
Clean up things that include script/standard.h
2023-08-14 17:38:27 -04:00
outputtype.h
Move CTxDestination to its own file
2023-08-14 17:38:27 -04:00
pow.cpp
…
pow.h
…
prevector.h
…
protocol.cpp
refactor: Initialize magic bytes in constructor initializer
2023-11-13 14:17:59 +01:00
protocol.h
scripted-diff: Use ser params operator
2023-10-13 10:30:49 +02:00
psbt.cpp
Remove unused version.h include
2023-11-30 11:28:19 +01:00
psbt.h
refactor: SpanReader without nVersion
2023-11-28 12:42:07 +01:00
pubkey.cpp
pubkey: introduce a GetEvenCorrespondingCPubKey helper
2023-10-08 02:43:19 +02:00
pubkey.h
pubkey: introduce a GetEvenCorrespondingCPubKey helper
2023-10-08 02:43:19 +02:00
random.cpp
Merge bitcoin/bitcoin#26839: Add support for RNDR/RNDRRS for AArch64 on Linux
2023-11-07 15:00:38 -05:00
random.h
crypto: refactor ChaCha20 classes to use Span<std::byte> interface
2023-08-17 15:26:34 -04:00
randomenv.cpp
[refactor] Remove compat.h from kernel headers
2023-09-12 22:51:48 +02:00
randomenv.h
…
rest.cpp
Merge bitcoin/bitcoin#28890: rpc: Remove deprecated -rpcserialversion
2024-01-05 10:42:10 +00:00
rest.h
…
reverse_iterator.h
…
scheduler.cpp
Remove the syscall sandbox
2023-06-16 10:38:19 +01:00
scheduler.h
…
serialize.h
Allow std::byte C-style array serialization
2023-12-15 15:21:22 +01:00
signet.cpp
refactor: SpanReader without nVersion
2023-11-28 12:42:07 +01:00
signet.h
…
span.h
refactor: Print verbose serialize compiler error messages
2023-12-15 15:20:54 +01:00
streams.cpp
streams: Teach AutoFile how to XOR
2023-07-19 18:12:42 +02:00
streams.h
Remove unused CDataStream
2023-11-30 11:27:54 +01:00
sync.cpp
…
sync.h
Merge bitcoin/bitcoin#27116: doc: clarify that LOCK() internally checks whether the mutex is held
2023-10-26 15:02:13 -04:00
threadsafety.h
…
timedata.cpp
…
timedata.h
…
tinyformat.h
…
torcontrol.cpp
doc: fix typos
2023-11-07 10:21:51 +09:00
torcontrol.h
doc, refactor: Changing -torcontrol help to specify that a default port is used
2023-08-17 23:58:47 -05:00
txdb.cpp
Merge bitcoin/bitcoin#28195: blockstorage: Drop legacy -txindex check
2023-09-05 11:37:35 +01:00
txdb.h
move-only: Move CBlockTreeDB to node/blockstorage
2023-08-01 15:27:33 +02:00
txmempool.cpp
wallet, mempool: propagete checkChainLimits error message to wallet
2023-12-17 21:13:44 +01:00
txmempool.h
[doc]: add doxygen return comment for CheckPackageLimits
2023-12-19 17:12:45 +01:00
txorphanage.cpp
fuzz: Improve fuzzing stability for txorphan harness
2023-12-08 13:14:46 +00:00
txorphanage.h
fuzz: Improve fuzzing stability for txorphan harness
2023-12-08 13:14:46 +00:00
txrequest.cpp
refactor: modernize-use-default-member-init for bit-fields (C++20)
2023-12-07 11:06:01 +01:00
txrequest.h
…
uint256.cpp
…
uint256.h
Merge bitcoin/bitcoin#27927: util: Allow std::byte and char Span serialization
2023-06-28 15:12:12 -04:00
undo.h
Include version.h in fewer places
2023-11-16 11:36:22 +10:00
validation.cpp
wallet, mempool: propagete checkChainLimits error message to wallet
2023-12-17 21:13:44 +01:00
validation.h
Merge bitcoin/bitcoin#26762: bugfix: Make CCheckQueue RAII-styled (attempt 2)
2023-11-30 14:28:46 -05:00
validationinterface.cpp
CValidationInterface: modify the parameter of TransactionAddedToMempool
2023-11-22 11:48:21 +01:00
validationinterface.h
doc: fix typo and update incorrect comment
2024-01-02 12:40:11 +01:00
versionbits.cpp
…
versionbits.h
…
walletinitinterface.h
…
warnings.cpp
refactor: Move system from util to common library
2023-05-20 12:08:13 +02:00
warnings.h
…