Ava Chow 87c9ebd889

Merge bitcoin/bitcoin#31563: rpc: Extend scope of validation mutex in generateblock ...

fa63b8232f38e78d3c6413fa7d51809f376de75c test: generateblocks called by multiple threads (MarcoFalke)
fa62c8b1f04a5386ffa171aeff713d55bd874cbe rpc: Extend scope of validation mutex in generateblock (MarcoFalke)

Pull request description:

  The mutex (required by TestBlockValidity) must be held after creating the block, until TestBlockValidity is called. Otherwise, it is possible that the chain advances in the meantime and leads to a crash in TestBlockValidity: `Assertion failed: pindexPrev && pindexPrev == chainstate.m_chain.Tip() (validation.cpp: TestBlockValidity: 4338)`

  Fixes #31562

ACKs for top commit:
  davidgumberg:
    reACK fa63b8232f
  achow101:
    ACK fa63b8232f38e78d3c6413fa7d51809f376de75c
  ismaelsadeeq:
    re-ACK fa63b8232f38e78d3c6413fa7d51809f376de75c
  mzumsande:
    utACK fa63b8232f38e78d3c6413fa7d51809f376de75c

Tree-SHA512: 3dfda1192af52546ab11fbffe44af8713073763863f4a63fbcdbdf95b1c6cbeb003dc4b8b29e7ec67362238ad15e07d8f6855832a0c68dc5370254f8cbf9445c

2024-12-30 14:49:21 -05:00

..

blockchain.cpp

Merge bitcoin/bitcoin#31531: rpc: Add signet_challenge field to getblockchaininfo and getmininginfo

2024-12-30 13:31:08 -05:00

blockchain.h

Replace RPCNotifyBlockChange with waitTipChanged()

2024-09-17 09:27:44 +02:00

client.cpp

Merge bitcoin/bitcoin#30708: rpc: add getdescriptoractivity

2024-11-27 12:23:35 -05:00

client.h

…

external_signer.cpp

scripted-diff: drop config/ subdir for bitcoin-config.h, rename to bitcoin-build-config.h

2024-10-10 12:22:12 +02:00

fees.cpp

[rpc, fees]: add more detail on the fee estimation modes

2024-08-02 15:40:43 +01:00

mempool.cpp

Merge bitcoin/bitcoin#31096: Package validation: accept packages of size 1

2024-12-03 17:46:23 -05:00

mempool.h

…

mining.cpp

Merge bitcoin/bitcoin#31563: rpc: Extend scope of validation mutex in generateblock

2024-12-30 14:49:21 -05:00

mining.h

…

net.cpp

scripted-diff: get rid of remaining "command" terminology in protocol.{h,cpp}

2024-10-26 23:44:15 +02:00

node.cpp

scripted-diff: drop config/ subdir for bitcoin-config.h, rename to bitcoin-build-config.h

2024-10-10 12:22:12 +02:00

output_script.cpp

refactor: Fix remaining clang-tidy performance-inefficient-vector errors

2024-11-25 20:09:44 +01:00

protocol.h

rpc: clarify ALREADY_IN_CHAIN rpc errors

2024-08-05 15:45:58 +01:00

rawtransaction_util.cpp

Merge bitcoin/bitcoin#28307: rpc, wallet: fix incorrect segwit redeem script size limit

2024-06-04 21:39:49 -04:00

rawtransaction_util.h

rpc: bugfix, incorrect segwit redeem script size used in signrawtransactionwithkey

2024-05-03 14:20:45 -03:00

rawtransaction.cpp

Merge bitcoin/bitcoin#30708: rpc: add getdescriptoractivity

2024-11-27 12:23:35 -05:00

register.h

scripted-diff: drop config/ subdir for bitcoin-config.h, rename to bitcoin-build-config.h

2024-10-10 12:22:12 +02:00

request.cpp

args: Support -norpccookiefile for bitcoind and bitcoin-cli

2024-12-03 10:38:21 +01:00

request.h

Merge bitcoin/bitcoin#28167: init: Add option for rpccookie permissions (replace 26088)

2024-06-27 17:35:08 -04:00

server_util.cpp

Introduce Mining interface

2024-06-18 18:47:51 +02:00

server_util.h

Introduce Mining interface

2024-06-18 18:47:51 +02:00

server.cpp

scripted-diff: Rename PACKAGE_* variables to CLIENT_*

2024-10-28 12:36:19 +00:00

server.h

refactor: Split up NodeContext shutdown_signal and shutdown_request

2024-10-01 09:10:54 +02:00

signmessage.cpp

util: move util/message to common/signmessage

2024-05-16 11:16:08 -04:00

txoutproof.cpp

rpc: Improve gettxoutproof error when only header is available.

2024-09-13 10:50:49 -04:00

util.cpp

Merge bitcoin/bitcoin#30708: rpc: add getdescriptoractivity

2024-11-27 12:23:35 -05:00

util.h

Merge bitcoin/bitcoin#30708: rpc: add getdescriptoractivity

2024-11-27 12:23:35 -05:00