cryptogera/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-02-03 04:01:21 +00:00
Code Issues Packages Projects Releases Wiki Activity
bitcoin/src/interfaces
History
Wladimir J. van der Laan 8a191148db
Merge #17154: wallet: Remove return value from CommitTransaction 
9e95931865186d7a9a6dc54b64bd96507e9fea4b [wallet] Remove `state` argument from CWallet::CommitTransaction (John Newbery)
d1734f9a3b138ab046f38ee44a09bc3847bf938a [wallet] Remove return value from CommitTransaction() (John Newbery)
b6f486a02b463ffeaf82ec11fc6f74f439c037ae [wallet] Add doxygen comment to CWallet::CommitTransaction() (John Newbery)
8bba91b22d22a8dfea7c947b542b1022bfc1c0ea [wallet] Fix whitespace in CWallet::CommitTransaction() (John Newbery)

Pull request description:

  `CommitTransaction()` returns a bool to indicate success, but since commit
  b3a7410 (#9302) it only returns true, even if the transaction was not
  successfully broadcast. This commit changes CommitTransaction() to return
  void.

  All dead code in `if (!CommitTransaction())` branches has been removed.

  Two additional commits fix up the idiosyncratic whitespace in `CommitTransaction` and add a doxygen comment for the function.

ACKs for top commit:
  laanwj:
    ACK 9e95931865186d7a9a6dc54b64bd96507e9fea4b

Tree-SHA512: a55a2c20369a45222fc0e02d0891495655a926e71c4f52cb72624768dd7b9c1dca716ea67d38420afb90f40c6e0fd448caa60c18fd693bb10ecb110b641820e6
2019-10-24 10:16:12 +02:00
..
chain.cpp
Remove unused includes
2019-10-15 22:56:43 +00:00
chain.h
[wallet] Remove package limit config access from wallet
2019-10-14 13:32:41 -04:00
handler.cpp
scripted-diff: Move util files to separate directory.
2018-11-04 22:46:07 -08:00
handler.h
scripted-diff: Avoid interface keyword to fix windows gitian build
2018-04-07 03:42:02 -04:00
node.cpp
Merge #17070: wallet: Avoid showing GUI popups on RPC errors
2019-10-21 13:48:27 +02:00
node.h
wallet: Avoid showing GUI popups on RPC errors
2019-10-08 13:02:14 -04:00
README.md
Suggested interfaces::Chain cleanups from #15288
2019-03-04 15:57:58 -05:00
wallet.cpp
Merge #17154: wallet: Remove return value from CommitTransaction
2019-10-24 10:16:12 +02:00
wallet.h
[wallet] Remove return value from CommitTransaction()
2019-10-18 09:26:32 -04:00

README.md

Internal c++ interfaces

The following interfaces are defined here:

  • Chain — used by wallet to access blockchain and mempool state. Added in #14437, #14711, #15288, and #10973.

  • ChainClient — used by node to start & stop Chain clients. Added in #14437.

  • Node — used by GUI to start & stop bitcoin node. Added in #10244.

  • Wallet — used by GUI to access wallets. Added in #10244.

  • Handler — returned by handleEvent methods on interfaces above and used to manage lifetimes of event handlers.

  • Init — used by multiprocess code to access interfaces above on startup. Added in #10102.

The interfaces above define boundaries between major components of bitcoin code (node, wallet, and gui), making it possible for them to run in different processes, and be tested, developed, and understood independently. These interfaces are not currently designed to be stable or to be used externally.