MarcoFalke be27048a18

Merge #13241: scripted-diff: Avoid temporary copies when looping over std::map ...

9b72c988a0 scripted-diff: Avoid temporary copies when looping over std::map (Ben Woosley)

Pull request description:

  The ::value_type of the std::map/std::multimap/std::unordered_map containers is
  std::pair<const Key, T>. Dropping the const results in an unnecessary copy,
  for example in C++11 range-based loops.

  For this I started with a more general scripted diff, then narrowed it down
  based on the inspection showing that all actual map/multimap/unordered_map
  variables used in loops start with m or have map in the name.

Tree-SHA512: b656d66b69ffa1eb954124aa8ae2bc5436ca50262abefa93bdda55cfcdaffc5ff90cd40539051a2bd06355ba69ddf245265cc8764eebff66d761b3aec06155a9

2018-06-15 12:32:39 -04:00

..

blockchain.cpp

expose CBlockIndex::nTx in getblock(header)

2018-06-13 10:20:50 -04:00

blockchain.h

Drop the chain argument to GetDifficulty

2018-05-20 22:19:42 -07:00

client.cpp

Merge #13060: [wallet] [rpc] Remove getlabeladdress RPC

2018-06-11 15:21:24 +02:00

client.h

Fix missing or inconsistent include guards

2018-03-22 16:23:04 +01:00

mining.cpp

Drop the chain argument to GetDifficulty

2018-05-20 22:19:42 -07:00

mining.h

scripted-diff: Replace #include "" with #include <> (ryanofsky)

2017-11-16 08:23:01 +13:00

misc.cpp

Make it clear which functions that are intended to be translation unit local

2018-05-03 21:47:40 +02:00

net.cpp

scripted-diff: Avoid temporary copies when looping over std::map

2018-06-11 13:12:55 -07:00

protocol.cpp

scripted-diff: Use UniValue.pushKV instead of push_back(Pair())

2018-02-10 10:05:07 -05:00

protocol.h

rpc: Move RPC_FORBIDDEN_BY_SAFE_MODE code to reserved section

2018-04-27 09:19:09 +02:00

rawtransaction.cpp

Merge #13269: refactoring: Drop UpdateTransaction in favor of UpdateInput

2018-06-05 19:06:16 +02:00

rawtransaction.h

Declare CMutableTransaction a struct in rawtransaction.h

2018-02-20 14:16:37 -08:00

register.h

Fix missing or inconsistent include guards

2018-03-22 16:23:04 +01:00

server.cpp

Merge #13116: Add Clang thread safety annotations for variables guarded by cs_{rpcWarmup,nTimeOffset,warnings}

2018-05-14 08:46:54 -04:00

server.h

Merge #12757: Clarify include guard naming convention

2018-04-01 18:30:21 -04:00

util.cpp

Merge #12542: Remove redundant includes. Conform to header include guidelines.

2018-03-16 16:59:27 -07:00

util.h

Remove redundant includes. Conform to header include guidelines.

2018-02-27 22:30:40 +01:00