Andrew Chow 606ce05ec2

Merge bitcoin/bitcoin#18554: wallet: ensure wallet files are not reused across chains ...

5f213213cb17429353ef7ec3e97b185af06d236f tests: add tests for cross-chain wallet use prevention (Seibart Nedor)
968765973b5bfde1ee4ad2fb5c19e24bce63ad0e wallet: ensure wallet files are not reused across chains (Seibart Nedor)

Pull request description:

  This implements a proposal in #12805 and is a rebase of #14533.

  This seems to be a working approach, but I'm not sure why the `p2p_segwit.py` functional test needed a change, so I'll look into it more.

ACKs for top commit:
  achow101:
    ACK 5f213213cb17429353ef7ec3e97b185af06d236f
  dongcarl:
    Code Review ACK 5f213213cb17429353ef7ec3e97b185af06d236f
  [deleted]:
    tACK 5f213213cb

Tree-SHA512: 2c934300f113e772fc31c16ef5588526300bbc36e4dcef7d77bd0760c5c8f0ec77f766b1bed5503eb0157fa26dc900ed54d2ad1b41863c1f736ce5c1f3b67bec

2022-04-28 15:59:47 -04:00

..

rpc

Merge bitcoin/bitcoin#24977: rpc: Explain active and internal in listdescriptors

2022-04-26 15:09:39 +01:00

test

Merge bitcoin/bitcoin#24644: wallet: add tracepoints and algorithm information to coin selection

2022-04-26 19:16:27 +01:00

bdb.cpp

scripted-diff: rename BytePtr to AsBytePtr

2022-04-26 09:41:45 +01:00

bdb.h

Replace use of ArgsManager with DatabaseOptions

2022-03-16 08:26:28 +01:00

coincontrol.cpp

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

coincontrol.h

wallet: add input weights to CCoinControl

2022-01-24 11:23:31 -05:00

coinselection.cpp

wallet: track which coin selection algorithm produced a SelectionResult

2022-04-14 12:40:36 -04:00

coinselection.h

wallet: Add some tracepoints for coin selection

2022-04-14 13:41:36 -04:00

context.cpp

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

context.h

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

crypter.cpp

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

crypter.h

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

db.cpp

Replace use of ArgsManager with DatabaseOptions

2022-03-16 08:26:28 +01:00

db.h

Replace use of ArgsManager with DatabaseOptions

2022-03-16 08:26:28 +01:00

dump.cpp

Replace use of ArgsManager with DatabaseOptions

2022-03-16 08:26:28 +01:00

dump.h

Replace use of ArgsManager with DatabaseOptions

2022-03-16 08:26:28 +01:00

external_signer_scriptpubkeyman.cpp

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

external_signer_scriptpubkeyman.h

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

feebumper.cpp

refactor: fix clang-tidy named args usage

2022-04-04 09:01:19 +01:00

feebumper.h

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

fees.cpp

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

fees.h

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

init.cpp

Merge bitcoin/bitcoin#18554: wallet: ensure wallet files are not reused across chains

2022-04-28 15:59:47 -04:00

interfaces.cpp

Merge bitcoin/bitcoin#24091: wallet: Consolidate CInputCoin and COutput

2022-03-24 20:46:43 +00:00

ismine.h

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

load.cpp

wallet: Postpone NotifyWalletLoaded() for encrypted wallets

2022-03-30 21:28:53 +02:00

load.h

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

receive.cpp

refactor: fix clang-tidy named args usage

2022-04-04 09:01:19 +01:00

receive.h

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

salvage.cpp

Replace use of ArgsManager with DatabaseOptions

2022-03-16 08:26:28 +01:00

salvage.h

Replace use of ArgsManager with DatabaseOptions

2022-03-16 08:26:28 +01:00

scriptpubkeyman.cpp

Merge bitcoin/bitcoin#23304: wallet: Derive inactive HD chains in additional places

2022-03-02 09:35:07 +01:00

scriptpubkeyman.h

Merge bitcoin/bitcoin#23304: wallet: Derive inactive HD chains in additional places

2022-03-02 09:35:07 +01:00

spend.cpp

wallet: Add some tracepoints for coin selection

2022-04-14 13:41:36 -04:00

spend.h

moveonly: move COutput to coinselection.h

2022-03-23 14:32:07 -04:00

sqlite.cpp

scripted-diff: rename BytePtr to AsBytePtr

2022-04-26 09:41:45 +01:00

sqlite.h

Replace use of ArgsManager with DatabaseOptions

2022-03-16 08:26:28 +01:00

transaction.cpp

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

transaction.h

wallet: add GetWitnessHash()

2022-02-01 08:44:51 -03:00

wallet.cpp

Merge bitcoin/bitcoin#18554: wallet: ensure wallet files are not reused across chains

2022-04-28 15:59:47 -04:00

wallet.h

Merge bitcoin/bitcoin#18554: wallet: ensure wallet files are not reused across chains

2022-04-28 15:59:47 -04:00

walletdb.cpp

refactor: fix clang-tidy named args usage

2022-04-04 09:01:19 +01:00

walletdb.h

Merge bitcoin/bitcoin#23304: wallet: Derive inactive HD chains in additional places

2022-03-02 09:35:07 +01:00

wallettool.cpp

Replace use of ArgsManager with DatabaseOptions

2022-03-16 08:26:28 +01:00

wallettool.h

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

walletutil.cpp

Use ArgsManager::GetPathArg() for "-walletdir" option

2022-02-09 19:31:23 +02:00

walletutil.h

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00