bitcoin

mirror of https://github.com/bitcoin/bitcoin.git synced 2026-02-16 18:39:18 +00:00

History

Merge bitcoin/bitcoin#24812 : util/check: Add CHECK_NONFATAL identity function and NONFATAL_UNREACHABLE macro

ee02c8bd9aedad8cfd3c2618035fe275da025fb9 util/check: Add CHECK_NONFATAL identity function, NONFATAL_UNREACHABLE AND UNREACHABLE macros (Aurèle Oulès)

Pull request description:

  This PR replaces the macro `CHECK_NONFATAL` with an identity function.
  I simplified the usage of `CHECK_NONFATAL` where applicable in `src/rpc`.
  This function is useful in sanity checks for RPC and command-line interfaces.

  Context: https://github.com/bitcoin/bitcoin/pull/24804#discussion_r846182474.

  Also adds `UNREACHABLE_NONFATAL` macro.

ACKs for top commit:
  jonatack:
    ACK ee02c8bd9aedad8cfd3c2618035fe275da025fb9
  MarcoFalke:
    ACK ee02c8bd9aedad8cfd3c2618035fe275da025fb9 🍨

Tree-SHA512: 3cba09223cd7b22e62fe5d0b46c4a024c1d9957d4268ba6d3fb07fcc0a5854fc0886bb3266184e6a7df5df91373b3e84edd6adf6999c4e934aeef8c043b01aa2

2022-04-24 12:00:05 +02:00

addresses.cpp

refactor: fix clang-tidy named args usage

2022-04-04 09:01:19 +01:00

backup.cpp

util/check: Add CHECK_NONFATAL identity function, NONFATAL_UNREACHABLE AND UNREACHABLE macros

2022-04-16 15:07:41 +02:00

coins.cpp

refactor: fix clang-tidy named args usage

2022-04-04 09:01:19 +01:00

encrypt.cpp

Replace "can not" with "cannot" in docs, user messages, and tests