mirror of
https://github.com/bitcoin/bitcoin.git
synced 2026-03-02 01:36:13 +00:00
403523127b
fa5d478853a88ce7d7095b6abfe8112390298b65 test: valgrind --trace-children=yes for bitcoin wrapper (MarcoFalke)
fa29fb72cb21bec798ddae49b842c78ac84a5a3b test: Remove redundant warning about missing binaries (MarcoFalke)
fa03fbf7e31f384627230e1bc042f7f29c05ff68 test: Fix broken --valgrind handling after bitcoin wrapper (MarcoFalke)
Pull request description:
Currently, tool_bitcoin.py is failing under `--valgrind`:
```sh
$ ./bld-cmake/test/functional/tool_bitcoin.py --valgrind
TestFramework (ERROR): Unexpected exception
Traceback (most recent call last):
File "./test/functional/test_framework/test_framework.py", line 138, in main
self.setup()
~~~~~~~~~~^^
File "./test/functional/test_framework/test_framework.py", line 269, in setup
self.setup_network()
~~~~~~~~~~~~~~~~~~^^
File "./test/functional/tool_bitcoin.py", line 38, in setup_network
assert all(node.args[:len(node_argv)] == node_argv for node in self.nodes)
~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
AssertionError
```
Fix this issue by running `bitcoin` under valgrind.
ACKs for top commit:
achow101:
ACK fa5d478853a88ce7d7095b6abfe8112390298b65
ryanofsky:
Code review ACK fa5d478853a88ce7d7095b6abfe8112390298b65 just squashing commits since last review (Thanks!)
Tree-SHA512: 503685ac69e1ca3046958655bed4fe6d0aee1525c5ea58ebf098efd0332c0e16f138540baffaf9af1263a8c42ac6b150ed8bca5a5371a3c49802e21957ec6632