mirror of
https://github.com/bitcoin/bitcoin.git
synced 2026-02-03 04:01:21 +00:00
de4242f47476769d0a7f3e79e8297ed2dd60d9a4 refactor: Use reference for chain_start in HeadersSyncState (Daniela Brozzoni) e37555e5401f9fca39ada0bd153e46b2c7ebd095 refactor: Use initializer list in CompressedHeader (Daniela Brozzoni) 0488bdfefe92b2c9a924be9244c91fe472462aab refactor: Remove unused parameter in ReportHeadersPresync (Daniela Brozzoni) 256246a9fa5b05141c93aeeb359394b9c7a80e49 refactor: Remove redundant parameter from CheckHeadersPoW (Daniela Brozzoni) ca0243e3a6d77d2b218749f1ba113b81444e3f4a refactor: Remove useless CBlock::GetBlockHeader (Pieter Wuille) 45686522224598bed9923e60daad109094d7bc29 refactor: Use std::span in HasValidProofOfWork (Daniela Brozzoni) 4066bfe561a45f61a3c9bf24bec7f600ddcc7467 refactor: Compute work from headers without CBlockIndex (Daniela Brozzoni) 0bf6139e194f355d121bb2aea74715d1c4099598 p2p: Avoid an IsAncestorOfBestHeaderOrTip call (Pieter Wuille) Pull request description: This is a partial* revival of #25968 It contains a list of most-unrelated simplifications and optimizations to the code merged in #25717: - Avoid an IsAncestorOfBestHeaderOrTip call: Just don't call this function when it won't have any effect. - Compute work from headers without CBlockIndex: Avoid the need to construct a CBlockIndex object just to compute work for a header, when its nBits value suffices for that. Also use some Spans where possible. - Remove useless CBlock::GetBlockHeader: There is no need for a function to convert a CBlock to a CBlockHeader, as it's a child class of it. It also contains the following code cleanups, which were suggested by reviewers in #25968: - Remove redundant parameter from CheckHeadersPoW: No need to pass consensusParams, as CheckHeadersPow already has access to m_chainparams.GetConsensus() - Remove unused parameter in ReportHeadersPresync - Use initializer list in CompressedHeader, also make GetFullHeader const - Use reference for chain_start in HeadersSyncState: chain_start can never be null, so it's better to pass it as a reference rather than a raw pointer *I decided to leave out three commits that were in #25968 (4e7ac7b94d04e056e9994ed1c8273c52b7b23931, ab52fb4e95aa2732d1a1391331ea01362e035984, 7f1cf440ca1a9c86085716745ca64d3ac26957c0), since they're a bit more involved, and I'm a new contributor. If this PR gets merged, I'll comment under #25968 to note that these three commits are still up for grabs :) ACKs for top commit: l0rinc: ACK de4242f47476769d0a7f3e79e8297ed2dd60d9a4 polespinasa: re-ACK de4242f47476769d0a7f3e79e8297ed2dd60d9a4 sipa: ACK de4242f47476769d0a7f3e79e8297ed2dd60d9a4 achow101: ACK de4242f47476769d0a7f3e79e8297ed2dd60d9a4 hodlinator: re-ACK de4242f47476769d0a7f3e79e8297ed2dd60d9a4 Tree-SHA512: 1de4f3ce0854a196712505f2b52ccb985856f5133769552bf37375225ea8664a3a7a6a9578c4fd461e935cd94a7cbbb08f15751a1da7651f8962c866146d9d4b
184 lines
6.8 KiB
C++
184 lines
6.8 KiB
C++
// Copyright (c) 2009-2010 Satoshi Nakamoto
|
|
// Copyright (c) 2009-present The Bitcoin Core developers
|
|
// Distributed under the MIT software license, see the accompanying
|
|
// file COPYING or http://www.opensource.org/licenses/mit-license.php.
|
|
|
|
#include <merkleblock.h>
|
|
|
|
#include <hash.h>
|
|
#include <consensus/consensus.h>
|
|
|
|
|
|
std::vector<unsigned char> BitsToBytes(const std::vector<bool>& bits)
|
|
{
|
|
std::vector<unsigned char> ret((bits.size() + 7) / 8);
|
|
for (unsigned int p = 0; p < bits.size(); p++) {
|
|
ret[p / 8] |= bits[p] << (p % 8);
|
|
}
|
|
return ret;
|
|
}
|
|
|
|
std::vector<bool> BytesToBits(const std::vector<unsigned char>& bytes)
|
|
{
|
|
std::vector<bool> ret(bytes.size() * 8);
|
|
for (unsigned int p = 0; p < ret.size(); p++) {
|
|
ret[p] = (bytes[p / 8] & (1 << (p % 8))) != 0;
|
|
}
|
|
return ret;
|
|
}
|
|
|
|
CMerkleBlock::CMerkleBlock(const CBlock& block, CBloomFilter* filter, const std::set<Txid>* txids)
|
|
{
|
|
header = static_cast<const CBlockHeader&>(block);
|
|
|
|
std::vector<bool> vMatch;
|
|
std::vector<Txid> vHashes;
|
|
|
|
vMatch.reserve(block.vtx.size());
|
|
vHashes.reserve(block.vtx.size());
|
|
|
|
for (unsigned int i = 0; i < block.vtx.size(); i++)
|
|
{
|
|
const Txid& hash{block.vtx[i]->GetHash()};
|
|
if (txids && txids->contains(hash)) {
|
|
vMatch.push_back(true);
|
|
} else if (filter && filter->IsRelevantAndUpdate(*block.vtx[i])) {
|
|
vMatch.push_back(true);
|
|
vMatchedTxn.emplace_back(i, hash);
|
|
} else {
|
|
vMatch.push_back(false);
|
|
}
|
|
vHashes.push_back(hash);
|
|
}
|
|
|
|
txn = CPartialMerkleTree(vHashes, vMatch);
|
|
}
|
|
|
|
// NOLINTNEXTLINE(misc-no-recursion)
|
|
uint256 CPartialMerkleTree::CalcHash(int height, unsigned int pos, const std::vector<Txid> &vTxid) {
|
|
//we can never have zero txs in a merkle block, we always need the coinbase tx
|
|
//if we do not have this assert, we can hit a memory access violation when indexing into vTxid
|
|
assert(vTxid.size() != 0);
|
|
if (height == 0) {
|
|
// hash at height 0 is the txids themselves
|
|
return vTxid[pos].ToUint256();
|
|
} else {
|
|
// calculate left hash
|
|
uint256 left = CalcHash(height-1, pos*2, vTxid), right;
|
|
// calculate right hash if not beyond the end of the array - copy left hash otherwise
|
|
if (pos*2+1 < CalcTreeWidth(height-1))
|
|
right = CalcHash(height-1, pos*2+1, vTxid);
|
|
else
|
|
right = left;
|
|
// combine subhashes
|
|
return Hash(left, right);
|
|
}
|
|
}
|
|
|
|
// NOLINTNEXTLINE(misc-no-recursion)
|
|
void CPartialMerkleTree::TraverseAndBuild(int height, unsigned int pos, const std::vector<Txid> &vTxid, const std::vector<bool> &vMatch) {
|
|
// determine whether this node is the parent of at least one matched txid
|
|
bool fParentOfMatch = false;
|
|
for (unsigned int p = pos << height; p < (pos+1) << height && p < nTransactions; p++)
|
|
fParentOfMatch |= vMatch[p];
|
|
// store as flag bit
|
|
vBits.push_back(fParentOfMatch);
|
|
if (height==0 || !fParentOfMatch) {
|
|
// if at height 0, or nothing interesting below, store hash and stop
|
|
vHash.push_back(CalcHash(height, pos, vTxid));
|
|
} else {
|
|
// otherwise, don't store any hash, but descend into the subtrees
|
|
TraverseAndBuild(height-1, pos*2, vTxid, vMatch);
|
|
if (pos*2+1 < CalcTreeWidth(height-1))
|
|
TraverseAndBuild(height-1, pos*2+1, vTxid, vMatch);
|
|
}
|
|
}
|
|
|
|
// NOLINTNEXTLINE(misc-no-recursion)
|
|
uint256 CPartialMerkleTree::TraverseAndExtract(int height, unsigned int pos, unsigned int &nBitsUsed, unsigned int &nHashUsed, std::vector<Txid> &vMatch, std::vector<unsigned int> &vnIndex) {
|
|
if (nBitsUsed >= vBits.size()) {
|
|
// overflowed the bits array - failure
|
|
fBad = true;
|
|
return uint256();
|
|
}
|
|
bool fParentOfMatch = vBits[nBitsUsed++];
|
|
if (height==0 || !fParentOfMatch) {
|
|
// if at height 0, or nothing interesting below, use stored hash and do not descend
|
|
if (nHashUsed >= vHash.size()) {
|
|
// overflowed the hash array - failure
|
|
fBad = true;
|
|
return uint256();
|
|
}
|
|
const uint256 &hash = vHash[nHashUsed++];
|
|
if (height==0 && fParentOfMatch) { // in case of height 0, we have a matched txid
|
|
vMatch.push_back(Txid::FromUint256(hash));
|
|
vnIndex.push_back(pos);
|
|
}
|
|
return hash;
|
|
} else {
|
|
// otherwise, descend into the subtrees to extract matched txids and hashes
|
|
uint256 left = TraverseAndExtract(height-1, pos*2, nBitsUsed, nHashUsed, vMatch, vnIndex), right;
|
|
if (pos*2+1 < CalcTreeWidth(height-1)) {
|
|
right = TraverseAndExtract(height-1, pos*2+1, nBitsUsed, nHashUsed, vMatch, vnIndex);
|
|
if (right == left) {
|
|
// The left and right branches should never be identical, as the transaction
|
|
// hashes covered by them must each be unique.
|
|
fBad = true;
|
|
}
|
|
} else {
|
|
right = left;
|
|
}
|
|
// and combine them before returning
|
|
return Hash(left, right);
|
|
}
|
|
}
|
|
|
|
CPartialMerkleTree::CPartialMerkleTree(const std::vector<Txid> &vTxid, const std::vector<bool> &vMatch) : nTransactions(vTxid.size()), fBad(false) {
|
|
// reset state
|
|
vBits.clear();
|
|
vHash.clear();
|
|
|
|
// calculate height of tree
|
|
int nHeight = 0;
|
|
while (CalcTreeWidth(nHeight) > 1)
|
|
nHeight++;
|
|
|
|
// traverse the partial tree
|
|
TraverseAndBuild(nHeight, 0, vTxid, vMatch);
|
|
}
|
|
|
|
CPartialMerkleTree::CPartialMerkleTree() : nTransactions(0), fBad(true) {}
|
|
|
|
uint256 CPartialMerkleTree::ExtractMatches(std::vector<Txid> &vMatch, std::vector<unsigned int> &vnIndex) {
|
|
vMatch.clear();
|
|
// An empty set will not work
|
|
if (nTransactions == 0)
|
|
return uint256();
|
|
// check for excessively high numbers of transactions
|
|
if (nTransactions > MAX_BLOCK_WEIGHT / MIN_TRANSACTION_WEIGHT)
|
|
return uint256();
|
|
// there can never be more hashes provided than one for every txid
|
|
if (vHash.size() > nTransactions)
|
|
return uint256();
|
|
// there must be at least one bit per node in the partial tree, and at least one node per hash
|
|
if (vBits.size() < vHash.size())
|
|
return uint256();
|
|
// calculate height of tree
|
|
int nHeight = 0;
|
|
while (CalcTreeWidth(nHeight) > 1)
|
|
nHeight++;
|
|
// traverse the partial tree
|
|
unsigned int nBitsUsed = 0, nHashUsed = 0;
|
|
uint256 hashMerkleRoot = TraverseAndExtract(nHeight, 0, nBitsUsed, nHashUsed, vMatch, vnIndex);
|
|
// verify that no problems occurred during the tree traversal
|
|
if (fBad)
|
|
return uint256();
|
|
// verify that all bits were consumed (except for the padding caused by serializing it as a byte sequence)
|
|
if ((nBitsUsed+7)/8 != (vBits.size()+7)/8)
|
|
return uint256();
|
|
// verify that all hashes were consumed
|
|
if (nHashUsed != vHash.size())
|
|
return uint256();
|
|
return hashMerkleRoot;
|
|
}
|