Wladimir J. van der Laan a43be5bcdb rpc: Prevent dumpwallet from overwriting files ...

Prevent arbitrary files from being overwritten. There have been reports
that users have overwritten wallet files this way. It may also avoid
other security issues.

Fixes #9934. Adds mention to release notes and adds a test.

Github-Pull: #9937
Rebased-From: 0cd9273fd959c6742574259d026039f7da0309a2

2017-10-04 15:11:24 +02:00

..

bench

Merge #10483: scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL

2017-08-14 16:30:59 +02:00

compat

[trivial] Add end of namespace comments

2017-05-31 22:21:25 +02:00

config

…

consensus

scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL

2017-08-07 07:36:37 +02:00

crypto

scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL

2017-08-07 07:36:37 +02:00

leveldb

Update LevelDB with latest Bitcoin-specific patches

2017-08-01 12:40:42 -07:00

obj

…

obj-test

…

policy

Merge #10862: Remove unused variable int64_t nEnd. Fix typo: "conditon" → "condition".

2017-07-20 16:56:45 +02:00

primitives

Replace traditional for with ranged for in primitives

2017-07-24 16:32:21 +02:00

qt

qt: Backup former GUI settings on -resetguisettings

2017-10-04 11:53:18 +02:00

rpc

rpc: make estimatesmartfee argument naming consistent with documentation

2017-10-03 19:30:27 +02:00

script

scripted-diff: stop using the gArgs wrappers

2017-08-14 17:02:10 +02:00

secp256k1

Fixed multiple typos

2017-06-22 19:18:10 +03:00

support

scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL

2017-08-07 07:36:37 +02:00

test

scripted-diff: stop using the gArgs wrappers

2017-08-14 17:02:10 +02:00

univalue

…

wallet

rpc: Prevent dumpwallet from overwriting files

2017-10-04 15:11:24 +02:00

zmq

scripted-diff: stop using the gArgs wrappers

2017-08-14 17:02:10 +02:00

.clang-format

Merge #10193: scripted-diff: Remove #include <boost/foreach.hpp>

2017-07-04 18:05:18 +02:00

addrdb.cpp

Deduplicate addrdb.cpp and use CHashWriter/Verifier

2017-06-01 16:42:07 -07:00

addrdb.h

Deduplicate addrdb.cpp and use CHashWriter/Verifier

2017-06-01 16:42:07 -07:00

addrman.cpp

scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL

2017-08-07 07:36:37 +02:00

addrman.h

when clearing addrman clear mapInfo and mapAddr

2017-10-04 11:48:39 +02:00

amount.h

Consensus: Policy: MOVEONLY: Move CFeeRate out of the consensus module

2017-05-03 18:00:13 +02:00

arith_uint256.cpp

Fix instantiation and array accesses in class base_uint<BITS>

2017-06-07 17:21:29 +00:00

arith_uint256.h

scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL

2017-08-07 07:36:37 +02:00

base58.cpp

scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL

2017-08-07 07:36:37 +02:00

base58.h

scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL

2017-08-07 07:36:37 +02:00

bitcoin-cli-res.rc

…

bitcoin-cli.cpp

scripted-diff: stop using the gArgs wrappers

2017-08-14 17:02:10 +02:00

bitcoin-tx-res.rc

…

bitcoin-tx.cpp

Disallow uncompressed pubkeys in bitcoin-tx [multisig] output adds

2017-10-03 20:12:07 +02:00

bitcoind-res.rc

…

bitcoind.cpp

scripted-diff: stop using the gArgs wrappers

2017-08-14 17:02:10 +02:00

blockencodings.cpp

Fix typos

2017-07-15 14:28:40 +02:00

blockencodings.h

…

bloom.cpp

scripted-diff: Remove #include <boost/foreach.hpp>

2017-06-22 03:48:52 +02:00

bloom.h

…

chain.cpp

scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL

2017-08-07 07:36:37 +02:00

chain.h

scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL

2017-08-07 07:36:37 +02:00

chainparams.cpp

Update chain transaction statistics

2017-08-03 16:39:58 -07:00

chainparams.h

chainparams: make supported service bits option explicit

2017-06-22 15:21:22 -04:00

chainparamsbase.cpp

scripted-diff: stop using the gArgs wrappers

2017-08-14 17:02:10 +02:00

chainparamsbase.h

Chainparams: Use a regular factory for creating chainparams

2017-05-03 18:15:47 +02:00

chainparamsseeds.h

p2p: Hardcoded seeds update pre-0.15 branch

2017-07-30 14:04:51 +02:00

checkpoints.cpp

scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL

2017-08-07 07:36:37 +02:00

checkpoints.h

…

checkqueue.h

scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL

2017-08-07 07:36:37 +02:00

clientversion.cpp

…

clientversion.h

…

coins.cpp

Remove confusing MAX_BLOCK_BASE_SIZE.

2017-07-14 19:24:17 +00:00

coins.h

Merge #10558: Address nits from per-utxo change

2017-06-28 11:44:22 -07:00

compat.h

Move CloseSocket out of SetSocketNonBlocking and pass SOCKET by const reference in SetSocket* functions

2017-07-22 09:11:55 +02:00

compressor.cpp

Fix subscript[0] in compressor.cpp

2017-07-08 13:33:01 -07:00

compressor.h

…

core_io.h

Pass serialization flags and whether to include hex to TxToUniv

2017-08-21 09:49:16 +02:00

core_memusage.h

Avoid dereference-of-casted-pointer

2017-07-07 10:45:31 -07:00

core_read.cpp

Fix signed/unsigned comparison warning introduced in c8e29d7ff0.

2017-07-12 14:03:42 -04:00

core_write.cpp

Pass serialization flags and whether to include hex to TxToUniv

2017-08-21 09:49:16 +02:00

cuckoocache.h

Merge #10577: Add an explanation of quickly hashing onto a non-power of two range.

2017-06-24 11:28:04 +02:00

dbwrapper.cpp

scripted-diff: stop using the gArgs wrappers

2017-08-14 17:02:10 +02:00

dbwrapper.h

scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL

2017-08-07 07:36:37 +02:00

fs.cpp

Remove unused Boost includes

2017-06-09 10:25:26 +02:00

fs.h

[Trivial] Add BITCOIN_FS_H endif footer in fs.h

2017-05-19 02:01:28 -07:00

hash.cpp

Cleanup (safe, it was checked) subscript[0] in MurmurHash3 (and cleanup MurmurHash3 to be more clear).

2017-07-08 13:33:01 -07:00

hash.h

Add specialization of SipHash for 256 + 32 bit data

2017-05-26 13:24:25 -07:00

httprpc.cpp

scripted-diff: stop using the gArgs wrappers

2017-08-14 17:02:10 +02:00

httprpc.h

Remove unnecessary forward class declarations in header files

2017-06-12 20:37:43 +02:00

httpserver.cpp

scripted-diff: stop using the gArgs wrappers

2017-08-14 17:02:10 +02:00

httpserver.h

Add wallet endpoint support to bitcoin-cli (-usewallet)

2017-07-17 17:42:09 +02:00

indirectmap.h

…

init.cpp

Changing -txindex requires -reindex, not -reindex-chainstate

2017-08-28 10:18:58 +02:00

init.h

init: Factor out AppInitLockDataDirectory

2017-07-17 14:56:52 +02:00

key.cpp

scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL

2017-08-07 07:36:37 +02:00

key.h

Add length check for CExtKey deserialization

2017-08-21 09:49:05 +02:00

keystore.cpp

Remove unused Boost includes

2017-06-09 10:25:26 +02:00

keystore.h

Use the override specifier (C++11) where we expect to be overriding the virtual function of a base class

2017-06-28 02:12:06 +02:00

limitedmap.h

…

Makefile.am

Protect SSE4 code behind a compile-time flag

2017-07-20 09:03:53 -07:00

Makefile.bench.include

leveldb: enable runtime-detected crc32 instructions

2017-06-09 19:25:36 -07:00

Makefile.leveldb.include

build: verify that the assembler can handle crc32 functions

2017-07-13 12:49:05 -04:00

Makefile.qt.include

qt: Update translations pre-rc2

2017-08-21 10:48:17 +02:00

Makefile.qttest.include

leveldb: enable runtime-detected crc32 instructions

2017-06-09 19:25:36 -07:00

Makefile.test.include

Fix test_bitcoin circular dependency issue

2017-07-17 17:42:21 +02:00

memusage.h

scripted-diff: Remove #include <boost/foreach.hpp>

2017-06-22 03:48:52 +02:00

merkleblock.cpp

Merge #9980: Fix mem access violation merkleblock

2017-07-17 15:12:39 -07:00

merkleblock.h

Adding assert to avoid a memory access violation inside of PartialMerkleTree::CalcHash()

2017-07-12 10:48:37 -05:00

miner.cpp

scripted-diff: stop using the gArgs wrappers

2017-08-14 17:02:10 +02:00

miner.h

Remove unnecessary forward class declarations in header files

2017-06-12 20:37:43 +02:00

net_processing.cpp

scripted-diff: stop using the gArgs wrappers

2017-08-14 17:02:10 +02:00

net_processing.h

Add timeout for headers sync

2017-06-05 16:33:35 -04:00

net.cpp

scripted-diff: stop using the gArgs wrappers

2017-08-14 17:02:10 +02:00

net.h

scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL

2017-08-07 07:36:37 +02:00

netaddress.cpp

scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL

2017-08-07 07:36:37 +02:00

netaddress.h

scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL

2017-08-07 07:36:37 +02:00

netbase.cpp

scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL

2017-08-07 07:36:37 +02:00

netbase.h

Move CloseSocket out of SetSocketNonBlocking and pass SOCKET by const reference in SetSocket* functions

2017-07-22 09:11:55 +02:00

netmessagemaker.h

…

noui.cpp

…

noui.h

…

pow.cpp

scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL

2017-08-07 07:36:37 +02:00

pow.h

…

prevector.h

scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL

2017-08-07 07:36:37 +02:00

protocol.cpp

Merge #9544: [trivial] Add end of namespace comments. Improve consistency.

2017-06-26 13:40:26 +02:00

protocol.h

Fix incorrect Doxygen tag (@ince → @since). Make Doxygen parameter names match actual parameter names.

2017-07-16 21:22:05 +02:00

pubkey.cpp

scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL

2017-08-07 07:36:37 +02:00

pubkey.h

…

random.cpp

Merge #10483: scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL

2017-08-14 16:30:59 +02:00

random.h

Merge #10377: Use rdrand as entropy source on supported platforms

2017-06-14 15:22:15 +02:00

rest.cpp

scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL

2017-08-07 07:36:37 +02:00

reverse_iterator.h

Rename member field according to the style guide.

2017-07-15 21:19:44 +02:00

reverselock.h

…

scheduler.cpp

Add missing lock in CScheduler::AreThreadsServicingQueue()

2017-07-23 14:51:22 -04:00

scheduler.h

Expose if CScheduler is being serviced, assert its not in EmptyQueue

2017-07-10 21:08:19 -04:00

serialize.h

Fix subscript[0] in validation.cpp

2017-07-08 13:33:01 -07:00

streams.h

scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL

2017-08-07 07:36:37 +02:00

sync.cpp

scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL

2017-08-07 07:36:37 +02:00

sync.h

scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL

2017-08-07 07:36:37 +02:00

threadinterrupt.cpp

…

threadinterrupt.h

…

threadsafety.h

…

timedata.cpp

scripted-diff: stop using the gArgs wrappers

2017-08-14 17:02:10 +02:00

timedata.h

…

tinyformat.h

…

torcontrol.cpp

scripted-diff: stop using the gArgs wrappers

2017-08-14 17:02:10 +02:00

torcontrol.h

…

txdb.cpp

scripted-diff: stop using the gArgs wrappers

2017-08-14 17:02:10 +02:00

txdb.h

Merge #10148: Use non-atomic flushing with block replay

2017-06-28 18:26:41 +02:00

txmempool.cpp

Merge #10193: scripted-diff: Remove #include <boost/foreach.hpp>

2017-07-04 18:05:18 +02:00

txmempool.h

scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL

2017-08-07 07:36:37 +02:00

ui_interface.cpp

…

ui_interface.h

[Qt] allow to execute a callback during splashscreen progress

2017-06-29 17:48:08 +02:00

uint256.cpp

…

uint256.h

…

undo.h

Remove confusing MAX_BLOCK_BASE_SIZE.

2017-07-14 19:24:17 +00:00

util.cpp

remove unused gArgs wrappers

2017-08-14 17:02:36 +02:00

util.h

remove unused gArgs wrappers

2017-08-14 17:02:36 +02:00

utilmoneystr.cpp

…

utilmoneystr.h

doc: Add comment to use ValueFromAmount/AmountFromValue for JSON, not utilmoneystr

2017-08-07 17:10:42 +02:00

utilstrencodings.cpp

scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL

2017-08-07 07:36:37 +02:00

utilstrencodings.h

scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL

2017-08-07 07:36:37 +02:00

utiltime.cpp

scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL

2017-08-07 07:36:37 +02:00

utiltime.h

[logging] log system time and mock time

2017-05-10 15:49:00 -04:00

validation.cpp

scripted-diff: stop using the gArgs wrappers

2017-08-14 17:02:10 +02:00

validation.h

scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL

2017-08-07 07:36:37 +02:00

validationinterface.cpp

Fix validationinterface build on super old boost/clang

2017-10-04 11:54:36 +02:00

validationinterface.h

Remove declaration of unused function: void UpdatedTransaction(const uint256 &)

2017-07-15 20:04:04 +02:00

version.h

Remove unused constant MEMPOOL_GD_VERSION

2017-06-09 01:45:36 +02:00

versionbits.cpp

Avoid returning a BIP9Stats object with uninitialized values

2017-10-03 18:19:35 +02:00

versionbits.h

scripted-diff: Use the C++11 keyword nullptr to denote the pointer literal instead of the macro NULL

2017-08-07 07:36:37 +02:00

warnings.cpp

scripted-diff: stop using the gArgs wrappers

2017-08-14 17:02:10 +02:00

warnings.h

remove some unused functions

2017-07-22 09:55:57 +02:00