glozow
d1e9a02126
Merge bitcoin/bitcoin#29402 : mempool: Log added for dumping mempool transactions to disk
...
4d5b55735bcf82847d748d24da5dbdbd1de8ef41 log: renamed disk to file so wording was more accurate (kevkevin)
b9f04be870c948f071216fba8402a2c5395a336b mempool: Log added for dumping mempool transactions to disk (kevkevin)
Pull request description:
Sometimes when shutting off bitcoind it can take a while to dump the mempool transaction onto the disk so
this change adds additional logging to the `DumpMempool` method in `kernel/mempool_persist.cpp`
Motivated by https://github.com/bitcoin/bitcoin/pull/29227 this change
- adds a single new line for the amount of transactions being dumped and the amount of memory being dumped to file
This is in response to https://github.com/bitcoin/bitcoin/pull/29227#issuecomment-1893375082
The logs will now look like this
```
2024-02-09T23:41:52Z DumpAnchors: Flush 2 outbound block-relay-only peer addresses to anchors.dat completed (0.02s)
2024-02-09T23:41:52Z scheduler thread exit
2024-02-09T23:41:52Z Writing 29 mempool transactions to file...
2024-02-09T23:41:52Z Writing 0 unbroadcast transactions to file.
2024-02-09T23:41:52Z Dumped mempool: 0.000s to copy, 0.022s to dump, 0.015 MB dumped to file
2024-02-09T23:41:52Z Flushed fee estimates to fee_estimates.dat.
2024-02-09T23:41:53Z Shutdown: done
```
ACKs for top commit:
maflcko:
cr-ACK 4d5b55735bcf82847d748d24da5dbdbd1de8ef41
glozow:
reACK 4d5b557
Tree-SHA512: 049191e140d00c1ea57debe0138f1c9eb0f9bb0ef8138e2568e6d89e64f45a5d5853ce3b9cc0b28566aab97555b47ddfb0f9199fc8cea6b81e53f50592d5ae6a
2024-03-28 11:43:10 +00:00
..
2024-03-12 09:30:42 -03:00
2024-03-11 10:29:31 -04:00
2024-03-01 13:13:07 -05:00
2023-11-16 11:36:22 +10:00
2024-02-27 18:28:19 +00:00
2024-03-01 11:19:58 -05:00
2024-03-22 14:50:58 -04:00
2024-01-11 11:01:28 -06:00
2024-01-05 10:42:10 +00:00
2023-11-28 12:35:50 -05:00
2024-03-28 11:43:10 +00:00
2022-09-29 16:43:30 +01:00
2023-01-31 18:48:50 +01:00
2022-10-23 15:03:04 +01:00
2024-03-21 16:40:22 +01:00
2024-03-26 08:48:37 +00:00
2024-02-27 14:19:15 +00:00
2024-03-13 06:53:07 -04:00
2024-03-25 11:48:18 -04:00
2024-03-15 13:34:05 +00:00
2024-01-04 14:40:28 +00:00
2024-02-13 20:10:44 +00:00
2024-03-26 08:56:44 +00:00
2023-07-27 14:24:52 +02:00
2024-03-26 08:48:37 +00:00
2024-03-27 12:45:08 -04:00
2024-03-12 12:46:46 -04:00
2023-10-12 11:27:19 +02:00
2023-12-15 15:20:54 +01:00
2024-03-15 13:34:05 +00:00
2024-03-23 15:33:47 +01:00
2023-09-05 10:13:25 +02:00
2023-09-12 12:14:31 -04:00
2023-10-25 22:46:55 +02:00
2023-10-04 18:08:49 +02:00
2024-02-20 13:07:48 +00:00
2024-01-15 16:19:53 -05:00
2023-11-21 17:37:25 +01:00
2023-11-21 17:37:25 +01:00
2023-05-04 20:57:51 +01:00
2023-11-02 14:09:27 -04:00
2023-11-02 14:09:27 -04:00
2022-12-24 23:49:50 +00:00
2022-12-24 23:49:50 +00:00
2022-12-24 23:49:50 +00:00
2023-09-10 16:11:52 -04:00
2023-09-10 16:11:52 -04:00
2024-03-21 16:40:22 +01:00
2024-01-09 15:27:08 -06:00
2023-12-11 13:08:46 -05:00
2023-11-16 11:36:22 +10:00
2023-05-20 12:08:13 +02:00
2023-12-04 15:39:15 -04:00
2023-11-16 11:14:13 +10:00
2023-11-14 08:45:30 +10:00
2023-11-28 12:42:07 +01:00
2023-08-17 18:28:15 +02:00
2022-12-24 23:49:50 +00:00
2024-03-18 11:28:40 -05:00
2023-05-25 19:24:05 +02:00
2023-05-25 19:24:05 +02:00
2023-05-10 10:39:58 +02:00
2023-05-10 10:39:58 +02:00
2024-03-04 19:53:30 -05:00
2023-10-03 10:52:17 +01:00
2024-02-13 20:10:44 +00:00
2022-12-24 23:49:50 +00:00
2023-11-21 13:15:44 +00:00
2023-11-24 14:41:58 +00:00
2023-08-14 17:38:27 -04:00
2023-12-11 18:22:13 +01:00
2023-11-16 11:36:22 +10:00
2023-12-11 18:22:13 +01:00
2023-01-31 11:50:10 +00:00
2023-09-12 12:07:39 +02:00
2023-09-12 12:07:39 +02:00
2023-03-15 16:42:42 +01:00
2023-03-15 16:42:42 +01:00
2022-12-24 23:49:50 +00:00
2022-12-24 23:49:50 +00:00
2023-04-19 10:48:30 +02:00
2023-11-30 11:28:19 +01:00
2023-05-20 12:08:13 +02:00
2024-03-11 13:49:37 +01:00
2023-04-03 14:41:22 +01:00
2024-01-05 17:12:38 +01:00
2023-11-16 11:36:22 +10:00
2024-02-01 13:52:05 +01:00
2022-12-12 21:06:04 +00:00
2023-09-19 15:54:17 -06:00
2024-01-10 14:11:32 -05:00
2023-12-04 15:39:15 -04:00
2024-03-13 06:53:07 -04:00
2024-03-01 14:47:29 -05:00
2024-03-23 15:33:50 +01:00
2023-12-04 15:39:15 -04:00
2024-01-16 15:29:18 +01:00
2023-08-14 17:38:27 -04:00
2024-01-16 15:29:18 +01:00
2024-01-16 15:29:18 +01:00
2023-12-15 11:03:25 +10:00
2024-03-12 16:26:15 +01:00
2024-03-18 10:32:00 -04:00
2024-03-12 09:30:42 -03:00
2024-03-04 10:02:26 +00:00
2023-10-19 13:25:49 +01:00
2022-09-13 17:15:17 +01:00
2023-11-20 15:57:50 -03:00
2023-07-19 10:26:11 +01:00
2024-03-18 10:32:00 -04:00
2023-06-16 10:38:19 +01:00
2023-01-28 15:24:13 +00:00
2023-09-13 11:37:45 +01:00
2023-11-28 17:49:41 +01:00
2023-11-28 17:49:41 +01:00
2024-02-28 10:05:56 -03:00
2024-02-28 10:05:56 -03:00
2024-03-13 07:26:34 -04:00
2024-01-15 10:28:20 -03:00
2023-05-30 16:27:21 -03:00
2024-03-13 06:53:07 -04:00
2024-02-28 10:05:56 -03:00
2024-03-01 13:13:07 -05:00
2024-03-01 13:13:07 -05:00
2024-03-13 14:09:50 -04:00
2024-03-01 14:47:28 -05:00
2023-12-06 11:22:42 -05:00
2023-12-02 22:03:08 +01:00
2023-11-20 14:02:27 +01:00
2024-03-21 16:41:16 +01:00
2023-08-14 17:38:27 -04:00
2023-08-14 17:38:27 -04:00
2022-12-24 23:49:50 +00:00
2022-12-24 23:49:50 +00:00
2024-01-18 19:29:34 +01:00
2024-01-23 10:25:16 -03:00
2024-01-23 10:25:16 -03:00
2023-11-30 11:28:19 +01:00
2023-11-28 12:42:07 +01:00
2023-10-08 02:43:19 +02:00
2024-01-16 10:58:57 +01:00
2024-02-13 20:10:44 +00:00
2024-02-26 16:13:12 +00:00
2023-09-12 22:51:48 +02:00
2024-03-12 12:48:04 -04:00
2023-01-12 13:42:44 +00:00
2024-02-15 14:43:14 +01:00
2024-02-16 17:12:52 +01:00
2024-03-01 11:19:58 -05:00
2023-11-28 12:42:07 +01:00
2023-12-22 09:58:19 +01:00
2023-07-19 18:12:42 +02:00
2023-11-30 11:27:54 +01:00
2024-02-13 20:10:44 +00:00
2023-10-26 15:02:13 -04:00
2024-01-05 17:16:38 +00:00
2024-02-01 13:52:05 +01:00
2023-01-31 11:50:10 +00:00
2024-01-10 14:11:32 -05:00
2023-08-17 23:58:47 -05:00
2023-09-05 11:37:35 +01:00
2023-08-01 15:27:33 +02:00
2024-03-18 10:32:00 -04:00
2024-03-18 10:32:00 -04:00
2023-12-08 13:14:46 +00:00
2023-12-08 13:14:46 +00:00
2023-12-07 11:06:01 +01:00
2022-12-10 14:34:44 -06:00
2023-06-28 15:12:12 -04:00
2023-11-16 11:36:22 +10:00
2024-03-25 11:52:12 -04:00
2024-03-25 11:52:12 -04:00
2024-02-16 17:12:52 +01:00
2024-02-16 17:12:52 +01:00
2023-01-03 19:31:29 -06:00
2022-12-24 23:49:50 +00:00
2022-12-24 23:49:50 +00:00
2024-02-13 20:10:44 +00:00