mirror of https://github.com/bitcoin/bitcoin.git synced 2026-02-12 00:21:15 +00:00

History

Merge #17138 : Remove wallet access to some node arguments

b96ed0396294fc4fa89d83ceab6bc169dd09f002 [wallet] Remove pruning check for -rescan option (John Newbery)
eea462de9c652dca556ad241d2126b10790f67f8 [wallet] Remove package limit config access from wallet (John Newbery)

Pull request description:

  Removes wallet access to `-limitancestorcount`, `-limitdescendantcount` and `-prune`:

  - `-limitancestorcount` and `-limitdescendantcount` are now accessed with a method `getPackageLimits` in the `Chain` interface.
  - `-prune` is not required. It was only used in wallet component initiation to prevent running `-rescan` when pruning was enabled. This check is not required.

  Partially addresses #17137.

ACKs for top commit:
  MarcoFalke:
    Tested ACK b96ed0396294fc4fa89d83ceab6bc169dd09f002
  ryanofsky:
    Code review ACK b96ed0396294fc4fa89d83ceab6bc169dd09f002
  promag:
    Code review ACK b96ed0396294fc4fa89d83ceab6bc169dd09f002.
  ariard:
    ACK b96ed03, check there isn't left anymore wallet access to node arguments.

Tree-SHA512: 90c8e3e083acbd37724f1bccf63dab642cf9ae95cc5e684872a67443ae048b4fdbf57b52ea47c5a1da6489fd277278fe2d9bbe95e17f3d4965a1a0fbdeb815bf

2019-10-15 14:59:43 -04:00

chain.cpp

[wallet] Remove package limit config access from wallet

2019-10-14 13:32:41 -04:00

chain.h

[wallet] Remove package limit config access from wallet

2019-10-14 13:32:41 -04:00

handler.cpp

scripted-diff: Move util files to separate directory.

2018-11-04 22:46:07 -08:00

handler.h

scripted-diff: Avoid interface keyword to fix windows gitian build

2018-04-07 03:42:02 -04:00

node.cpp

Revert "gui: Generate bech32 addresses by default (take 2, fixup)"

2019-09-26 16:23:32 -04:00

node.h

Revert "gui: Generate bech32 addresses by default (take 2, fixup)"

2019-09-26 16:23:32 -04:00

README.md

Suggested interfaces::Chain cleanups from #15288

2019-03-04 15:57:58 -05:00

wallet.cpp

change wallet pointers to references in feebumper

2019-10-10 17:46:59 -04:00

wallet.h

Get rid of PendingWalletTx class.

2019-07-18 12:06:23 -04:00

README.md

Internal c++ interfaces

The following interfaces are defined here:

Chain — used by wallet to access blockchain and mempool state. Added in #14437, #14711, #15288, and #10973.
ChainClient — used by node to start & stop Chain clients. Added in #14437.
Node — used by GUI to start & stop bitcoin node. Added in #10244.
Wallet — used by GUI to access wallets. Added in #10244.
Handler — returned by handleEvent methods on interfaces above and used to manage lifetimes of event handlers.
Init — used by multiprocess code to access interfaces above on startup. Added in #10102.

The interfaces above define boundaries between major components of bitcoin code (node, wallet, and gui), making it possible for them to run in different processes, and be tested, developed, and understood independently. These interfaces are not currently designed to be stable or to be used externally.