mirror of
https://github.com/bitcoin/bitcoin.git
synced 2026-01-31 18:51:12 +00:00
500862b2d4
a1f76230209629c5141984aaac1cc4ba7b4f761a qa: Only complain about expected messages that were not found (Hodlinator) 1e54125e2e0063e4586265b957912896c056ba0a refactor(qa): Avoid unnecessary string operations (Hodlinator) a9021101dc63ee7fb1e1f342387ab7d3f0e3cefc qa: Replace always-escaped regexps with "X in Y" (Hodlinator) 5c16e4631c009056d571d83fe17062c107f71798 doc: Remove no longer correct comment (Hodlinator) Pull request description: * Remove incorrect docstring in `busy_wait_for_debug_log()`. * Replace nerfed regex searches with `X in Y` expressions. * Only compute the log string to be printed on failure *when we actually fail* instead of every 0.05s. * As we find each needle (expected message) in the haystack (log output), stop searching for it. **If we fail and time out, we will only complain about the needles (expected messages) we didn't find. On master we also include found needles, which is less helpful.** Found while developing a new test case in https://github.com/bitcoin/bitcoin/pull/33336#discussion_r2351892330 ACKs for top commit: l0rinc: Code review ACK a1f76230209629c5141984aaac1cc4ba7b4f761a maflcko: review ACK a1f76230209629c5141984aaac1cc4ba7b4f761a 💨 Tree-SHA512: 191ea7647b0ea8b4220e37c62d176861c2fd0e3737aee3641b262915d9118f48953cf1204767c93a93a8fc78a44c2c29206fb390b44c59d99fc2aa7d12bf4889