fanquake 869342f7fa

Merge bitcoin/bitcoin#26282: wallet: have prune error take precedence over assumedvalid ...

1c36bafc5f7db268546dcc86c793071a7e9d35e0 wallet: have prune error take precedence over assumedvalid (James O'Beirne)

Pull request description:

  Fixes https://github.com/bitcoin/bitcoin/pull/23997#discussion_r891412739.

  From Russ Yanofsky:

  > Agree with all of Marco's points here and think this should be updated
  >
  > If havePrune and hasAssumedValidChain are both true, better to show havePrune error message.  Assumed-valid error message is vague and not very actionable.  Would suggest "Error loading wallet. Wallet requires blocks to be downloaded, and software does not currently support loading wallets while blocks are being downloaded out of order though assumeutxo snapshots. Wallet should be able to load successfully after node sync reaches height {block_height}"

ACKs for top commit:
  MarcoFalke:
    ACK 1c36bafc5f7db268546dcc86c793071a7e9d35e0
  aureleoules:
    ACK 1c36bafc5f7db268546dcc86c793071a7e9d35e0

Tree-SHA512: bfb0024bb962525cbbd392ade3c0331a8b0525e7f2f2ab52b2dbb9b6dd6311070d85ecb762a7689db84a30991971865698ab6fec187206e6a92133790c5a91dc

2022-10-10 17:04:43 +08:00

..

rpc

refactor: move Boost datetime usage to wallet

2022-10-01 11:41:53 +01:00

test

Merge bitcoin/bitcoin#26203: wallet: Use correct effective value when checking target

2022-10-04 09:57:17 +01:00

bdb.cpp

Merge bitcoin/bitcoin#25499: Use steady clock for all millis bench logging

2022-09-16 11:10:15 +01:00

bdb.h

…

coincontrol.cpp

…

coincontrol.h

…

coinselection.cpp

wallet: use GetChange() when computing waste

2022-08-15 09:35:20 +02:00

coinselection.h

wallet: use GetChange() when computing waste

2022-08-15 09:35:20 +02:00

context.cpp

…

context.h

…

crypter.cpp

…

crypter.h

…

db.cpp

…

db.h

…

dump.cpp

Use HashWriter where possible

2022-07-20 15:34:36 +02:00

dump.h

…

external_signer_scriptpubkeyman.cpp

…

external_signer_scriptpubkeyman.h

…

feebumper.cpp

Merge bitcoin/bitcoin#25775: docs: remove non-signaling mentions of BIP125

2022-08-22 10:35:26 +01:00

feebumper.h

bumpfee: be able to bump fee of a tx with external inputs

2022-08-19 11:27:01 -04:00

fees.cpp

Remove ::dustRelayFee

2022-08-02 15:26:49 +02:00

fees.h

…

init.cpp

…

interfaces.cpp

Merge bitcoin/bitcoin#26005: Wallet: Fix error handling (copy_file failure in RestoreWallet, and in general via interfaces)

2022-09-19 16:10:47 +01:00

ismine.h

…

load.cpp

wallet: trigger MaybeResendWalletTxs() every minute

2022-08-25 14:29:25 +01:00

load.h

…

receive.cpp

Merge bitcoin/bitcoin#25707: refactor: Make const references to avoid unnecessarily copying objects and enable two clang-tidy checks

2022-08-19 17:11:06 +02:00

receive.h

Merge bitcoin/bitcoin#25504: RPC: allow to track coins by parent descriptors

2022-08-16 13:08:05 -04:00

salvage.cpp

…

salvage.h

…

scriptpubkeyman.cpp

Fix comment typos in scriptpubkeyman.cpp, wallet.cpp, wallet.h

2022-10-09 17:19:59 +03:00

scriptpubkeyman.h

Implement LegacyScriptPubKeyMan::DeleteRecords

2022-08-26 13:14:51 -04:00

spend.cpp

wallet: Use correct effective value when checking target

2022-10-02 01:34:25 +02:00

spend.h

wallet: switch to new shuffle, erase, push_back

2022-08-10 15:19:31 +02:00

sqlite.cpp

…

sqlite.h

…

transaction.cpp

…

transaction.h

wallet: Deduplicate Resend and ReacceptWalletTransactions

2022-08-29 12:38:06 -04:00

wallet.cpp

Merge bitcoin/bitcoin#26282: wallet: have prune error take precedence over assumedvalid

2022-10-10 17:04:43 +08:00

wallet.h

Fix comment typos in scriptpubkeyman.cpp, wallet.cpp, wallet.h

2022-10-09 17:19:59 +03:00

walletdb.cpp

wallet: bugfix, load wallet with an unknown descriptor cause fatal error

2022-09-09 15:35:04 -03:00

walletdb.h

wallet: bugfix, load wallet with an unknown descriptor cause fatal error

2022-09-09 15:35:04 -03:00

wallettool.cpp

Merge bitcoin/bitcoin#25784: Wallet: Document expectations for AddWalletFlags (now InitWalletFlags) correctly

2022-08-19 12:12:27 -04:00

wallettool.h

…

walletutil.cpp

…

walletutil.h

Implement LegacyScriptPubKeyMan::MigrateToDescriptor

2022-08-25 16:25:53 -04:00