9890058b37
b0c706795ce6a3a00bf068a81ee99fef2ee9bf7e Remove unreliable seed from chainparams.cpp, and the associated README (SatsAndSports) Pull request description: The DNS seed `dnsseed.bitcoin.dashjr-list-of-p2p-nodes.us.` is not returning a representative sample of bitcoin nodes. It currently returns nothing later than 28.1.0, breaching the policy. This PR removes that seed from the list of DNS seeds ### Rationale The [policy for seeds](https://github.com/bitcoin/bitcoin/blob/master/doc/dnsseed-policy.md) includes this: > The DNS seed results must consist exclusively of fairly selected and functioning Bitcoin nodes from the public network A number of comments below, in response to this PR, include apparent breaches of this policy: [1](https://github.com/bitcoin/bitcoin/pull/33723#issuecomment-3458071231) [2](https://github.com/bitcoin/bitcoin/pull/33723#issuecomment-3457655364), [3](https://github.com/bitcoin/bitcoin/pull/33723#issuecomment-3457712557), in particular the first linked comment ([1](https://github.com/bitcoin/bitcoin/pull/33723#issuecomment-3458071231)) comparing the distribution at this seed to other seeds. This seed is not including anything later than 28.2.0, breaching this policy. To ensure the policy is followed, and the seeds include a representative sample of Bitcoin nodes, this PR removes this seed from the list ### Data I ran this: ``` # Get some ip address from that seed: # Repeated multiple times, to get many different IPs: dig +short dnsseed.bitcoin.dashjr-list-of-p2p-nodes.us >> dnsseed.bitcoin.dashjr-list-of-p2p-nodes.us # For each distinct ip gathered from the seed, get basic info about the node, including it's User Agent string: cat dnsseed.bitcoin.dashjr-list-of-p2p-nodes.us | sort -u | while read ip; do echo ===; echo $ip; nmap -p 8333 --script bitcoin-info "$ip"; done > seed_versions.txt ``` and then summarized the agents with `egrep 'User Agent' seed_versions.txt | sort | uniq -c` and got: ``` 1 User Agent: /Satoshi:22.0.0/ 1 User Agent: /Satoshi:22.1.0/ 5 User Agent: /Satoshi:24.0.1/ 1 User Agent: /Satoshi:25.1.0/ 30 User Agent: /Satoshi:27.0.0/ 1 User Agent: /Satoshi:27.1.0/ 1 User Agent: /Satoshi:27.1.0/Knots:20240801/ 1 User Agent: /Satoshi:28.0.0/ 7 User Agent: /Satoshi:28.1.0/ 2 User Agent: /Satoshi:28.1.0/Knots:20250305/ ``` ACKs for top commit: l0rinc: reACK b0c706795ce6a3a00bf068a81ee99fef2ee9bf7e delta1: reACKb0c706795cCrypt-iQ: crACK b0c706795ce6a3a00bf068a81ee99fef2ee9bf7e laanwj: ACK b0c706795ce6a3a00bf068a81ee99fef2ee9bf7e murchandamus: ACKb0c706795cRandyMcMillan: ACK b0c7067 wiz: ACK b0c706795ce6a3a00bf068a81ee99fef2ee9bf7e dergoegge: ACK b0c706795ce6a3a00bf068a81ee99fef2ee9bf7e stickies-v: re-ACK b0c706795ce6a3a00bf068a81ee99fef2ee9bf7e mzumsande: ACK b0c706795ce6a3a00bf068a81ee99fef2ee9bf7e instagibbs: ACK b0c706795ce6a3a00bf068a81ee99fef2ee9bf7e Tree-SHA512: 7230b8dd24560ce6f8247e2e82ae7846ded8b91e230c59cc3643da3f5b9c12b5f025c1bb14490c19ca55f3794e81ce08106b31b3bf883d5c2dced05017123ac4
Bitcoin Core integration/staging tree
For an immediately usable, binary version of the Bitcoin Core software, see https://bitcoincore.org/en/download/.
What is Bitcoin Core?
Bitcoin Core connects to the Bitcoin peer-to-peer network to download and fully validate blocks and transactions. It also includes a wallet and graphical user interface, which can be optionally built.
Further information about Bitcoin Core is available in the doc folder.
License
Bitcoin Core is released under the terms of the MIT license. See COPYING for more information or see https://opensource.org/license/MIT.
Development Process
The master branch is regularly built (see doc/build-*.md for instructions) and tested, but it is not guaranteed to be
completely stable. Tags are created
regularly from release branches to indicate new official, stable release versions of Bitcoin Core.
The https://github.com/bitcoin-core/gui repository is used exclusively for the development of the GUI. Its master branch is identical in all monotree repositories. Release branches and tags do not exist, so please do not fork that repository unless it is for development reasons.
The contribution workflow is described in CONTRIBUTING.md and useful hints for developers can be found in doc/developer-notes.md.
Testing
Testing and code review is the bottleneck for development; we get more pull requests than we can review and test on short notice. Please be patient and help out by testing other people's pull requests, and remember this is a security-critical project where any mistake might cost people lots of money.
Automated Testing
Developers are strongly encouraged to write unit tests for new code, and to
submit new unit tests for old code. Unit tests can be compiled and run
(assuming they weren't disabled during the generation of the build system) with: ctest. Further details on running
and extending unit tests can be found in /src/test/README.md.
There are also regression and integration tests, written
in Python.
These tests can be run (if the test dependencies are installed) with: build/test/functional/test_runner.py
(assuming build is your build directory).
The CI (Continuous Integration) systems make sure that every pull request is tested on Windows, Linux, and macOS. The CI must pass on all commits before merge to avoid unrelated CI failures on new pull requests.
Manual Quality Assurance (QA) Testing
Changes should be tested by somebody other than the developer who wrote the code. This is especially important for large or high-risk changes. It is useful to add a test plan to the pull request description if testing the changes is not straightforward.
Translations
Changes to translations as well as new translations can be submitted to Bitcoin Core's Transifex page.
Translations are periodically pulled from Transifex and merged into the git repository. See the translation process for details on how this works.
Important: We do not accept translation changes as GitHub pull requests because the next pull from Transifex would automatically overwrite them again.