Andrew Chow 5d294bccba

Merge bitcoin/bitcoin#25825: wallet: consolidate CoinSelectionParams::m_change_target and m_min_change_target ...

acda7e8686a1f7a967d6331a2f6a3a01389c3048 [coin selection] consolidate m_change_target and m_min_change_target (glozow)

Pull request description:

  These values are both intended for the same thing. Their divergence seems to be the result of an incomplete rename.

ACKs for top commit:
  achow101:
    ACK acda7e8686a1f7a967d6331a2f6a3a01389c3048
  Xekyo:
    ACK acda7e8686a1f7a967d6331a2f6a3a01389c3048
  furszy:
    ACK acda7e86
  aureleoules:
    ACK acda7e8686a1f7a967d6331a2f6a3a01389c3048.

Tree-SHA512: 4b86171af5d893f7172373bb404bad12c49588ad1e22eb0544c242173f4bc4dede2ff1270c93c9f02f503ab8d9f66b841a8319d0ecb5e896d0fe8727cf03dbf4

2022-08-11 15:04:13 -04:00

..

rpc

script/sign: remove needless IsSolvable() utility

2022-08-11 15:43:40 +02:00

test

wallet: Return util::Result from WalletLoader methods

2022-08-10 11:14:53 -03:00

bdb.cpp

compat: document S_I* defines when building for Windows

2022-07-20 13:10:07 +01:00

bdb.h

scripted-diff: replace non-standard fixed width integer types (u_int... -> uint`...)

2022-05-12 15:44:24 +02:00

coincontrol.cpp

…

coincontrol.h

scripted-diff: rename fAllowOtherInputs -> m_allow_other_inputs

2022-06-19 20:32:51 -03:00

coinselection.cpp

Revert "bnb: exit selection when best_waste is 0"

2022-06-28 17:27:06 -04:00

coinselection.h

[coin selection] consolidate m_change_target and m_min_change_target

2022-08-11 15:23:21 +01:00

context.cpp

refactor: use C++11 default initializers

2022-05-17 17:18:58 +01:00

context.h

…

crypter.cpp

…

crypter.h

…

db.cpp

Replace use of ArgsManager with DatabaseOptions

2022-03-16 08:26:28 +01:00

db.h

Replace use of ArgsManager with DatabaseOptions

2022-03-16 08:26:28 +01:00

dump.cpp

Use HashWriter where possible

2022-07-20 15:34:36 +02:00

dump.h

Replace use of ArgsManager with DatabaseOptions

2022-03-16 08:26:28 +01:00

external_signer_scriptpubkeyman.cpp

…

external_signer_scriptpubkeyman.h

…

feebumper.cpp

Merge bitcoin/bitcoin#24699: wallet: Improve AvailableCoins performance by reducing duplicated operations

2022-08-05 15:31:45 -04:00

feebumper.h

…

fees.cpp

Remove ::dustRelayFee

2022-08-02 15:26:49 +02:00

fees.h

…

init.cpp

scripted-diff: Avoid incompatibility with CMake AUTOUIC feature

2022-06-14 10:38:51 +02:00

interfaces.cpp

wallet: Return util::Result from WalletLoader methods

2022-08-10 11:14:53 -03:00

ismine.h

…

load.cpp

wallet: Postpone NotifyWalletLoaded() for encrypted wallets

2022-03-30 21:28:53 +02:00

load.h

…

receive.cpp

Merge bitcoin/bitcoin#25543: wallet: cleanup cached amount and input mine check code

2022-07-20 16:59:41 -04:00

receive.h

wallet: unify CachedTxGetImmatureCredit and CachedTxGetImmatureWatchOnlyCredit

2022-07-05 10:10:27 -03:00

salvage.cpp

Replace use of ArgsManager with DatabaseOptions

2022-03-16 08:26:28 +01:00

salvage.h

Replace use of ArgsManager with DatabaseOptions

2022-03-16 08:26:28 +01:00

scriptpubkeyman.cpp

Merge bitcoin/bitcoin#25664: refactor: Redefine IsSolvable() using descriptors

2022-08-11 13:41:47 -04:00

scriptpubkeyman.h

Merge bitcoin/bitcoin#25656: refactor: wallet: return util::Result from GetReservedDestination methods

2022-08-10 14:19:17 +02:00

spend.cpp

[coin selection] consolidate m_change_target and m_min_change_target

2022-08-11 15:23:21 +01:00

spend.h

refactor: Replace BResult with util::Result

2022-08-03 07:33:01 -04:00

sqlite.cpp

scripted-diff: Convert global Mutexes to GlobalMutexes

2022-05-21 01:23:23 +10:00

sqlite.h

Replace use of ArgsManager with DatabaseOptions

2022-03-16 08:26:28 +01:00

transaction.cpp

…

transaction.h

…

wallet.cpp

Merge bitcoin/bitcoin#25656: refactor: wallet: return util::Result from GetReservedDestination methods

2022-08-10 14:19:17 +02:00

wallet.h

Merge bitcoin/bitcoin#25656: refactor: wallet: return util::Result from GetReservedDestination methods

2022-08-10 14:19:17 +02:00

walletdb.cpp

Merge bitcoin/bitcoin#25383: wallet: don't read db every time that a new 'WalletBatch' is created

2022-06-30 18:38:20 +02:00

walletdb.h

walletdb: Create a mock database of specific type

2022-05-10 11:54:02 -04:00

wallettool.cpp

Replace use of ArgsManager with DatabaseOptions

2022-03-16 08:26:28 +01:00

wallettool.h

…

walletutil.cpp

…

walletutil.h

…