Andrew Chow 9e2a2b88d5

Merge bitcoin/bitcoin#26132: wallet: Fix nNextResend data race in ResubmitWalletTransactions ...

fad61573ed547615f73710cb59b2fb0ecafed127 Fix nNextResend data race in ResubmitWalletTransactions (MacroFake)

Pull request description:

  Now that `ResubmitWalletTransactions` is called from more than one thread, it is no longer thread-safe.

  Introduced in 5291933fedceb9df16eb9e4627b1d7386b53ba07.

ACKs for top commit:
  achow101:
    ACK fad61573ed547615f73710cb59b2fb0ecafed127
  jonatack:
    ACK fad61573ed547615f73710cb59b2fb0ecafed127
  stickies-v:
    However, I think the current data race UB fix in fad61573e is the most critical to get into v24, so: ACK fad61573e - but open to further improvements.

Tree-SHA512: 54da2ed1c5f44e33588ac1d21ce26908fcf0bfe785c28ba8f6a479389b5ab7a0b32b016d4c482a2ccb405e0686efb61ffe23e427f5e589dc7d2b3c7469978977

2022-09-20 18:48:06 -04:00

..

rpc

Merge bitcoin/bitcoin#26116: rpc: Allow importmulti watchonly imports with locked wallet

2022-09-20 12:00:02 -04:00

test

Fix issues identified by codespell 2.2.1 and update ignored words

2022-09-15 13:03:40 +02:00

bdb.cpp

Merge bitcoin/bitcoin#25499: Use steady clock for all millis bench logging

2022-09-16 11:10:15 +01:00

bdb.h

scripted-diff: replace non-standard fixed width integer types (u_int... -> uint`...)

2022-05-12 15:44:24 +02:00

coincontrol.cpp

…

coincontrol.h

scripted-diff: rename fAllowOtherInputs -> m_allow_other_inputs

2022-06-19 20:32:51 -03:00

coinselection.cpp

wallet: use GetChange() when computing waste

2022-08-15 09:35:20 +02:00

coinselection.h

wallet: use GetChange() when computing waste

2022-08-15 09:35:20 +02:00

context.cpp

refactor: use C++11 default initializers

2022-05-17 17:18:58 +01:00

context.h

…

crypter.cpp

…

crypter.h

…

db.cpp

…

db.h

…

dump.cpp

Use HashWriter where possible

2022-07-20 15:34:36 +02:00

dump.h

…

external_signer_scriptpubkeyman.cpp

GetExternalSigner(): fail if multiple signers are found

2022-06-09 20:34:46 +02:00

external_signer_scriptpubkeyman.h

…

feebumper.cpp

Merge bitcoin/bitcoin#25775: docs: remove non-signaling mentions of BIP125

2022-08-22 10:35:26 +01:00

feebumper.h

bumpfee: be able to bump fee of a tx with external inputs

2022-08-19 11:27:01 -04:00

fees.cpp

Remove ::dustRelayFee

2022-08-02 15:26:49 +02:00

fees.h

…

init.cpp

scripted-diff: Avoid incompatibility with CMake AUTOUIC feature

2022-06-14 10:38:51 +02:00

interfaces.cpp

Merge bitcoin/bitcoin#26005: Wallet: Fix error handling (copy_file failure in RestoreWallet, and in general via interfaces)

2022-09-19 16:10:47 +01:00

ismine.h

…

load.cpp

wallet: trigger MaybeResendWalletTxs() every minute

2022-08-25 14:29:25 +01:00

load.h

…

receive.cpp

Merge bitcoin/bitcoin#25707: refactor: Make const references to avoid unnecessarily copying objects and enable two clang-tidy checks

2022-08-19 17:11:06 +02:00

receive.h

Merge bitcoin/bitcoin#25504: RPC: allow to track coins by parent descriptors

2022-08-16 13:08:05 -04:00

salvage.cpp

…

salvage.h

…

scriptpubkeyman.cpp

Implement LegacyScriptPubKeyMan::DeleteRecords

2022-08-26 13:14:51 -04:00

scriptpubkeyman.h

Implement LegacyScriptPubKeyMan::DeleteRecords

2022-08-26 13:14:51 -04:00

spend.cpp

Merge bitcoin/bitcoin#25872: Fix issues when calling std::move(const&)

2022-08-31 08:38:24 +01:00

spend.h

wallet: switch to new shuffle, erase, push_back

2022-08-10 15:19:31 +02:00

sqlite.cpp

scripted-diff: Convert global Mutexes to GlobalMutexes

2022-05-21 01:23:23 +10:00

sqlite.h

…

transaction.cpp

…

transaction.h

wallet: Deduplicate Resend and ReacceptWalletTransactions

2022-08-29 12:38:06 -04:00

wallet.cpp

Fix nNextResend data race in ResubmitWalletTransactions

2022-09-20 11:49:57 +02:00

wallet.h

Fix nNextResend data race in ResubmitWalletTransactions

2022-09-20 11:49:57 +02:00

walletdb.cpp

wallet: bugfix, load wallet with an unknown descriptor cause fatal error

2022-09-09 15:35:04 -03:00

walletdb.h

wallet: bugfix, load wallet with an unknown descriptor cause fatal error

2022-09-09 15:35:04 -03:00

wallettool.cpp

Merge bitcoin/bitcoin#25784: Wallet: Document expectations for AddWalletFlags (now InitWalletFlags) correctly

2022-08-19 12:12:27 -04:00

wallettool.h

…

walletutil.cpp

…

walletutil.h

Implement LegacyScriptPubKeyMan::MigrateToDescriptor

2022-08-25 16:25:53 -04:00