Ava Chow 1b2dedbf5c

Merge bitcoin/bitcoin#29040: refactor: Remove pre-C++20 code, fs::path cleanup ...

66667130416b86208e01a0eb5541a15ea805ac26 refactor: Rename fs::path::u8string() to fs::path::utf8string() (MarcoFalke)
856c88776f8486446602476a1c9e133ac0cff510 ArgsManager: return path by value from GetBlocksDirPath() (Vasil Dimov)
fa3d9304e80c214c8b073f12a7f4b08c5a94af04 refactor: Remove pre-C++20 fs code (MarcoFalke)
fa00098e1a493aa3cce20335d18e7f5f2fb7a4a8 Add tests for C++20 std::u8string (MarcoFalke)
fa2bac08c22182e738a8cabf1b24a9dbf3b092d2 refactor: Avoid copy/move in fs.h (MarcoFalke)
faea30227ba633da5ab257d0247853e0927244bb refactor: Use C++20 std::chrono::days (MarcoFalke)

Pull request description:

  This:

  * Removes dead code.
  * Avoids unused copies in some places.
  * Adds copies in other places for safety.

ACKs for top commit:
  achow101:
    ACK 66667130416b86208e01a0eb5541a15ea805ac26
  ryanofsky:
    Code review ACK 66667130416b86208e01a0eb5541a15ea805ac26. Just documentation change since last review.
  stickies-v:
    re-ACK 66667130416b86208e01a0eb5541a15ea805ac26

Tree-SHA512: 6176e44f30b310d51632ec2d3827c3819905d0ddc6a4b57acfcb6cfa1f9735176da75ee8ed4a4abd1296cb0b83bee9374cc6f91ffac87c19b63c435eeadf3f46

2023-12-14 16:46:54 -05:00

..

rpc

Merge bitcoin/bitcoin#29040: refactor: Remove pre-C++20 code, fs::path cleanup

2023-12-14 16:46:54 -05:00

test

Merge bitcoin/bitcoin#29065: bench: wallet, fix change position out of range error

2023-12-13 12:45:30 -05:00

bdb.cpp

refactor: Return enum in LockDirectory

2023-10-26 10:25:22 +02:00

bdb.h

wallet: bdb: include bdb header from our implementation files only

2023-07-07 14:14:20 +00:00

coincontrol.cpp

wallet: Explicitly preserve scriptSig and scriptWitness in CreateTransaction

2023-12-08 17:12:19 -05:00

coincontrol.h

wallet: Explicitly preserve scriptSig and scriptWitness in CreateTransaction

2023-12-08 17:12:19 -05:00

coinselection.cpp

Amend bumpfee for inputs with overlapping ancestry

2023-09-13 15:46:59 -04:00

coinselection.h

Amend bumpfee for inputs with overlapping ancestry

2023-09-13 15:46:59 -04:00

context.cpp

…

context.h

interfaces: Add schedulerMockForward method so mockscheduler RPC can work across processes

2023-10-20 10:30:16 -04:00

crypter.cpp

refactor: Remove unused C-style casts

2023-07-24 15:32:00 +02:00

crypter.h

…

db.cpp

refactor: Fix bugprone-string-constructor warning

2023-10-30 14:59:17 +01:00

db.h

scripted-diff: Use DataStream in most places

2023-11-28 12:42:37 +01:00

dump.cpp

Use only Span{} constructor for byte-like types where possible

2023-06-27 10:13:37 +02:00

dump.h

…

external_signer_scriptpubkeyman.cpp

wallet: batch external signer descriptor import

2023-11-21 23:07:00 -03:00

external_signer_scriptpubkeyman.h

wallet: batch external signer descriptor import

2023-11-21 23:07:00 -03:00

feebumper.cpp

test: wallet, fix change position out of range error

2023-12-12 15:20:38 -03:00

feebumper.h

rpc: bumpfee, improve doc for 'reduce_output' arg

2023-09-26 20:17:02 -03:00

fees.cpp

…

fees.h

…

init.cpp

init: completely remove -zapwallettxes (remaining hidden option)

2023-11-03 20:00:44 +01:00

interfaces.cpp

wallet: use optional for change position as an optional in CreateTransaction

2023-12-08 17:12:19 -05:00

load.cpp

interfaces: Add schedulerMockForward method so mockscheduler RPC can work across processes

2023-10-20 10:30:16 -04:00

load.h

interfaces: Add schedulerMockForward method so mockscheduler RPC can work across processes

2023-10-20 10:30:16 -04:00

receive.cpp

Use Txid in COutpoint

2023-11-21 13:15:44 +00:00

receive.h

…

salvage.cpp

tidy: modernize-use-emplace

2023-10-12 11:27:19 +02:00

salvage.h

…

scriptpubkeyman.cpp

Merge bitcoin/bitcoin#28920: wallet: birth time update during tx scanning

2023-12-14 16:27:40 -05:00

scriptpubkeyman.h

Merge bitcoin/bitcoin#28920: wallet: birth time update during tx scanning

2023-12-14 16:27:40 -05:00

spend.cpp

Merge bitcoin/bitcoin#28994: wallet: skip BnB when SFFO is enabled

2023-12-12 10:52:12 -05:00

spend.h

test: wallet, fix change position out of range error

2023-12-12 15:20:38 -03:00

sqlite.cpp

[refactor] Define MessageStartChars as std::array

2023-09-12 22:49:49 +02:00

sqlite.h

wallet: sqlite: force sqlite3.h to be included by the cpp files

2023-07-06 19:53:44 +00:00

transaction.cpp

wallet, refactor: Add CWalletTx::updateState function

2023-10-23 17:35:36 -04:00

transaction.h

Use ParamsWrapper for witness serialization

2023-11-14 08:45:30 +10:00

types.h

…

wallet.cpp

Merge bitcoin/bitcoin#28920: wallet: birth time update during tx scanning

2023-12-14 16:27:40 -05:00

wallet.h

Merge bitcoin/bitcoin#28920: wallet: birth time update during tx scanning

2023-12-14 16:27:40 -05:00

walletdb.cpp

build: Enable -Wunreachable-code

2023-12-05 15:36:08 +01:00

walletdb.h

Clean up things that include script/standard.h

2023-08-14 17:38:27 -04:00

wallettool.cpp

…

wallettool.h

…

walletutil.cpp

…

walletutil.h

wallet: cache descriptor ID to avoid repeated descriptor string creation

2023-11-05 23:50:58 +01:00