fanquake 950af7c876

Merge bitcoin/bitcoin#28878: Remove version field from GetSerializeSize ...

83986f464c59a6517f790a960a72574e167f3f72 Include version.h in fewer places (Anthony Towns)
c7b61fd61b199cbefda660c9d394bb4035a49528 Convert some CDataStream to DataStream (Anthony Towns)
1410d300df7e57a895f2697d9849a2201021c973 serialize: Drop useless version param from GetSerializeSize() (Anthony Towns)
bf574a75016123309b894da895ab1c7a81731933 serialize: drop GetSerializeSizeMany (Anthony Towns)
efa9eb6d7c8012fe4ed85699d81c8fe5dd18da1e serialize: Drop nVersion from [C]SizeComputer (Anthony Towns)

Pull request description:

  Drops the version field from `GetSerializeSize()`, simplifying the code in various places. Also drop `GetSerializeSizeMany()` (as just removing the version parameter could result in silent bugs) and remove unnecessary instances of `#include <version.h>`.

ACKs for top commit:
  maflcko:
    ACK 83986f464c59a6517f790a960a72574e167f3f72 📒
  theuni:
    ACK 83986f464c59a6517f790a960a72574e167f3f72.

Tree-SHA512: 36617b6dfbb1b4b0afbf673e905525fc6d623d3f568d3f86e3b9d4f69820db97d099e83a88007bfff881f731ddca6755ebf1549e8d8a7762437dfadbf434c62e

2023-11-17 10:56:41 +00:00

..

rpc

Include version.h in fewer places

2023-11-16 11:36:22 +10:00

test

Use ParamsWrapper for witness serialization

2023-11-14 08:45:30 +10:00

bdb.cpp

wallet: bdb: include bdb header from our implementation files only

2023-07-07 14:14:20 +00:00

bdb.h

wallet: bdb: include bdb header from our implementation files only

2023-07-07 14:14:20 +00:00

coincontrol.cpp

…

coincontrol.h

Clean up things that include script/standard.h

2023-08-14 17:38:27 -04:00

coinselection.cpp

Amend bumpfee for inputs with overlapping ancestry

2023-09-13 15:46:59 -04:00

coinselection.h

Amend bumpfee for inputs with overlapping ancestry

2023-09-13 15:46:59 -04:00

context.cpp

…

context.h

interfaces: Add schedulerMockForward method so mockscheduler RPC can work across processes

2023-10-20 10:30:16 -04:00

crypter.cpp

refactor: Remove unused C-style casts

2023-07-24 15:32:00 +02:00

crypter.h

…

db.cpp

refactor: Fix bugprone-string-constructor warning

2023-10-30 14:59:17 +01:00

db.h

wallet: Add GetPrefixCursor to DatabaseBatch

2023-06-01 13:09:08 -04:00

dump.cpp

Use only Span{} constructor for byte-like types where possible

2023-06-27 10:13:37 +02:00

dump.h

…

external_signer_scriptpubkeyman.cpp

refactor: Move system from util to common library

2023-05-20 12:08:13 +02:00

external_signer_scriptpubkeyman.h

…

feebumper.cpp

Merge bitcoin/bitcoin#28605: Fix typos

2023-11-16 10:35:49 +00:00

feebumper.h

rpc: bumpfee, improve doc for 'reduce_output' arg

2023-09-26 20:17:02 -03:00

fees.cpp

…

fees.h

…

init.cpp

init: completely remove -zapwallettxes (remaining hidden option)

2023-11-03 20:00:44 +01:00

interfaces.cpp

Merge bitcoin/bitcoin#28721: multiprocess compatibility updates

2023-11-13 12:32:55 +00:00

load.cpp

interfaces: Add schedulerMockForward method so mockscheduler RPC can work across processes

2023-10-20 10:30:16 -04:00

load.h

interfaces: Add schedulerMockForward method so mockscheduler RPC can work across processes

2023-10-20 10:30:16 -04:00

receive.cpp

…

receive.h

…

salvage.cpp

tidy: modernize-use-emplace

2023-10-12 11:27:19 +02:00

salvage.h

…

scriptpubkeyman.cpp

wallet: cache descriptor ID to avoid repeated descriptor string creation

2023-11-05 23:50:58 +01:00

scriptpubkeyman.h

Merge bitcoin/bitcoin#28508: refactor: Remove SER_GETHASH, hard-code client version in CKeyPool serialize

2023-10-02 12:33:54 +02:00

spend.cpp

Merge bitcoin/bitcoin#28878: Remove version field from GetSerializeSize

2023-11-17 10:56:41 +00:00

spend.h

Amend bumpfee for inputs with overlapping ancestry

2023-09-13 15:46:59 -04:00

sqlite.cpp

[refactor] Define MessageStartChars as std::array

2023-09-12 22:49:49 +02:00

sqlite.h

wallet: sqlite: force sqlite3.h to be included by the cpp files

2023-07-06 19:53:44 +00:00

transaction.cpp

wallet, refactor: Add CWalletTx::updateState function

2023-10-23 17:35:36 -04:00

transaction.h

Use ParamsWrapper for witness serialization

2023-11-14 08:45:30 +10:00

types.h

…

wallet.cpp

wallet: Add asserts to detect unset transaction height values

2023-10-23 17:35:36 -04:00

wallet.h

Merge bitcoin/bitcoin#28605: Fix typos

2023-11-16 10:35:49 +00:00

walletdb.cpp

Move CScriptID to script.{h/cpp}

2023-08-14 17:38:27 -04:00

walletdb.h

Clean up things that include script/standard.h

2023-08-14 17:38:27 -04:00

wallettool.cpp

…

wallettool.h

…

walletutil.cpp

…

walletutil.h

wallet: cache descriptor ID to avoid repeated descriptor string creation

2023-11-05 23:50:58 +01:00