Ava Chow 482d255376

Merge bitcoin/bitcoin#32736: wallet: Correct dir iteration error handling ...

272cd09b796a36596b325277bb43cb47b19c8e12 log: Use warning level while scanning wallet dir (MarcoFalke)
17776443675ddf804f92042883ad36ed040438c3 qa, wallet: Verify warning when failing to scan (Hodlinator)
893e51ffeb0543e1c8d33e83b20c56f02d2b793c wallet: Correct dir iteration error handling (Hodlinator)

Pull request description:

  Make wallet DB properly detect and report failure to scan wallet directory. Seems to have been broken since moving from Boost to `std::filesystem`.

  Found while reviewing: https://github.com/bitcoin/bitcoin/pull/31410#pullrequestreview-2604068753

ACKs for top commit:
  achow101:
    ACK 272cd09b796a36596b325277bb43cb47b19c8e12
  maflcko:
    re-ACK 272cd09b796a36596b325277bb43cb47b19c8e12 🍽
  rkrux:
    tACK 272cd09b796a36596b325277bb43cb47b19c8e12

Tree-SHA512: 969afde2e37f885ed0c823dc36d2dbeaa0378639849c6a26f8ac67b4f1997eea95bbcae6d58aef5b716807210f37eb166c0cda7ba1d6caffd34249970833af3a

2025-06-20 12:47:28 -07:00

..

rpc

Merge bitcoin/bitcoin#32481: wallet, refactor: Remove Legacy wallet unused warnings and errors

2025-06-13 17:27:39 -07:00

test

refactor: Sort includes of touched source files

2025-06-03 19:56:55 +02:00

CMakeLists.txt

build, wallet, doc: Remove BDB

2025-05-06 12:21:32 -07:00

coincontrol.cpp

…

coincontrol.h

[wallet, rpc]: add max_tx_weight to tx funding options

2024-06-27 15:31:21 +01:00

coinselection.cpp

Remove unused variable assignment

2024-12-13 21:00:07 -06:00

coinselection.h

Merge bitcoin/bitcoin#29523: Wallet: Add max_tx_weight to transaction funding options (take 2)

2024-07-17 18:27:59 -04:00

context.cpp

…

context.h

…

crypter.cpp

refactor: vector -> span in CCrypter

2024-08-28 19:09:51 +02:00

crypter.h

wallet: refactor: introduce CMasterKey::DEFAULT_DERIVE_ITERATIONS constant

2025-01-27 18:11:05 +01:00

db.cpp

log: Use warning level while scanning wallet dir

2025-06-13 13:55:54 +02:00

db.h

wallet: init, don't error out when loading legacy wallets

2025-05-15 15:14:29 -04:00

dump.cpp

doc: fix typos

2025-06-03 08:09:28 +01:00

dump.h

…

external_signer_scriptpubkeyman.cpp

wallet: use PSBTError::EXTERNAL_SIGNER_NOT_FOUND

2025-06-05 11:46:08 +02:00

external_signer_scriptpubkeyman.h

refactor: use util::Result for GetExternalSigner()

2025-06-05 11:32:23 +02:00

feebumper.cpp

Merge bitcoin/bitcoin#31622: psbt: add non-default sighash types to PSBTs and unify sighash type match checking

2025-05-21 10:02:49 +01:00

feebumper.h

wallet, refactor: Convert uint256 to Txid in wallet

2025-05-07 16:17:19 +01:00

fees.cpp

…

fees.h

…

init.cpp

build, wallet, doc: Remove BDB

2025-05-06 12:21:32 -07:00

interfaces.cpp

wallet, interfaces: Use BERKELEY_RO in isEncrypted

2025-06-04 16:51:51 -07:00

load.cpp

Merge bitcoin/bitcoin#32449: wallet: init, don't error out when loading legacy wallets

2025-06-02 13:31:35 -07:00

load.h

wallet: Remove unnecessary database Close step on shutdown

2025-05-14 11:03:57 -07:00

migrate.cpp

doc: remove For ... comments

2025-05-19 16:40:33 +01:00

migrate.h

wallet: Remove unused db functions

2025-05-06 16:53:16 -07:00

receive.cpp

wallet, refactor: Convert uint256 to Txid in wallet

2025-05-07 16:17:19 +01:00

receive.h

wallet, refactor: Convert uint256 to Txid in wallet

2025-05-07 16:17:19 +01:00

scriptpubkeyman.cpp

doc: fix typos

2025-06-03 08:09:28 +01:00

scriptpubkeyman.h

wallet, refactor: Remove unused SetupGeneration

2025-06-10 16:34:17 -03:00

spend.cpp

doc: fix typos

2025-06-03 08:09:28 +01:00

spend.h

doc: remove For ... comments

2025-05-19 16:40:33 +01:00

sqlite.cpp

refactor: Sort includes of touched source files

2025-06-03 19:56:55 +02:00

sqlite.h

threading: semaphore: move CountingSemaphoreGrant to its own header

2025-05-10 03:31:30 +00:00

transaction.cpp

…

transaction.h

wallet: Drop unused fFromMe from CWalletTx

2025-05-14 11:23:22 -07:00

types.h

scripted-diff: modernize outdated trait patterns - types

2025-02-21 10:41:27 +01:00

wallet.cpp

Merge bitcoin/bitcoin#32682: wallet: have external signer use PSBT error code EXTERNAL_SIGNER_NOT_FOUND

2025-06-16 17:32:57 -07:00

wallet.h

wallet, rpc: remove obsolete "keypoololdest" result field/code

2025-05-23 00:26:01 +02:00

walletdb.cpp

Merge bitcoin/bitcoin#32449: wallet: init, don't error out when loading legacy wallets

2025-06-02 13:31:35 -07:00

walletdb.h

refactor: Sort includes of touched source files

2025-06-03 19:56:55 +02:00

wallettool.cpp

Remove create options from wallet tool

2025-05-09 15:07:04 +02:00

wallettool.h

…

walletutil.cpp

descriptors: Change Parse to return vector of descriptors

2024-08-08 12:47:22 -04:00

walletutil.h

Merge bitcoin/bitcoin#22838: descriptors: Be able to specify change and receiving in a single descriptor string

2024-08-28 15:56:15 +01:00