Ryan Ofsky 39950e148d

Merge bitcoin/bitcoin#31295: refactor: Prepare compile-time check of bilingual format strings ...

fa3e074304780549b1e7972217930e34fa55f59a refactor: Tidy fixups (MarcoFalke)
fa72646f2b197810a324cb0544d9a1fac37d3f9c move-only: Detail_CheckNumFormatSpecifiers and G_TRANSLATION_FUN (MarcoFalke)
faff8403f0aac3b5ec26d3c7fc98240f879f9906 refactor: Pick translated string after format (MarcoFalke)

Pull request description:

  The changes are required for https://github.com/bitcoin/bitcoin/pull/31061, however they also make sense on their own. For example, they are fixing up an `inline namespace`, which lead to compile errors otherwise (can be tested by observing the compile error after reverting the changes to `src/util/strencodings.h`). Also, a unit test comment is fixed.

ACKs for top commit:
  ryanofsky:
    Code review ACK fa3e074304780549b1e7972217930e34fa55f59a. Nice changes! These should allow related PRs to be simpler.
  l0rinc:
    ACK fa3e074304780549b1e7972217930e34fa55f59a
  hodlinator:
    cr-ACK fa3e074304780549b1e7972217930e34fa55f59a

Tree-SHA512: 37371181a348610442186b5fbb7a6032d0caf70aae566002ad60be329a3131a2b89f28f6c51e10872079f987986925dc8c0611bde639057bee4f572d2b9ba92a

2024-12-04 11:15:58 -05:00

..

any.h

…

asmap.cpp

streams: cache file position within AutoFile

2024-09-13 07:35:41 -04:00

asmap.h

…

batchpriority.cpp

…

batchpriority.h

…

bip32.cpp

…

bip32.h

…

bitdeque.h

refactor: Fix "error C2248: cannot access private member" on MSVC

2024-04-28 07:11:24 +01:00

bitset.h

util: add BitSet

2024-06-10 07:54:48 -04:00

bytevectorhash.cpp

random: get rid of GetRand by inlining

2024-07-01 12:39:53 -04:00

bytevectorhash.h

…

chaintype.cpp

testnet: Introduce Testnet4

2024-08-06 01:38:10 +02:00

chaintype.h

testnet: Introduce Testnet4

2024-08-06 01:38:10 +02:00

check.cpp

Make G_FUZZING constexpr, require -DBUILD_FOR_FUZZING=ON to execute a fuzz target

2024-10-31 13:51:37 +01:00

check.h

Make G_FUZZING constexpr, require -DBUILD_FOR_FUZZING=ON to execute a fuzz target

2024-10-31 13:51:37 +01:00

CMakeLists.txt

common: move pcp.cpp and netif.cpp files from util to common library since they depend on netaddress.cpp

2024-10-01 09:28:31 -04:00

epochguard.h

…

exception.cpp

…

exception.h

…

fastrange.h

…

feefrac.cpp

Avoid explicitly computing diagram; compare based on chunks

2024-04-22 09:36:36 -04:00

feefrac.h

clusterlin: add DepGraph::RemoveTransactions and support for holes in DepGraph

2024-10-07 13:49:35 -04:00

fs_helpers.cpp

build: Replace MAC_OSX macro with existing __APPLE__

2024-10-24 12:29:26 +02:00

fs_helpers.h

util: add perm string helper functions

2024-06-27 14:55:10 +01:00

fs.cpp

Add tests for C++20 std::u8string

2023-12-11 17:42:05 +01:00

fs.h

refactor: Rename fs::path::u8string() to fs::path::utf8string()

2023-12-14 16:22:40 +01:00

golombrice.h

…

hash_type.h

…

hasher.cpp

random: get rid of GetRand by inlining

2024-07-01 12:39:53 -04:00

hasher.h

Bump g++ minimum supported version to 10

2023-10-30 15:12:26 +01:00

insert.h

…

macros.h

…

moneystr.cpp

util: Move util/string.h functions to util namespace

2024-05-16 10:16:08 -05:00

moneystr.h

…

overflow.h

…

overloaded.h

doc: Clarify C++20 comments

2024-01-05 11:22:31 +01:00

rbf.cpp

…

rbf.h

…

readwritefile.cpp

…

readwritefile.h

…

result.h

refactor: Avoid copying util::Result values

2024-04-25 16:08:24 -04:00

serfloat.cpp

…

serfloat.h

…

signalinterrupt.cpp

util: Get rid of uncaught exceptions thrown by SignalInterrupt class

2023-12-04 15:39:15 -04:00

signalinterrupt.h

util: Get rid of uncaught exceptions thrown by SignalInterrupt class

2023-12-04 15:39:15 -04:00

sock.cpp

sock: change Sock::SendComplete() to take Span

2023-10-31 18:19:22 +01:00

sock.h

sock: change Sock::SendComplete() to take Span

2023-10-31 18:19:22 +01:00

strencodings.cpp

util: remove unused IsHexNumber

2024-08-23 13:53:40 +01:00

strencodings.h

move-only: Detail_CheckNumFormatSpecifiers and G_TRANSLATION_FUN

2024-11-15 17:16:27 +01:00

string.cpp

util: Move util/string.h functions to util namespace

2024-05-16 10:16:08 -05:00

string.h

move-only: Detail_CheckNumFormatSpecifiers and G_TRANSLATION_FUN

2024-11-15 17:16:27 +01:00

subprocess.h

tidy: modernize-use-equals-default

2024-07-08 11:12:01 +02:00

syserror.cpp

scripted-diff: drop config/ subdir for bitcoin-config.h, rename to bitcoin-build-config.h

2024-10-10 12:22:12 +02:00

syserror.h

Show descriptive error messages when FileCommit fails

2023-06-30 09:48:21 -04:00

task_runner.h

tidy: modernize-use-equals-default

2024-07-08 11:12:01 +02:00

thread.cpp

…

thread.h

…

threadinterrupt.cpp

…

threadinterrupt.h

…

threadnames.cpp

build: Replace MAC_OSX macro with existing __APPLE__

2024-10-24 12:29:26 +02:00

threadnames.h

util: avoid using thread_local variable that has a destructor

2024-05-16 18:16:46 +02:00

time.cpp

util: Implement ParseISO8601DateTime based on C++20

2024-12-02 08:21:32 +01:00

time.h

util: Implement ParseISO8601DateTime based on C++20

2024-12-02 08:21:32 +01:00

tokenpipe.cpp

scripted-diff: drop config/ subdir for bitcoin-config.h, rename to bitcoin-build-config.h

2024-10-10 12:22:12 +02:00

tokenpipe.h

…

trace.h

tracing: only prepare tracepoint args if attached

2024-10-28 14:27:47 +01:00

transaction_identifier.h

refactor: remove TxidFromString

2024-07-31 16:47:39 +01:00

translation.h

move-only: Detail_CheckNumFormatSpecifiers and G_TRANSLATION_FUN

2024-11-15 17:16:27 +01:00

types.h

doc: Clarify C++20 comments

2024-01-05 11:22:31 +01:00

ui_change_type.h

…

vecdeque.h

utils: add missing include

2024-06-11 16:28:11 +00:00

vector.h

chainparams: add blockhash to AssumeutxoData

2023-09-30 06:38:47 -04:00