laanwj 159f89c118

Merge bitcoin/bitcoin#24365: wallet: Don't generate keys for wallets with private keys disabled during upgradewallet ...

c7376cc8d728f3a7c40f79bd57e7cef685def723 tests: Test upgrading wallet with privkeys disabled (Andrew Chow)
3d985d4f43b5344f998bcf6db22d02782e647a2a wallet: Don't generate keys when privkeys disabled when upgrading (Andrew Chow)

Pull request description:

  When we're upgrading a wallet, we shouldn't be trying to generate new keys for wallets where private keys are disabled.

  Fixes #23610

ACKs for top commit:
  laanwj:
    Code review ACK c7376cc8d728f3a7c40f79bd57e7cef685def723
  benthecarman:
    tACK c7376cc8d728f3a7c40f79bd57e7cef685def723 this fixed the issue for me

Tree-SHA512: fa07cf37df9196ff98671bb1ce5c9aa0bab46495066b4dab796d7e8e5d5c7adb414ff56adae4fd3e15658a610995bd19a9e1edb00c46144b0df635c5b343f3a6

2022-02-28 13:15:11 +01:00

..

rpc

Replace "can not" with "cannot" in docs, user messages, and tests

2022-02-21 19:07:29 +01:00

test

doc: Fix typos

2022-02-17 03:42:08 +09:00

bdb.cpp

refactor: replace boost::filesystem with std::filesystem

2022-02-03 18:35:52 +08:00

bdb.h

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

coincontrol.cpp

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

coincontrol.h

wallet: add input weights to CCoinControl

2022-01-24 11:23:31 -05:00

coinselection.cpp

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

coinselection.h

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

context.cpp

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

context.h

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

crypter.cpp

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

crypter.h

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

db.cpp

refactor: replace boost::filesystem with std::filesystem

2022-02-03 18:35:52 +08:00

db.h

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

dump.cpp

refactor: replace boost::filesystem with std::filesystem

2022-02-03 18:35:52 +08:00

dump.h

refactor: replace boost::filesystem with std::filesystem

2022-02-03 18:35:52 +08:00

external_signer_scriptpubkeyman.cpp

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

external_signer_scriptpubkeyman.h

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

feebumper.cpp

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

feebumper.h

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

fees.cpp

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

fees.h

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

init.cpp

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

interfaces.cpp

interfaces: Remove unused is_final

2022-01-14 11:28:45 +01:00

ismine.h

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

load.cpp

Use ArgsManager::GetPathArg() for "-walletdir" option

2022-02-09 19:31:23 +02:00

load.h

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

receive.cpp

wallet: Avoid dropping confirmed coins

2022-01-25 10:15:12 +01:00

receive.h

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

salvage.cpp

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

salvage.h

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

scriptpubkeyman.cpp

wallet: Don't generate keys when privkeys disabled when upgrading

2022-02-16 22:53:27 -05:00

scriptpubkeyman.h

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

spend.cpp

User-facing content fixups from transifex translator feedback

2022-02-17 12:59:30 +01:00

spend.h

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

sqlite.cpp

Merge bitcoin/bitcoin#23438: refactor: Use spans of std::byte in serialize

2022-01-27 19:19:12 +01:00

sqlite.h

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

transaction.cpp

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

transaction.h

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

wallet.cpp

Merge bitcoin/bitcoin#24401: wallet: Add external-signer-support specific error message

2022-02-23 17:19:49 -05:00

wallet.h

wallet: Allow user specified input size to override

2022-01-24 11:23:31 -05:00

walletdb.cpp

wallet: Add external-signer-support specific error message

2022-02-20 21:04:23 +02:00

walletdb.h

wallet: Add external-signer-support specific error message

2022-02-20 21:04:23 +02:00

wallettool.cpp

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

wallettool.h

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00

walletutil.cpp

Use ArgsManager::GetPathArg() for "-walletdir" option

2022-02-09 19:31:23 +02:00

walletutil.h

Add src/wallet/* code to wallet:: namespace

2022-01-06 22:14:16 -05:00