cryptogera/bitcoin
1
0
Fork 0
mirror of https://github.com/bitcoin/bitcoin.git synced 2026-02-12 16:41:46 +00:00
Code Issues Packages Projects Releases Wiki Activity
bitcoin/src/test/util
History
MarcoFalke 4b705b1c98
Merge #19098: test: Remove duplicate NodeContext hacks 
edc316020e8270dafc5e31465d532baebdafd3dd test: Remove duplicate NodeContext hacks (Russell Yanofsky)

Pull request description:

  Qt tests currently are currently using two NodeContext structs at the same time, one in interfaces::NodeImpl::m_context, and the other in BasicTestingSetup::m_node, and the tests have hacks transferring state between them.

  Fix this by getting rid of the NodeImpl::m_context struct and making it a pointer. This way a common BitcoinApplication object can be used for all qt tests, but they can still have their own testing setups.

  Non-test code is changing but non-test behavior is still the same as before.

  Motivation for this PR is to be able to remove the "std::move(test.m_node.connman)" and mempool hacks for swapping individual NodeContext members in Qt tests, because followup PR #19099 adds yet another member (wallet_client) that needs to be swapped. After this change, the whole NodeContext struct can be swapped instead of individual members, so the workarounds are less fragile and invasive.

ACKs for top commit:
  MarcoFalke:
    crACK edc316020e8270dafc5e31465d532baebdafd3dd 🌮
  promag:
    ACK edc316020e8270dafc5e31465d532baebdafd3dd.

Tree-SHA512: c1650e4127f43a4020304ca7c13b5d9122fb5723aacd8fa1cf855d03c6052fcfb7685810aa2a5ef708561015f0022fecaacbad479295104ca45d2c17579466a4
2020-08-07 08:07:37 +02:00
..
blockfilter.cpp
…
blockfilter.h
…
logging.cpp
test: Add CreateWalletFromFile test
2020-04-26 20:23:05 -04:00
logging.h
test: Add CreateWalletFromFile test
2020-04-26 20:23:05 -04:00
mining.cpp
scripted-diff: Replace EnsureChainman with Assert in unit tests
2020-06-15 07:39:26 -04:00
mining.h
rpc: Remove mempool global from miner
2019-12-23 06:12:10 +07:00
net.cpp
fuzz: Add process_messages harness
2020-04-05 10:46:24 +08:00
net.h
fuzz: Add process_messages harness
2020-04-05 10:46:24 +08:00
README.md
…
setup_common.cpp
Merge #19098: test: Remove duplicate NodeContext hacks
2020-08-07 08:07:37 +02:00
setup_common.h
Merge #19277: util: Add Assert identity function
2020-07-04 08:44:45 -04:00
str.cpp
…
str.h
[test] move string helper functions into test library
2019-11-25 01:33:17 +01:00
transaction_utils.cpp
scripted-diff: Bump copyright headers
2020-04-16 13:33:09 -04:00
transaction_utils.h
scripted-diff: TxoutType C++11 scoped enum class
2020-06-21 06:41:55 -04:00
wallet.cpp
Locking: Lock cs_KeyStore instead of cs_wallet in legacy keyman
2020-01-23 16:34:28 -05:00
wallet.h
[test] move wallet helper functions into test library
2019-11-25 16:40:09 +01:00

README.md

Test library

This contains files for the test library, which is used by the test binaries (unit tests, benchmarks, fuzzers, gui tests).

Generally, the files in this folder should be well-separated modules. New code should be added to existing modules or (when in doubt) a new module should be created.

The utilities in here are compiled into a library, which does not hold any state. However, the main file setup_common defines the common test setup for all test binaries. The test binaries will handle the global state when they instantiate the BasicTestingSetup (or one of its derived classes).